EnZaXD
1b03e24160
Move VV specific item handling out of component<->nbt conversion in 1.20.3->1.20.5 ( #4094 )
...
The current code backups the tag in CUSTOM_DATA inside the toStructuredItem function which in VB is used for to server packets which causes bad data, this PR moves the backup logic out to the VV specific handler and also prevents toOldItem logic for using the backup to ever get executed in VB. The counterpart PR will add proper handling for CUSTOM_DATA.
Fixes https://github.com/ViaVersion/ViaVersion/issues/4092
2024-08-14 09:31:27 +02:00
Nassim Jahnke
fcd91bb855
Add item cost and particle types to item rewriter
2024-08-13 12:45:36 +02:00
Nassim Jahnke
bda4ea9fd0
[ci skip] Move template protocol into common module
...
Had to move the rewriter classes into the flattened package to make them package private, but this is nicer than having a separate module just for those
2024-08-13 10:24:20 +02:00
Nassim Jahnke
cc1c88001f
Hotfix item id changes in item hover events
2024-08-07 17:36:42 +02:00
Nassim Jahnke
274f98c24e
Fix double remapping of area effect cloud particle in 1.20.2->.3
...
Fixes #4042
2024-08-07 15:37:14 +02:00
EnZaXD
aa22ca1d56
Handle pitch/yaw->data item frame rotation change in 1.16.4->1.17 ( #4064 )
...
See https://github.com/ViaVersion/ViaBackwards/pull/848
2024-08-07 13:02:51 +02:00
Nassim Jahnke
802e868b2e
Track sent armor trim registries in 1.20.3->1.20.5
2024-08-07 12:36:51 +02:00
Nassim Jahnke
02442a9775
Only resend attribute modifiers when necessary
...
Fixes #3973
2024-08-07 11:59:13 +02:00
Nassim Jahnke
a8ef3c890a
Only add dummy enchantment once
2024-08-06 15:21:18 +02:00
EnZaXD
434b32cad8
Fix typo in ViaManagerImpl#destroy log message ( #4073 )
2024-08-05 09:30:48 +02:00
EnZaXD
60b3ba6bb7
Include snakeyaml into final jar, delete compat layers ( #4070 )
...
Snakeyaml is an untypical library which most Via platforms don't have and also broke in the past with V2, having it directly in the jar like Gson cleans up the build scripts massively, reduces the build time and also doesn't break in the future if they release V3 or any other breaking changes.
2024-08-05 09:30:34 +02:00
EnZaXD
864beef341
Regenerate toString() functions and remove them from protocol internals ( #4072 )
2024-08-05 09:09:34 +02:00
Nassim Jahnke
462a10363c
Only print reload info when needed, add additional log message after shutdown
...
Thanks to its name and dependency order, ViaVersion will generally be the last plugin to be disabled and has occasionally been blamed for other plugins stalling server shutdown
2024-08-03 20:35:22 +02:00
Nassim Jahnke
48d5aaf8fa
5.0.2 Release
2024-07-28 14:37:59 +02:00
EnZaXD
41b0d95d70
Fix horse/llama's armor/carpet not visible in 1.20.3->1.20.5 ( #4052 )
2024-07-27 20:26:53 +02:00
EnZaXD
b599399c48
Cleanup 1.20->1.20.2 item and recipe rewriter ( #4050 )
2024-07-27 19:53:59 +02:00
EnZaXD
721e27eb39
Rewrite show_item in translation components in 1.11.1->1.12 ( #4053 )
...
Fixes https://github.com/ViaVersion/ViaVersion/issues/4051
2024-07-27 19:53:44 +02:00
RK_01
b1f64fd081
Use enhanced switches in more places ( #4043 )
2024-07-24 14:32:36 +02:00
EnZaXD
2b508567db
Move damage types 1.20.3 into nbt file ( #4026 )
2024-07-24 13:13:36 +02:00
EnZaXD
24d0ae7607
Add ViaManager#addPostEnableListener ( #4038 )
2024-07-22 18:24:06 +02:00
EnZaXD
40a44d5dc5
Remove version type from dump ( #4036 )
2024-07-22 17:45:21 +02:00
EnZaXD
b5a06181d4
Fix item projectile hierarchy in 1.14+ ( #4034 )
2024-07-22 17:44:07 +02:00
EnZaXD
35fa7e78a0
Handle attribute_modifiers inside container components in 1.21->1.20.5 ( #4035 )
...
Closes https://github.com/ViaVersion/ViaVersion/issues/3968
2024-07-22 17:42:25 +02:00
EnZaXD
3906b47654
Apply required changes for ViaAprilFools ( #4033 )
...
1. Allow the version provider to get the client version sent through the handshake packet
2. Allow platform to override provider instead
2024-07-21 17:45:13 +02:00
Nassim Jahnke
1476adb281
Slightly improve logging on config loading errors
2024-07-21 12:12:06 +02:00
EnZaXD
f2f0be0581
Allow base protocols to set client version ( #4029 )
2024-07-20 09:15:15 +02:00
EnZaXD
5ec30ef18a
Expose origin version in RedirectProtocolVersion ( #4030 )
2024-07-20 09:12:44 +02:00
Nassim Jahnke
0915afe43b
Handle 1.21 attribute id changes
...
Fixes #4005
2024-07-19 11:26:28 +02:00
EnZaXD
87b041bf3a
Fix block predicate conversion in 1.20.3->1.20.5 ( #4025 )
2024-07-19 11:00:00 +02:00
EnZaXD
275b09bdbb
Use SerializerVersion#toTag when converting 1.20.5->1.20.3 block predicates ( #4024 )
2024-07-19 10:54:40 +02:00
Nassim Jahnke
cc87c02020
Add shulker box block entity id if missing
2024-07-17 18:48:07 +02:00
RK_01
6bbcf7d784
Fix respawn "keep data" translation ( #4015 )
2024-07-13 11:00:12 +02:00
EnZaXD
465a2354c0
Call component rewriter in pre 1.20.3 advancement handler ( #4014 )
...
Required for ViaBackwards where we need to rewrite the translation key (and it also doesn't hurt to have this in forward protocols).
Closes https://github.com/ViaVersion/ViaBackwards/issues/819
2024-07-13 11:00:00 +02:00
EnZaXD
c59c15d6f3
[ci skip] Fix player combat packet value comments ( #4013 )
2024-07-13 10:59:47 +02:00
EnZaXD
20f7738f08
Add cancel-block-sounds option for 1.8->1.9 place/break fix ( #4011 )
2024-07-12 00:11:11 +02:00
EnZaXD
323f0fa087
Remove minimize-cooldown config option ( #4009 )
2024-07-07 18:03:35 +02:00
RK_01
3138d667a6
Fix crossbow max damage and 1.8 sword blocking using item data components ( #4010 )
2024-07-07 18:02:51 +02:00
EnZaXD
365040f59d
Handle rarity changes in trident/banner pattern item in 1.20.5->1.21 ( #4001 )
2024-07-07 17:39:30 +02:00
lowercasebtw
303d9ecf51
Hide cooldown indicator completely in 1.8->1.9 ( #4006 )
...
* Change 1.8 to 1.9 Attack Speed
* Fix The Attack Speed Value Type
* Change Attack Speed to 20
Requested/Suggested change from FlorianMichael
Co-authored-by: EnZaXD <florian.michael07@gmail.com>
---------
Co-authored-by: EnZaXD <florian.michael07@gmail.com>
2024-07-06 23:12:01 +02:00
EnZaXD
463381b84e
Rename missing metadata references to entity data ( #4007 )
2024-07-06 21:05:40 +02:00
Nassim Jahnke
7fef96d77e
Remove unneeded 1.13 enchantment translatable mappings
2024-07-03 11:32:25 +02:00
Gegy
17358120cd
Fix: delay chat acknowledgements instead of spoofing ( #3997 )
...
An easy reproduction case is to mute a player using the Social Interactions screen, let them chat, and then send a message. As ViaVersion produces its own acknowledgements, this now does not match with what the client produced and signed its messages with - so the signature will fail verification.
As an alternative, we *always* pass through the same acknowledgement bit set - and for 'spoofed' messages, we reuse the last one that we received. In the case of the chat ack packet with just an offset, we need to hold back the window by at least 20 messages to ensure we don't start making claims about whether the client saw a message that ViaVersion cannot yet make a judgement on.
2024-07-03 10:52:01 +02:00
EnZaXD
e6da77cf47
Handle Slot tag inside CONTAINER tag in 1.20.3->1.20.5 ( #3995 )
...
Fixes shulker box tooltips not showing all items for 1.20.3 clients on 1.20.5+ servers
2024-07-02 11:53:34 +02:00
EnZaXD
dc503cd613
Update legacy Minecraft version warning ( #3989 )
2024-06-30 11:30:54 +02:00
Nassim Jahnke
8aa2f4be46
Handle show item hovers in more component packets
...
Because servers do weird things
2024-06-30 11:10:44 +02:00
Nassim Jahnke
c5dc5b2bf8
Actually restrict velocity change to fishing hooks
2024-06-28 15:29:06 +02:00
EnZaXD
bfbb80f708
Update unsupported java version warning ( #3988 )
...
Now links to the release which contains a guide on how to update
2024-06-27 14:56:15 +02:00
EnZaXD
248da118a9
Move bukkit-only settings into BukkitViaConfig ( #3985 )
2024-06-27 09:56:50 +02:00
EnZaXD
a987882132
Rework unsupported config options in AbstractViaConfig ( #3986 )
2024-06-27 09:54:44 +02:00
EnZaXD
bca25d4744
Rewrite filtered_pages in 1.20.2->1.20.3 ( #3983 )
2024-06-26 10:58:50 +02:00
EnZaXD
2417ffe483
Fixup horse inventory translation in 1.20.5->1.21 ( #3980 )
...
Fixes #3978
2024-06-25 15:27:02 +02:00
EnZaXD
8606e5d663
Handle both json and plain text in CommonBoss ( #3981 )
2024-06-25 15:21:34 +02:00
EnZaXD
5a0ca55b97
Add test command handler to DummyInitializer test ( #3970 )
2024-06-25 15:21:26 +02:00
Nassim Jahnke
ceb1cffb00
Cancel "message not delivered" messages
...
Fixes #3438
2024-06-25 15:19:03 +02:00
Nassim Jahnke
1ff3035bc0
Make 1.10->1.11 fishing hook position desync slightly less bad
2024-06-25 15:17:29 +02:00
EnZaXD
245f7e24e4
Fix DummyInitializer unit test to bootstrap without errors ( #3965 )
2024-06-22 11:04:11 +02:00
EnZaXD
d03207289e
Backup original book pages for creative mode clients in 1.8->1.9 ( #3952 )
2024-06-21 14:38:00 +02:00
Nassim Jahnke
64497b305a
Fix enchantment order
2024-06-20 17:42:27 +02:00
Nassim Jahnke
f5b3799db9
Use default dimension data for defaulted registry entry
2024-06-20 17:32:19 +02:00
Nassim Jahnke
00fedc7656
Also handle aqua affinity
2024-06-20 16:08:46 +02:00
Nassim Jahnke
5243c1800e
entity effect magic
...
Fixes #3927
2024-06-20 12:51:35 +02:00
Nassim Jahnke
77d702bc9b
Also handle movement related enchantments
...
Fixes #3960
2024-06-20 12:12:29 +02:00
EnZaXD
3d083cf463
Add handleMenuType function to ItemRewriter ( #3953 )
2024-06-17 16:39:01 +02:00
Nassim Jahnke
2ab62a8f4f
Protected
2024-06-17 12:48:52 +02:00
Nassim Jahnke
296f42086f
Also handle item_name item data for component rewriting
2024-06-17 12:43:18 +02:00
Nassim Jahnke
e9f547f7ba
Add ArrayUtil
2024-06-17 11:48:21 +02:00
Camotoy
b7f388b9ee
1.20.5 -> 1.20.3: nullify empty tags ( #3949 )
...
Co-authored-by: AJ Ferguson <AJ-Ferguson@users.noreply.github.com>
2024-06-17 09:42:09 +02:00
Leon
8bec05ed38
Fixup hardcore handling on join in 1.8->1.9 ( #3946 )
...
* Fix players crashing when logging into a 1.8 server on hardcore mode, Fixes #3944
* Requested change to #3944 fix
2024-06-16 22:06:39 +02:00
Nassim Jahnke
b367caa4b2
Add Charged item tag if there's charged projectiles
...
Closes ViaVersion/ViaBackwards#787
2024-06-16 21:58:07 +02:00
Nassim Jahnke
d1d279cfea
Don't send the attribute packet if the login packet hasn't been sent yet
2024-06-16 15:44:02 +02:00
Nassim Jahnke
4b44ecf6fa
Fix missed null item return value
2024-06-16 15:00:23 +02:00
Nassim Jahnke
b9474335e8
Fix container item type
2024-06-16 10:48:53 +02:00
Nassim Jahnke
f0c26d5967
Make sure we actually have block mappings before trying to apply them
2024-06-16 10:19:50 +02:00
Nassim Jahnke
aa312f7332
Merge branch 'refs/heads/dev' into preview
2024-06-16 10:19:43 +02:00
Nassim Jahnke
4210463505
Don't return null item in compound tag reading
2024-06-15 22:56:19 +02:00
EnZaXD
ec976dfb6c
Add method to remove sub commands from command handler ( #3941 )
2024-06-15 20:51:24 +02:00
Nassim Jahnke
7e60300e2e
Merge branch 'refs/heads/dev' into preview
2024-06-15 16:11:04 +02:00
EnZaXD
9a9ca9676d
Cleanup /viaversion list and pps command ( #3933 )
2024-06-15 15:53:09 +02:00
EnZaXD
c68915b261
Add /viaversion player <name|*> command ( #3932 )
2024-06-15 15:05:26 +02:00
Nassim Jahnke
524e053327
Don't add tags if they're already in there
2024-06-14 17:04:22 +02:00
EnZaXD
9e523c353a
Fix book signing in 1.8->1.9 ( #3939 )
2024-06-14 10:17:42 +02:00
Nassim Jahnke
ddf6df8097
Add new keys for item data types containing item arrays
2024-06-14 00:21:30 +02:00
Nassim Jahnke
cc6f789334
Handle block ids in tool and adventure more predicate data
2024-06-13 23:10:25 +02:00
EnZaXD
4a70e0ea2a
Fixup command registration once again ( #3937 )
2024-06-13 19:21:52 +02:00
EnZaXD
72cc9e9968
Add ability to detection level in /viaversion displayleaks ( #3934 )
2024-06-13 18:36:08 +02:00
EnZaXD
1039b8556b
Add remaining item types to item rewriter implementations ( #3931 )
2024-06-13 18:34:55 +02:00
Nassim Jahnke
e977e8db90
Write sound in explosion as proper sound event in 1.20.3->1.20.5
2024-06-13 18:30:28 +02:00
Nassim Jahnke
67a349d74b
Add tooltip_order and manually add curse enchantment tags
2024-06-12 23:22:46 +02:00
RK_01
009e2deed1
Add important 1.21 tags ( #4 )
2024-06-12 20:36:15 +02:00
Nassim Jahnke
089df6517e
1.21-rc1
2024-06-12 18:03:51 +02:00
Nassim Jahnke
d007beaeec
1.21-pre4
2024-06-12 18:03:51 +02:00
Nassim Jahnke
3d656d411d
1.21-pre3
2024-06-12 18:03:51 +02:00
Nassim Jahnke
8bc22a1bad
Handle item changes in show item components
2024-06-12 18:03:50 +02:00
Nassim Jahnke
5d0846abe2
Handle chat and horse container changes
2024-06-12 18:03:50 +02:00
Nassim Jahnke
5edb6ff411
Handle jukebox songs
2024-06-12 18:03:50 +02:00
Nassim Jahnke
251ab42c14
Update data component ids
2024-06-12 18:03:50 +02:00
Nassim Jahnke
134c3559bf
WIP 24w21b
2024-06-12 18:03:49 +02:00
Nassim Jahnke
832dbdf493
24w20a
2024-06-12 18:03:49 +02:00
Nassim Jahnke
ccc509432b
Rebase onto 5.0.0
2024-06-12 18:03:49 +02:00
Nassim Jahnke
58d7dc7ca6
24w19a
2024-06-12 18:03:49 +02:00
FlorianMichael
1fe6f72aec
Fix typo
2024-06-12 18:03:48 +02:00
Nassim Jahnke
e3312b1c80
Add basic handling for items within item components
...
No changes so far, but will most likely be needed rather sooner than later
2024-06-12 18:03:48 +02:00
Nassim Jahnke
182148dbe8
Some cleanup
2024-06-12 18:03:48 +02:00
Nassim Jahnke
b5c718098d
24w18a
...
Abstract item rewriters still need additional handling for once there are actual item changes, but this works as is for now
2024-06-12 18:03:39 +02:00
EnZaXD
01ea51e8ee
Add armor stand entity id to ENTITY_DATA in 1.20.3->.5 ( #3930 )
...
Closes https://github.com/ViaVersion/ViaVersion/issues/3929
2024-06-12 18:02:24 +02:00
EnZaXD
ae3042074e
Add trade list rewriter functions to ItemRewriter ( #3926 )
2024-06-11 15:02:04 +02:00
EnZaXD
d0ed528788
Save negative item amounts in 1.10->1.11 ( #3921 )
2024-06-09 17:07:29 +02:00
EnZaXD
2fba2c1e65
Don't send empty items in 1.8->1.9 hand item provider ( #3920 )
2024-06-09 15:52:08 +02:00
Nassim Jahnke
b77d0fedd9
Remove no longer needed empty item check in entity data
...
Also fixes bad null values being set there
2024-06-09 13:05:52 +02:00
Nassim Jahnke
1e244a126d
Handle optional item cost nullability
2024-06-07 13:51:28 +02:00
Nassim Jahnke
842cb8dac5
Change items to not be nullable in 1.20.5+
...
With the server and client actually having empty checks in many places now, this simplifies empty checks going forward
2024-06-07 13:34:46 +02:00
Nassim Jahnke
5053d739c0
Handle empty items in some thrown projectiles
...
Fixes #3909 , #3910
2024-06-07 12:24:02 +02:00
EnZaXD
bb48dc90f9
Add EntityRewriter#registerBlockStateHandler ( #3912 )
2024-06-06 11:00:18 +02:00
EnZaXD
1ea27f1077
Improve some grammar and rename update checker setting ( #3900 )
2024-06-04 12:41:12 +02:00
EnZaXD
3f72e9ea47
Don't publish extra modules ( #3901 )
2024-06-03 15:22:59 +02:00
EnZaXD
8a826b88fb
Move firework flight length appending into VB protocol ( #3902 )
2024-06-02 09:04:24 +02:00
EnZaXD
82452dbdfe
Remove bungee options from config.yml ( #3898 )
2024-06-01 20:37:38 +02:00
Nassim Jahnke
2f41d09e23
Remove deprecated codec handler
2024-06-01 16:49:50 +02:00
Nassim Jahnke
0f73304a1d
Fix trim pattern
2024-05-31 15:17:04 +02:00
EnZaXD
2a088c08ed
Handle edge cases when converting legacy components ( #3896 )
2024-05-30 22:55:03 +02:00
Nassim Jahnke
a48c3a6ec2
Move Bungee and Sponge platforms to separate plugins
...
Bungee support is half broken due to not having the same injection points as Velocity and has become less and less stable with every update. The Sponge plugin has been almost entirely unused
2024-05-30 21:52:34 +02:00
EnZaXD
5245a7ef2e
Replace DataItem constructor usages ( #3893 )
2024-05-30 10:42:55 +02:00
EnZaXD
03e8eec12e
Wrap BASE_COLOR, CONTAINER_LOOT and CONTAINER inside block entity tag in 1.20.5->.3 ( #3892 )
...
Closes https://github.com/ViaVersion/ViaBackwards/issues/763
2024-05-29 16:47:53 +02:00
EnZaXD
76abe4432f
Handle items with invalid amount in 1.20.3->.5 ( #3889 )
2024-05-29 16:46:25 +02:00
EnZaXD
af393c564f
Fixup ComponentUtil#trimStrings detection ( #3888 )
2024-05-29 10:21:50 +02:00
EnZaXD
d9446eed07
Improve block break/place detection in 1.8->1.9 ( #3886 )
...
Servers can send sound packets where the positions have a slight offset. This PR aims to improve the detection to account for that.
Closes https://github.com/ViaVersion/ViaFabricPlus/issues/333
2024-05-28 08:43:21 +02:00
Nassim Jahnke
3f7d286606
Gracefully handle empty first input item in trades
...
Fixes #3885
2024-05-27 22:15:40 +02:00
RK_01
869755ec4a
Perform deep copy in DataItem#copy ( #3883 )
2024-05-27 13:28:39 +02:00
Nassim Jahnke
e26f63c703
Clean up 1.12 recipe data handling
...
Supersedes #3880
2024-05-26 20:38:27 +02:00
Nassim Jahnke
792f52e637
Fix firework flight show item conversion
...
Fixes #3877
2024-05-26 13:02:38 +02:00
Nassim Jahnke
94e853e5cf
Add entity id to painting items
2024-05-22 10:42:38 +02:00
EnZaXD
9b1c97919c
Only soft fail CUSTOM_PAYLOAD content reading ( #3873 )
...
Reading of the channel shouldn't be soft failed as the game code only try catches content reading
2024-05-22 09:44:38 +02:00
Nassim Jahnke
01589b3c49
Always throw on serverbound custom payload errors
...
Old server versions did suppress exceptions, but that doesn't matter for us
2024-05-21 20:47:48 +02:00
Nassim Jahnke
c5756fe45c
Rename Position to BlockPosition
2024-05-21 13:05:15 +02:00
EnZaXD
9547cf160d
Fixup ComponentUtil#legacyToJsonString behavior on items with styles ( #3868 )
2024-05-21 11:30:57 +02:00
EnZaXD
659bee771b
Use mapped identifier getter when converting items in 1.20.3->.5 components ( #3869 )
2024-05-20 19:08:10 +02:00
EnZaXD
d5ccb17951
Add default firework flight length in 1.20.5->1.20.3 ( #3866 )
2024-05-20 14:11:16 +02:00
Pantera (Mad_Daniel)
47f5617f83
Fix 1.20.5->1.20.3 unpaired lodestone compass ( #3864 )
2024-05-19 11:58:25 +02:00
EnZaXD
052fb6e366
Fixup LODESTONE_TRACKER rewriting in 1.20.3->.5 and backwards ( #3862 )
2024-05-19 09:40:10 +02:00
EnZaXD
7d9c6fea69
Fix firework rewriting in 1.20.3->.5 ( #3860 )
...
Makes the explosion tag optional like it is in 1.20.4 so the tooltip shows the correct duration when crafting a firework, also fixes the type used for Flight which is byte in 1.20.4
2024-05-19 09:29:05 +02:00
EnZaXD
f92d241028
Use Key#namespaced in entity type enums ( #3858 )
2024-05-17 21:04:54 +02:00
RK_01
0427aec4ab
Fix 1.8->1.9 item rewriting ( #3859 )
2024-05-17 18:17:44 +02:00
Nassim Jahnke
5a1a22a007
Replace runnables with method in packet send methods
2024-05-16 21:55:51 +02:00
RK_01
91f31b578f
Clean up tags rewriting ( #3856 )
2024-05-16 10:31:05 +02:00
EnZaXD
1399c901d2
Add rewriter function for legacy chunk types to BlockRewriter ( #3854 )
2024-05-15 16:58:57 +02:00
EnZaXD
1d0b6cc5c4
Update data class names to indicate target version ( #3851 )
2024-05-15 10:45:07 +02:00
EnZaXD
04b31d70b2
Fixup legacy entity type hierarchy and namings ( #3849 )
2024-05-14 20:56:07 +02:00
Nassim Jahnke
0fc0259d8c
Remove version check for getting protocol path
2024-05-14 20:55:36 +02:00
Nassim Jahnke
9fd40395eb
Move occluding state ids to data file
2024-05-14 20:55:35 +02:00
Nassim Jahnke
75d86851ce
Apply IJ code reformat, rename rewriter methods, change metadata references to entity data
...
Doing lots of things in one commit to not muddy file history too much - almost all of these changes are fully automated
2024-05-14 20:55:33 +02:00
