Andrew Steinborn
f6078e9b74
Fix several problems and clean up the BungeeCord plugin messaging support.
...
Fixes #402
2020-12-26 20:52:12 -05:00
Andrew Steinborn
b1f7980c5d
Fix ForwardToPlayer subchannel, closes #406
2020-12-26 19:49:28 -05:00
Andrew Steinborn
7fe2fc71e9
Add some small debug for refcount issues with plugin messages.
2020-12-25 17:03:38 -05:00
Andrew Steinborn
07b95d46ac
Delay sending stats to bStats for 3-5 minutes after server startup
2020-12-21 20:14:57 -05:00
Andrew Steinborn
eb3868d911
Do not try to override colors in messages or server-sent messages
2020-12-21 19:56:17 -05:00
Andrew Steinborn
98b74fd220
Correctly retain message buffer for LoginPluginMessage.
...
Fixes #407
2020-12-21 13:14:38 -05:00
Andrew Steinborn
523b61e0c7
Make sure unit tests actually run(!) and fix command hints
2020-12-14 14:39:39 -05:00
Andrew Steinborn
4f5c315ef8
Remove netty-resolver-dns dependency
...
Geyser has fixed the issue in the latest builds
2020-12-14 04:29:28 -05:00
Andrew Steinborn
991aaa31b1
Revert "Stop bundling the Netty DNS resolver, we don't use it"
...
This reverts commit 88a57b77df
2020-12-13 18:47:47 -05:00
Jk C
5bd60a4b77
Fix spelling issues and grammer issue
2020-12-11 18:57:01 -07:00
Jk C
808205302e
Spelling issue
2020-12-11 16:57:13 -07:00
Andrew Steinborn
88a57b77df
Stop bundling the Netty DNS resolver, we don't use it
2020-12-10 06:56:19 -05:00
Andrew Steinborn
aef0e4a825
Update Netty to 4.1.55.Final.
2020-12-09 22:25:06 -05:00
Andrew Steinborn
2a5bb1e487
Fix tab list clearing bug.
...
Fixes regression introduced in 5da085d
2020-12-07 02:28:03 -05:00
Riley Park
5da085d82f
Adventure 4.3.0: Player list header/footer
2020-12-06 17:50:57 -08:00
Andrew Steinborn
fa2655d49b
Fix the debug message
2020-11-24 12:09:49 -05:00
Andrew Steinborn
aa7aee9dd7
Add another validation case although it's not strictly required
2020-11-24 12:05:27 -05:00
Andrew Steinborn
084b741375
Don't repeat validation in AvailableCommands
...
When deserializing an AvailableCommands packet, we do a few sanity checks to ensure the packet is valid. Some of this work was repeated for each cycle (notably the root) so we now check the children and any redirects are defined only once.
2020-11-24 12:03:34 -05:00
Andrew Steinborn
329e2b0dc9
Use our fork's removeChildByName
2020-11-16 13:09:47 -05:00
Andrew Steinborn
7ead4add67
Support custom mod argument tunneling ( #390 )
2020-11-16 02:58:00 -05:00
Andrew Steinborn
511165415d
Switch to our internal Brigadier fork
2020-11-15 23:33:16 -05:00
Andrew Steinborn
44f872eea4
Better validate addresses in configuration. Fixes #385
2020-11-07 20:43:58 -05:00
A248
46da2553fb
Permit passing PluginContainer to PluginManager#addToClasspath
2020-11-07 14:53:09 -05:00
Andrew Steinborn
d51f357fa8
Avoid unneeded copy in BackendPlaySessionHandler plugin messages
2020-11-07 10:57:03 -05:00
Andrew Steinborn
8a3b6403da
Wrap plugin message copies in unreleasable copies.
...
Trying to track down a very weird issue that barely makes sense to me.
2020-11-07 09:40:09 -05:00
Andrew Steinborn
89e1a07448
Try and explicitly specify Java 8 in the modules.
2020-11-06 18:52:00 -05:00
Andrew Steinborn
fb888c3b8a
Store players in VelocityRegisteredServer by UUID instead.
...
Fixes an issue where players would be repeated in /glist and the like.
2020-11-06 09:38:26 -05:00
Andrew Steinborn
cc89a2a1e5
We don't need to retain/release the mod list buffer in readModList
2020-11-05 20:04:31 -05:00
Gabik21
18f9368427
Fix ping response being delayed on 1.7
2020-11-05 12:32:35 +01:00
Andrew Steinborn
54c5effe27
Fix typos.
2020-11-03 16:06:30 -05:00
Andrew Steinborn
d708716ef6
Use slower server switching sequence for Legacy Forge clients
2020-11-03 15:58:03 -05:00
Andrew Steinborn
325ab19102
Move out VarintByteDecoder to improve escape analysis
2020-11-03 12:55:02 -05:00
Andrew Steinborn
9adba81d23
Use ByteBuf#clear() instead of skipping readable bytes
2020-11-02 22:44:53 -05:00
Andrew Steinborn
7944544606
Small cleanup in TransitionSessionHandler
2020-10-31 18:32:42 -04:00
Andrew Steinborn
4fb7e02326
Fix Checkstyle error
2020-10-30 06:35:35 -04:00
Andrew Steinborn
9a0affbca9
Fix disconnect issues in 1.7-specific logic.
2020-10-30 06:34:28 -04:00
Andrew Steinborn
cace7cc428
Fix typo resulting in BungeeCord plugin messaging not working
2020-10-28 20:44:50 -04:00
Andrew Steinborn
ba8d6fe42a
Really Velocity 1.1.1. Fix a missed case of 7bec4b2f1.
2020-10-28 19:06:43 -04:00
Andrew Steinborn
7bec4b2f12
Don't let clients fake being the BungeeCord plugin message channel
2020-10-28 18:54:51 -04:00
Andrew Steinborn
36ff6f63ae
Use the fallback description if the backend server description is null
...
This is technically incorrect but it seems like this is the best we can do...
2020-10-28 17:11:19 -04:00
Andrew Steinborn
4ccbb2cde2
Fix TabCompleteResponse not using Adventure to read tooltips.
2020-10-27 07:29:08 -04:00
Andrew Steinborn
9f424522ac
Authors should be a JSON array
2020-10-26 21:00:08 -04:00
Andrew Steinborn
536049995d
Fix SpotBugs complaint
2020-10-26 20:58:20 -04:00
Five (Xer)
01070f8fd2
Velocity Dump Cleanup
2020-10-27 01:43:09 +01:00
Five (Xer)
140eaaf5ab
Velocity Dump WIP Part 2
2020-10-27 01:40:32 +01:00
Five (Xer)
6331e1af3e
Velocity Dump WIP
2020-10-27 01:36:20 +01:00
A248
278930a008
Handle exceptions relating to CompletableFuture operations
...
Solves #374
2020-10-26 13:52:04 -04:00
Andrew Steinborn
8995b64dc6
Do not use the GAME_INFO chat type.
2020-10-22 03:02:09 -04:00
Andrew Steinborn
a6e708c98e
Fix Adventure sendActionBar implementation and add proper action bar sending for 1.16.2
2020-10-20 14:26:08 -04:00
Andrew Steinborn
e20c37fcba
Reintroduce two-packet respawn sequence for older clients
...
Fixes #372
2020-10-15 15:38:51 -04:00
Andrew Steinborn
6e00dbe2b7
Fix compile errors
2020-10-14 16:08:20 -04:00
Andrew Steinborn
cffc6d0a81
Fix Checkstyle error
2020-10-14 13:58:28 -04:00
Riley Park
60e917b4a1
Player has an identity
2020-10-13 22:36:51 -07:00
Andrew Steinborn
59d8bd4c78
Plugins need to be stored in a LinkedHashMap too.
2020-10-11 14:36:56 -04:00
Andrew Steinborn
7fea1c4cb2
Fix modern forwarding if a user connects over IPv6(?!?)
...
You don't see this every day...
2020-10-10 10:58:32 -04:00
Andrew Steinborn
f58b78e896
Fix typo that emitted full responses for basic ones and vice versa
2020-10-08 14:43:34 -04:00
Andrew Steinborn
5072e1085a
Revert server list ping changes
...
They are broken with ping passthrough.
2020-10-06 11:05:36 -04:00
Andrew Steinborn
706fea8a3c
Fix checkstyle error
2020-10-04 15:31:59 -04:00
Andrew Steinborn
3bf252cf45
Start optimizing server list ping.
2020-10-04 15:30:28 -04:00
Andrew Steinborn
cb74210cd8
Ensure synchronous shutdown if the user kills the process.
2020-10-02 00:23:08 -04:00
Riley Park
cc6546bea9
Update for Adventure changes
2020-09-28 05:36:35 -07:00
Andrew Steinborn
a0a0966f99
Minor code cleanup
2020-09-23 01:02:19 -04:00
Andrew Steinborn
b61321f4f7
Shorten name of DurationUtils#toTicks
2020-09-21 11:27:47 -04:00
derklaro
fae1ee8373
Track some dependency updates
...
junit: 5.3.0-M1 -> 5.7.0
slf4j: 1.7.25 -> 1.7.30
netty: 4.1.51.Final -> 4.1.52.Final
guava: 25.1-jre -> 29.0-jre
checkerFramework: 2.7.0 -> 3.6.1
jline-terminal-jansi: 3.12.1 -> 3.16.0
fastutil: 8.2.3 -> 8.4.1
async-http-client: 2.10.4 -> 2.12.1
completable-futures: 0.3.2 -> 0.3.3
gradle-wrapper: 6.6 -> 6.6.1
BREAKING CHANGE: No breaking change
2020-09-15 13:27:16 +02:00
Frank van der Heijden
2b6c271cc7
Add ability to check for command alias existence in api module
2020-09-13 19:11:40 +02:00
Andrew Steinborn
7650eedb7a
Fix compile error due to yet another breaking change in Adventure
2020-09-10 10:58:00 -04:00
Andrew Steinborn
1dd900194d
Share instances of the custom Gson type serializers
2020-09-03 16:04:21 -04:00
Andrew Steinborn
5d287306c2
Small code cleanups
2020-09-01 03:25:15 -04:00
Andrew Steinborn
5a26b4e03d
Fix coding error that caused players to time out if moving to another server fails
...
Thanks to @Gabik21 for noticing this bug.
2020-08-30 20:58:15 -04:00
Andrew Steinborn
764c8ed3e5
Fix compile error
...
While we're at it, change the newly-introduced shutdown API to use a generic Adventure component instead.
2020-08-30 07:09:52 -04:00
Andrew Steinborn
fe0d31b0f0
Update comments in MinecraftCompressEncoder to be more accurate.
2020-08-29 19:11:23 -04:00
Andrew Steinborn
d28022ab60
Move connectedServer clearing check to be done later.
2020-08-27 15:24:48 -04:00
Andrew Steinborn
80687c9e1b
Redundant word removed
2020-08-25 19:01:57 -04:00
Andrew Steinborn
7df1a9636e
Explicitly warn against offline-mode
2020-08-25 19:01:06 -04:00
Andrew Steinborn
ba7cdac812
If a command is defined on the proxy, don't include suggestions from the backend too
2020-08-24 14:53:01 -04:00
Andrew Steinborn
10a14af2ea
Include success message too
2020-08-24 14:13:46 -04:00
Andrew Steinborn
6cc173d337
Correctly handle disconnect if there is no opportunity to kick the player to another server.
2020-08-24 14:08:35 -04:00
Andrew Steinborn
01158b08a7
Implement BungeeCord IPOther message. Fixes #361
2020-08-24 10:40:50 -04:00
Andrew Steinborn
6b26daa281
Small cleanup in closeWith
2020-08-22 15:52:29 -04:00
Andrew Steinborn
005c12fb0f
Fix build on Java 11
2020-08-22 13:57:13 -04:00
Andrew Steinborn
154b50992c
Fix try list giving up after the first server.
2020-08-22 13:36:34 -04:00
Andrew Steinborn
1f621300f6
Revert #338
...
This is creating more problems than it actually solves
2020-08-22 02:40:35 -04:00
Andrew Steinborn
c47d25c88a
Upgrade to Gradle 6.6 and use SpotBugs.
...
As a result, at least one real bug was fixed! Nice.
2020-08-21 19:09:04 -04:00
Andrew Steinborn
d8dba436d6
Fix starting the proxy without any config. Fixes #359
2020-08-21 12:42:15 -04:00
Andrew Steinborn
a6ddc137ee
Reduce varint reading cost from max(1, 2n) to n+1 operations on ByteBuf
...
The previous code, in an attempt to avoid exceptions, checked in.isReadable() each iteration of the loop. This isn't very efficient since it's possible for us to know the maximum size of the varint to read: it's the minimum of either the largest size a varint can be (5 bytes) or the size of the remaining readable bytes in the buffer.
2020-08-21 01:05:04 -04:00
Andrew Steinborn
ade9deec47
Fix recent PR not loading default messages from config correctly.
2020-08-21 00:10:34 -04:00
Andrew Steinborn
c15a49ce7d
Merge pull request #356 from FrankHeijden/feature/messages
...
Make hardcoded messages configurable
2020-08-20 23:16:11 -04:00
Andrew Steinborn
1d4da8c32d
Correctly implement status protocol specification according to vanilla.
2020-08-20 15:03:38 -04:00
Frank van der Heijden
e3fe538491
Create temp default config for getting defaults
2020-08-19 23:30:34 +02:00
Frank van der Heijden
62fac7db32
Merge branch 'dev/1.1.0' into feature/messages
2020-08-19 22:17:15 +02:00
Frank van der Heijden
4c5c641e5f
Fix adventure title times
2020-08-19 20:44:58 +02:00
Frank van der Heijden
3711d56e8c
Move VelocityMessages into config.toml
2020-08-19 20:42:22 +02:00
Frank van der Heijden
9e27dac557
Add configurable messages for disconnect and kick prefix
2020-08-18 23:52:13 +02:00
Andrew Steinborn
26f3cb43c7
Clean up some Adventure support code, implement another sendMessage overload
2020-08-16 14:02:04 -04:00
kashike
5623baf1e7
Use getBoolean/putBoolean, and fix using the wrong field for respawn_anchor_works
2020-08-16 04:13:10 -07:00
Andrew Steinborn
1717d7f9b4
Add SimpleCommand.Invocation#alias function.
...
It seems like this ability is generally useful outside RawCommand, so let's add this to SimpleCommand too.
2020-08-15 16:41:35 -04:00
Andrew Steinborn
7dffa7ce33
Fix tab complete for proxy commands for 1.12.2 and below and fix command tab complete repeating suggestions
2020-08-11 14:19:00 -04:00
Andrew Steinborn
c88a3807e7
Checkstyle strikes again!
2020-08-11 13:26:00 -04:00
Andrew Steinborn
d363d80a83
Use simplified form for new empty argument types
2020-08-11 13:25:02 -04:00
Andrew Steinborn
717f2a070d
Remove any use of the word "dummy"
2020-08-11 13:24:11 -04:00
Andrew Steinborn
c0af5668b9
Merge pull request #338 from xxDark/read-timeout
...
Make initial read timeout configurable
2020-08-10 23:05:52 -04:00
Andrew Steinborn
24ca6156ac
Add missing DimensionData field
2020-08-07 14:30:33 -04:00
Andrew Steinborn
9d36f9094d
Fall back to wrapping the name in a component. Should fix #349 for real.
2020-08-07 07:19:22 -04:00
Andrew Steinborn
46e34ddb7f
Allow serializing legacy hover events
...
Should fix #349
2020-08-06 20:53:19 -04:00
Andrew Steinborn
cab6919a46
Switch to adventure-nbt and fix server switching on 1.16.2-pre3
2020-08-06 17:38:52 -04:00
Andrew Steinborn
cb4555fa70
Merge branch 'dev/1.1.0' into future/1.16.2-velocity-1.1.0
2020-08-06 17:37:10 -04:00
Andrew Steinborn
5cceebdffc
Read PlayerListItem display names according to the protocol version.
...
Fixes #349
2020-08-06 15:13:22 -04:00
Andrew Steinborn
b34b198064
1.16.2-pre3
2020-08-06 15:08:50 -04:00
Andrew Steinborn
6cec09974a
Properly fix debug logging
2020-08-06 11:09:11 -04:00
Andrew Steinborn
b2d9e11217
Fix packet decode logging not giving useful errors
...
See #349 for context
2020-08-06 07:42:42 -04:00
Andrew Steinborn
d79c1d0407
Port of #325 for Velocity 1.1.0
...
Co-authored-by: Five (Xer) <admin@xernium.com>
2020-08-05 18:13:16 -04:00
Andrew Steinborn
3beaeb2df7
Merge pull request #341 from alexstaeding/feature/shutdown-api
...
Add shutdown methods to ProxyServer
2020-08-05 11:35:38 -04:00
Ivan Pekov
bb4bff7d34
Respect nodes' requirements ( #350 )
2020-08-05 11:33:03 -04:00
Jacob Allen
76173e4145
Add PRE_SERVER_JOIN to DisconnectEvent#LoginStatus ( #346 )
2020-08-04 16:30:17 -04:00
Andrew Steinborn
87bff1a123
Remove nextProtocolVersion from MinecraftConnection
...
ViaVersion was the only intended user. However, ViaVersion for Velocity 1.1.0 no longer uses this functionality, and so it doesn't make sense to keep it in Velocity 1.1.0.
2020-08-04 12:14:28 -04:00
Andrew Steinborn
e57c6d00c0
Move AutoReadHolderHandler after MinecraftDecoder.
2020-08-04 11:57:23 -04:00
Andrew Steinborn
2a04932112
Fix typo in register() where the primary alias would be unregistered if other aliases were specified.
2020-08-03 08:07:42 -04:00
xDark
a282afb5db
Return earlier, predict list's size for tab clearing
2020-07-31 19:23:19 +03:00
Andrew Steinborn
933c81b9bf
Fix legacy register command not allowing command overrides
2020-07-31 10:58:27 -04:00
Andrew Steinborn
5dcc0460a1
Merge pull request #340 from xxDark/channel-factory
...
Use channel factories to create new channels
2020-07-31 07:49:11 -04:00
xDark
76bef13377
Remove deprecated members
2020-07-31 14:17:31 +03:00
Andrew Steinborn
a6964bd31c
Update for breaking Adventure boss bar changes
2020-07-30 20:16:20 -04:00
Alexander Staeding
190bef375a
Add shutdown methods to ProxyServer
2020-07-30 21:48:58 +02:00
xDark
6379936f32
Fix code style
2020-07-30 17:36:57 +03:00
xDark
d65507d4d5
Use channel factories to create new channels
2020-07-30 17:34:37 +03:00
Andrew Steinborn
e3a95b4783
Actually fix accidental breaking change not allowing aliases to be overridden.
2020-07-30 06:06:37 -04:00
Andrew Steinborn
7f1ee77a69
Fix accidential breaking change not allowing aliases to be overridden.
2020-07-30 06:03:29 -04:00
Andrew Steinborn
306221a92f
Use default shutdown reason if the disconnect message is blank.
2020-07-30 06:01:38 -04:00
xDark
4958bb76e7
Add timeout property in default configuration
2020-07-29 17:30:24 +03:00
xDark
b79f6ad827
Make initial read timeout configurable
2020-07-29 16:59:39 +03:00
Andrew Steinborn
4c5636e6f7
Lie about command invocation succeeding if there is a syntax error.
...
See https://github.com/VelocityPowered/Velocity/issues/337#issuecomment-665568793
This will need an API change to resolve, but it's late right now.
2020-07-29 06:20:16 -04:00
Andrew Steinborn
b6a60b610a
Resolve (most) issues flagged by @hugmanrique in 65e1b7be87
...
This still needs to be configurable, but this is a first step towards shifting towards a more intuitive behavior.
2020-07-29 05:51:40 -04:00
Andrew Steinborn
89f98ce57d
Make Disposable interface implement Closeable
2020-07-29 05:34:15 -04:00
Andrew Steinborn
c2db8d4ac1
Swallow Throwable since plugins are naughty and don't do the right thing -_-
2020-07-29 03:58:04 -04:00
Andrew Steinborn
65e1b7be87
Hints will override the default catch-all by default
2020-07-29 03:55:59 -04:00
Andrew Steinborn
ae0bf6cfca
Fix compile with JDK 8
2020-07-29 03:47:02 -04:00
Hugo Manrique
6cc6e0f641
New command API ( #330 )
2020-07-29 03:43:16 -04:00
Andrew Steinborn
5a515f37a3
Add missing allowed check. Fixes #335
2020-07-28 16:50:34 -04:00
Andrew Steinborn
7ab56d0ca0
Correctly populate the server address in the Forge case. Fixes #334 (correctly).
2020-07-27 17:24:04 -04:00
Andrew Steinborn
c377ed4b57
Preserve plugin load order correctly
2020-07-25 17:21:42 -04:00
Andrew Steinborn
2a29813bde
Well, this is embarassing.
2020-07-24 21:15:07 -04:00
Andrew Steinborn
c3dcf9b1dd
Strictly validate server ping state
2020-07-23 11:44:48 -04:00
Andrew Steinborn
f34b5ac2fc
Yet another breaking change in the Adventure API
2020-07-22 11:18:46 -04:00
Andrew Steinborn
a55e690ad6
These aren't designed to be extended in any way.
2020-07-21 19:41:15 -04:00
Andrew Steinborn
250a35e53b
Fix typo, thanks @hugmanrique for spotting this
2020-07-21 11:52:31 -04:00
Andrew Steinborn
e32acbaae7
Disable Netty resource leak detector by default.
2020-07-21 11:20:15 -04:00
Andrew Steinborn
c3e2321994
Update this with the true default.
2020-07-20 22:08:30 -04:00
Andrew Steinborn
ecec5e487a
Add logging to command executions by players ( #332 )
2020-07-20 22:03:07 -04:00
Andrew Steinborn
cb261c6513
Better handle not failing over on a read timeout
...
The existing Velocity logic was pretty optimistic, hoping the player connection would stay alive long enough to accept a connection to another server. Now, if we notice a read timeout on the server end, we'll treat the disconnect as "unsafe" and disconnect the player immediately.
I've added a configuration option to solve the issue in the way BungeeCord does it. This could cause issues with servers that extensively modify the server pipeline and could degrade the user experience, though. Let's try this more conservative and see if it helps,
2020-07-20 21:55:33 -04:00
Andrew Steinborn
f9f60e1489
Small code cleanups and switch more stuff to adventure
2020-07-19 18:23:47 -04:00
