Andrew Steinborn
4f80d2b261
Revert strict handshake hostname checks
...
These will break TCPShield and Cosmic Guard plugins. Sad as this was a worthwhile mitigation.
2021-01-29 23:08:14 -05:00
Andrew Steinborn
501853e807
Fix Checkstyle issue for the umpteenth time...
2021-01-29 17:59:00 -05:00
Andrew Steinborn
4f6d238b39
Strictly limit the hostname size and limit it to ASCII characters only
2021-01-29 17:56:50 -05:00
Andrew Steinborn
4219bf7b09
*Actually* fix Checkstyle issues
2021-01-26 20:02:07 -05:00
Andrew Steinborn
b982c5b6ed
Fix Checkstyle issues
2021-01-26 19:59:29 -05:00
Andrew Steinborn
0c90e94e85
fix
2021-01-26 19:50:43 -05:00
Andrew Steinborn
5ceac16a82
Add upfront size checks for some packets.
...
This is simply a further protection against certain attacks which send malformed packets to the proxy.
2021-01-26 12:33:35 -05:00
Andrew Steinborn
959e75d16d
Revert "Also provide a "proper" java.util.logger logger to plugins."
...
This reverts commit 8d71ea7135
.
Totally broken
2021-01-25 09:46:42 -05:00
Andrew Steinborn
8d71ea7135
Also provide a "proper" java.util.logger logger to plugins.
2021-01-25 01:54:50 -05:00
Andrew Steinborn
4bc76b3012
Add JUL support to log4j
...
Certain badly behaved plugins insist on logging with java.util.logging. Accommodate them.
2021-01-25 01:51:32 -05:00
Andrew Steinborn
68ae92f977
Merge pull request #419 from 0-x-2-2/dev/1.1.0
...
Use keepalive queue instead of just the last keepalive.
2021-01-23 20:18:14 -05:00
0x22
7aed76ee3d
Use keepalive queue instead of just the last keepalive.
2021-01-23 18:35:14 -05:00
Andrew Steinborn
03e9fa79d6
Raise limit on JoinGame NBT reading to 2MiB.
...
This is required for particularly large mod packs (think All of Fabric 3 for instance).
2021-01-23 12:55:28 -05:00
Andrew Steinborn
fcffccf0d8
Fix typo
2021-01-23 01:35:49 -05:00
Andrew Steinborn
ce7d1dcb26
A new year, a new color for Velocity!
2021-01-23 01:34:46 -05:00
Andrew Steinborn
892ac6f626
Accept changes to compression treshold on the fly.
...
Vanilla allows this for some reason, and there has been one case where Velocity's strict behavior has caused a bug. Fix this.
2021-01-21 17:58:09 -05:00
Andrew Steinborn
567a3b2365
Swallow and more usefully log exceptions in scheduler task running.
2021-01-09 16:39:38 -05:00
Andrew Steinborn
ba1c1eef64
More clarification
2021-01-06 13:30:57 -05:00
Andrew Steinborn
4df8f70156
Rename proxy-protocol setting to haproxy-protocol to make it clearer this is for HAProxy.
2021-01-06 13:29:30 -05:00
Andrew Steinborn
1f9c24566d
Fix off-by-one error in MinecraftCompressEncoder
2020-12-31 13:18:01 -05:00
Andrew Steinborn
dc7ab0f7f5
Log server backpressure
2020-12-27 18:36:54 -05:00
Andrew Steinborn
2a1e83902d
Add support for server-side backpressure
2020-12-27 18:05:27 -05:00
Andrew Steinborn
7329d165f6
2021
2020-12-26 21:56:19 -05:00
Andrew Steinborn
6a8ec21f26
Use a different quiet exception type to indicate the user should enable a debugging flag if needed
2020-12-26 20:59:17 -05:00
Andrew Steinborn
f6078e9b74
Fix several problems and clean up the BungeeCord plugin messaging support.
...
Fixes #402
2020-12-26 20:52:12 -05:00
Andrew Steinborn
b1f7980c5d
Fix ForwardToPlayer subchannel, closes #406
2020-12-26 19:49:28 -05:00
Andrew Steinborn
7fe2fc71e9
Add some small debug for refcount issues with plugin messages.
2020-12-25 17:03:38 -05:00
Andrew Steinborn
07b95d46ac
Delay sending stats to bStats for 3-5 minutes after server startup
2020-12-21 20:14:57 -05:00
Andrew Steinborn
eb3868d911
Do not try to override colors in messages or server-sent messages
2020-12-21 19:56:17 -05:00
Andrew Steinborn
98b74fd220
Correctly retain message buffer for LoginPluginMessage.
...
Fixes #407
2020-12-21 13:14:38 -05:00
Andrew Steinborn
523b61e0c7
Make sure unit tests actually run(!) and fix command hints
2020-12-14 14:39:39 -05:00
Andrew Steinborn
4f5c315ef8
Remove netty-resolver-dns dependency
...
Geyser has fixed the issue in the latest builds
2020-12-14 04:29:28 -05:00
Andrew Steinborn
991aaa31b1
Revert "Stop bundling the Netty DNS resolver, we don't use it"
...
This reverts commit 88a57b77df
.
Breaks Geyser
2020-12-13 18:47:47 -05:00
Jk C
5bd60a4b77
Fix spelling issues and grammer issue
2020-12-11 18:57:01 -07:00
Jk C
808205302e
Spelling issue
2020-12-11 16:57:13 -07:00
Andrew Steinborn
88a57b77df
Stop bundling the Netty DNS resolver, we don't use it
2020-12-10 06:56:19 -05:00
Andrew Steinborn
aef0e4a825
Update Netty to 4.1.55.Final.
2020-12-09 22:25:06 -05:00
Andrew Steinborn
2a5bb1e487
Fix tab list clearing bug.
...
Fixes regression introduced in 5da085d
2020-12-07 02:28:03 -05:00
Riley Park
5da085d82f
Adventure 4.3.0: Player list header/footer
2020-12-06 17:50:57 -08:00
Andrew Steinborn
fa2655d49b
Fix the debug message
2020-11-24 12:09:49 -05:00
Andrew Steinborn
aa7aee9dd7
Add another validation case although it's not strictly required
2020-11-24 12:05:27 -05:00
Andrew Steinborn
084b741375
Don't repeat validation in AvailableCommands
...
When deserializing an AvailableCommands packet, we do a few sanity checks to ensure the packet is valid. Some of this work was repeated for each cycle (notably the root) so we now check the children and any redirects are defined only once.
2020-11-24 12:03:34 -05:00
Andrew Steinborn
329e2b0dc9
Use our fork's removeChildByName
2020-11-16 13:09:47 -05:00
Andrew Steinborn
7ead4add67
Support custom mod argument tunneling ( #390 )
2020-11-16 02:58:00 -05:00
Andrew Steinborn
511165415d
Switch to our internal Brigadier fork
2020-11-15 23:33:16 -05:00
Andrew Steinborn
44f872eea4
Better validate addresses in configuration. Fixes #385
2020-11-07 20:43:58 -05:00
A248
46da2553fb
Permit passing PluginContainer to PluginManager#addToClasspath
2020-11-07 14:53:09 -05:00
Andrew Steinborn
d51f357fa8
Avoid unneeded copy in BackendPlaySessionHandler plugin messages
2020-11-07 10:57:03 -05:00
Andrew Steinborn
8a3b6403da
Wrap plugin message copies in unreleasable copies.
...
Trying to track down a very weird issue that barely makes sense to me.
2020-11-07 09:40:09 -05:00
Andrew Steinborn
89e1a07448
Try and explicitly specify Java 8 in the modules.
2020-11-06 18:52:00 -05:00
Andrew Steinborn
fb888c3b8a
Store players in VelocityRegisteredServer by UUID instead.
...
Fixes an issue where players would be repeated in /glist and the like.
2020-11-06 09:38:26 -05:00
Andrew Steinborn
cc89a2a1e5
We don't need to retain/release the mod list buffer in readModList
2020-11-05 20:04:31 -05:00
Gabik21
18f9368427
Fix ping response being delayed on 1.7
2020-11-05 12:32:35 +01:00
Andrew Steinborn
54c5effe27
Fix typos.
2020-11-03 16:06:30 -05:00
Andrew Steinborn
d708716ef6
Use slower server switching sequence for Legacy Forge clients
2020-11-03 15:58:03 -05:00
Andrew Steinborn
325ab19102
Move out VarintByteDecoder to improve escape analysis
2020-11-03 12:55:02 -05:00
Andrew Steinborn
9adba81d23
Use ByteBuf#clear() instead of skipping readable bytes
2020-11-02 22:44:53 -05:00
Andrew Steinborn
7944544606
Small cleanup in TransitionSessionHandler
2020-10-31 18:32:42 -04:00
Andrew Steinborn
4fb7e02326
Fix Checkstyle error
2020-10-30 06:35:35 -04:00
Andrew Steinborn
9a0affbca9
Fix disconnect issues in 1.7-specific logic.
2020-10-30 06:34:28 -04:00
Andrew Steinborn
cace7cc428
Fix typo resulting in BungeeCord plugin messaging not working
2020-10-28 20:44:50 -04:00
Andrew Steinborn
ba8d6fe42a
Really Velocity 1.1.1. Fix a missed case of 7bec4b2f1
.
2020-10-28 19:06:43 -04:00
Andrew Steinborn
7bec4b2f12
Don't let clients fake being the BungeeCord plugin message channel
2020-10-28 18:54:51 -04:00
Andrew Steinborn
36ff6f63ae
Use the fallback description if the backend server description is null
...
This is technically incorrect but it seems like this is the best we can do...
2020-10-28 17:11:19 -04:00
Andrew Steinborn
4ccbb2cde2
Fix TabCompleteResponse not using Adventure to read tooltips.
2020-10-27 07:29:08 -04:00
Andrew Steinborn
9f424522ac
Authors should be a JSON array
2020-10-26 21:00:08 -04:00
Andrew Steinborn
536049995d
Fix SpotBugs complaint
2020-10-26 20:58:20 -04:00
Five (Xer)
01070f8fd2
Velocity Dump Cleanup
2020-10-27 01:43:09 +01:00
Five (Xer)
140eaaf5ab
Velocity Dump WIP Part 2
2020-10-27 01:40:32 +01:00
Five (Xer)
6331e1af3e
Velocity Dump WIP
2020-10-27 01:36:20 +01:00
A248
278930a008
Handle exceptions relating to CompletableFuture operations
...
Solves #374
2020-10-26 13:52:04 -04:00
Andrew Steinborn
8995b64dc6
Do not use the GAME_INFO chat type.
2020-10-22 03:02:09 -04:00
Andrew Steinborn
a6e708c98e
Fix Adventure sendActionBar implementation and add proper action bar sending for 1.16.2
2020-10-20 14:26:08 -04:00
Andrew Steinborn
e20c37fcba
Reintroduce two-packet respawn sequence for older clients
...
Fixes #372
2020-10-15 15:38:51 -04:00
Andrew Steinborn
6e00dbe2b7
Fix compile errors
2020-10-14 16:08:20 -04:00
Andrew Steinborn
cffc6d0a81
Fix Checkstyle error
2020-10-14 13:58:28 -04:00
Riley Park
60e917b4a1
Player has an identity
2020-10-13 22:36:51 -07:00
Andrew Steinborn
59d8bd4c78
Plugins need to be stored in a LinkedHashMap too.
2020-10-11 14:36:56 -04:00
Andrew Steinborn
7fea1c4cb2
Fix modern forwarding if a user connects over IPv6(?!?)
...
You don't see this every day...
2020-10-10 10:58:32 -04:00
Andrew Steinborn
f58b78e896
Fix typo that emitted full responses for basic ones and vice versa
2020-10-08 14:43:34 -04:00
Andrew Steinborn
5072e1085a
Revert server list ping changes
...
They are broken with ping passthrough.
2020-10-06 11:05:36 -04:00
Andrew Steinborn
706fea8a3c
Fix checkstyle error
2020-10-04 15:31:59 -04:00
Andrew Steinborn
3bf252cf45
Start optimizing server list ping.
2020-10-04 15:30:28 -04:00
Andrew Steinborn
cb74210cd8
Ensure synchronous shutdown if the user kills the process.
2020-10-02 00:23:08 -04:00
Riley Park
cc6546bea9
Update for Adventure changes
2020-09-28 05:36:35 -07:00
Andrew Steinborn
a0a0966f99
Minor code cleanup
2020-09-23 01:02:19 -04:00
Andrew Steinborn
b61321f4f7
Shorten name of DurationUtils#toTicks
2020-09-21 11:27:47 -04:00
derklaro
fae1ee8373
Track some dependency updates
...
junit: 5.3.0-M1 -> 5.7.0
slf4j: 1.7.25 -> 1.7.30
netty: 4.1.51.Final -> 4.1.52.Final
guava: 25.1-jre -> 29.0-jre
checkerFramework: 2.7.0 -> 3.6.1
jline-terminal-jansi: 3.12.1 -> 3.16.0
fastutil: 8.2.3 -> 8.4.1
async-http-client: 2.10.4 -> 2.12.1
completable-futures: 0.3.2 -> 0.3.3
gradle-wrapper: 6.6 -> 6.6.1
BREAKING CHANGE: No breaking change
2020-09-15 13:27:16 +02:00
Frank van der Heijden
2b6c271cc7
Add ability to check for command alias existence in api module
2020-09-13 19:11:40 +02:00
Andrew Steinborn
7650eedb7a
Fix compile error due to yet another breaking change in Adventure
2020-09-10 10:58:00 -04:00
Andrew Steinborn
1dd900194d
Share instances of the custom Gson type serializers
2020-09-03 16:04:21 -04:00
Andrew Steinborn
5d287306c2
Small code cleanups
2020-09-01 03:25:15 -04:00
Andrew Steinborn
5a26b4e03d
Fix coding error that caused players to time out if moving to another server fails
...
Thanks to @Gabik21 for noticing this bug.
2020-08-30 20:58:15 -04:00
Andrew Steinborn
764c8ed3e5
Fix compile error
...
While we're at it, change the newly-introduced shutdown API to use a generic Adventure component instead.
2020-08-30 07:09:52 -04:00
Andrew Steinborn
fe0d31b0f0
Update comments in MinecraftCompressEncoder to be more accurate.
2020-08-29 19:11:23 -04:00
Andrew Steinborn
d28022ab60
Move connectedServer clearing check to be done later.
2020-08-27 15:24:48 -04:00
Andrew Steinborn
80687c9e1b
Redundant word removed
2020-08-25 19:01:57 -04:00
Andrew Steinborn
7df1a9636e
Explicitly warn against offline-mode
2020-08-25 19:01:06 -04:00
Andrew Steinborn
ba7cdac812
If a command is defined on the proxy, don't include suggestions from the backend too
2020-08-24 14:53:01 -04:00
Andrew Steinborn
10a14af2ea
Include success message too
2020-08-24 14:13:46 -04:00