Andrew Steinborn
b369256400
Merge branch 'master' of https://github.com/creeper123123321/Velocity into creeper123123321-master
2019-03-24 13:57:26 -04:00
Andrew Steinborn
07b775d892
Notify on read-timeout instead of emitting exception
2019-03-17 19:44:22 -04:00
Andrew Steinborn
45574ce952
Remove connection pool for HTTP connections for now.
...
The upstream feature this relies on will be gone in Netty 5.x and there
is probably more benefit in using the connection's event loop to connect
to Mojang's authentication servers.
2019-03-10 23:40:18 -04:00
Andrew Steinborn
432d570474
Allow fallback to other server connections in the event of an exception.
...
Also removes some debugging code.
2019-03-10 14:11:24 -04:00
Hugo Manrique
8bb118022d
Fix implementation of #176
...
As @creeper123123321 noted on Discord, the javadoc specifies "Matches all {@link Player}s whose names start with the provided partial name.".
With the current implementation, if there were two online players named Notch and Notch2, only Notch would be returned as a singleton Collection. This PR fixes this behavior by removing the `exactMatch` code.
2019-03-09 21:02:41 +01:00
Andrew Steinborn
e2fa06fa17
Merge pull request #176 from Crypnotic/master
...
Add matchPlayer and matchServer
2019-03-09 00:15:07 -05:00
Andrew Steinborn
c7a379ebb8
Include server that we attempted to connect to in the result.
2019-03-08 23:51:47 -05:00
creeper123123321
30df2ad04b
Request read after setting auto-read to true
2019-03-08 08:48:03 -03:00
creeper123123321
b5d228028c
untested control handler
2019-03-08 08:33:28 -03:00
Andrew Steinborn
fa9d5f6499
Fire ProxyShutdownEvent _after_ the event manager thread pool shuts down
...
Fixes #177
2019-03-06 22:51:39 -05:00
Andrew Steinborn
5ccf22c5c4
Relax (i.e. remove all checks) on the hostname.
...
While validating this is a good idea, it causes too many issues in
practice. We will still clean the server address but no validation is
performed on the address.
2019-03-06 17:45:38 -05:00
Crypnotic
b35fd05d2e
Add matchPlayer and matchServer
2019-03-03 09:57:19 -06:00
Andrew Steinborn
c8e3e7ff94
Initializing the handshake registry explicitly is redundant.
2019-02-20 21:19:04 -05:00
Andrew Steinborn
3c8055019e
Actually use the correct time units for read timeouts. Fixes #174
2019-02-20 21:05:32 -05:00
Andrew Steinborn
c6dcba36c3
Fix another case where an in-flight connection would be retained.
2019-02-20 13:55:27 -05:00
Andrew Steinborn
1ec070069f
Fix misplaced connection in flight reset. Fixes #173
2019-02-19 15:09:58 -05:00
Andrew Steinborn
6a8345e045
Forgot to include equals/hashCode on the object key
2019-02-16 16:20:50 -05:00
Andrew Steinborn
b3c87ef756
Remove an errant semicolon
2019-02-16 16:17:33 -05:00
Andrew Steinborn
f4a10e64e0
More proper host/SSL setup. See #172
2019-02-16 16:16:28 -05:00
Andrew Steinborn
332f931534
More accurate length setting
2019-02-15 17:48:36 -05:00
Andrew Steinborn
f042d214d3
Update copyright year in /velocity version
2019-02-15 16:09:37 -05:00
Andrew Steinborn
a0e1359557
Fix build
2019-02-15 16:07:19 -05:00
Andrew Steinborn
02a725035c
Another round of improvements to tab complete. Fix fallback servers.
2019-02-15 16:03:15 -05:00
Andrew Steinborn
12f5bdfc48
Properly implement fallback support.
2019-02-15 15:07:38 -05:00
Slava Maspanov
c5fefd55ed
register player connection only when switched to PLAY state ( #169 )
2019-01-29 16:17:07 -05:00
Andrew Steinborn
7d4d81fff1
Improve HandshakeSessionHandler#cleanVhost()
2019-01-28 00:34:51 -05:00
Andrew Steinborn
6eb6c99fa7
Simplify MinecraftConnection release logic.
2019-01-27 22:57:40 -05:00
Andrew Steinborn
56873712ec
Use the player's event loop for their server connections.
...
This approach reduces context switching, giving us that much extra boost
in throughput.
2019-01-19 03:21:46 -05:00
Andrew Steinborn
865f9e5ef9
Bump the pool buffer size to 4MiB temporarily
2019-01-19 03:02:50 -05:00
Andrew Steinborn
e2f93c6ac6
Set Netty pooled buffer size to 2MiB
2019-01-19 02:48:11 -05:00
Andrew Steinborn
0b0fa0a352
Substantially-improved ancient server list ping support.
...
Velocity now flawlessly supports 1.6 and below server list pings along
with a notice to reconnect with a more modern version of Minecraft if
possible.
2019-01-19 01:07:30 -05:00
Andrew Steinborn
078d0ebc96
Fix bad Respawn packet ID, which broke 1.12.1
2019-01-19 00:09:18 -05:00
creeper123123321
7d6fa11a83
Don't use ByteBuf, fix varint with 0 ending
2019-01-13 08:57:54 -02:00
Andrew Steinborn
c7b6afe5b8
Fix merge checkstyle issues
2019-01-12 10:52:02 -05:00
xxDark
bc70c76aec
Some fixes ( #165 )
2019-01-12 10:47:46 -05:00
Andrew Steinborn
564b87de1d
Avoid ByteBuf#slice(). We can simply reset the reader index.
2019-01-12 00:25:11 -05:00
Andrew Steinborn
1a2b162353
Cleaner and more correct to use ByteBufs directly.
2019-01-11 18:32:03 -05:00
Andrew Steinborn
1e041963f0
Use just one byte array in the varint frame decoder.
2019-01-11 18:04:51 -05:00
Andrew Steinborn
f77384d32e
Ensure that Velocity will always resolve DNS names for HTTP async.
2019-01-11 17:51:29 -05:00
Andrew Steinborn
2b7b33bd42
Reduce object allocations in MinecraftVarintFrameDecoder.
2019-01-11 17:46:57 -05:00
Andrew Steinborn
5dbe6aa808
Rename connection field in ConnectedPlayer.
...
This sounds stupid, but YourKit really casts its net wide when it tries
to instrument usages of JDBC. Velocity doesn't use JDBC, and yet if you
run Velocity with YourKit (even without profiling active) you pay a
significant cost.
2019-01-11 17:46:33 -05:00
Andrew Steinborn
e240dac55b
No need to bring in Gson instance, when toString() does the same thing.
2019-01-06 08:47:29 -05:00
Andrew Steinborn
c30974a148
Clarifications in ProtocolUtils.
2019-01-05 14:55:01 -05:00
Andrew Steinborn
221ee510ff
Minor cleanup.
2019-01-01 04:34:31 -05:00
Andrew Steinborn
0906a436e3
Fix bug with tab-completing names on 1.12 and lower.
2019-01-01 04:34:13 -05:00
Andrew Steinborn
696b6549e5
Stronger TLS settings.
...
Velocity will now validate the hostname and use TLSv1.2 only.
2018-12-30 11:13:58 -05:00
Andrew Steinborn
8588e7f1fe
Optimize native handling further.
...
We now try to work within the boundaries given by the native. In the
case of Java natives, we work with byte arrays. With natives, always use
direct buffers.
However, the numbers do favor the natives, since they work with direct
byte buffers, without any copying. For the most part, this commit is
intended to improve the lives of Velocity users on Windows.
2018-12-30 06:16:04 -05:00
Andrew Steinborn
095a478440
Always ensure we don't pass a heap ByteBuf to the natives.
2018-12-30 04:53:47 -05:00
Andrew Steinborn
977d29ffa0
Fix Checkstyle errors
2018-12-30 03:58:50 -05:00
Andrew Steinborn
5bf936d1b9
Add unit tests
2018-12-30 03:57:05 -05:00
Andrew Steinborn
9ce4294e6e
Fix forced hosts with SRV records.
2018-12-30 03:52:50 -05:00
Andrew Steinborn
abc5ef7f5e
Full Checkstyle compliance at last.
2018-12-30 03:28:45 -05:00
Andrew Steinborn
20c3966f6f
Make PluginDependencyUtils test more consistent.
2018-12-30 03:05:26 -05:00
Andrew Steinborn
89bcc9a100
Grab most of the low-hanging fruit.
2018-12-29 17:22:36 -05:00
Andrew Steinborn
f898b766f1
Fix resource pack sending on <= Minecraft 1.9.4
2018-12-29 16:41:58 -05:00
Andrew Steinborn
0ca0c2a297
Resource pack API
2018-12-29 15:21:47 -05:00
Andrew Steinborn
68fde1e795
Adapt System.(out|err) to log4j.
2018-12-29 13:30:50 -05:00
Andrew Steinborn
1113266823
Merge branch '1.13-tab-complete'
2018-12-29 12:27:26 -05:00
Andrew Steinborn
0cc8a2a14f
Tab-completing arguments works now.
2018-12-29 12:24:10 -05:00
Andrew Steinborn
10c440af83
Consistently display disconnects.
2018-12-29 11:46:54 -05:00
Andrew Steinborn
5f3c31bc48
Fix Checkstyle issues.
2018-12-29 11:07:45 -05:00
Andrew Steinborn
76fc39660c
Merge branch 'master' into 1.13-tab-complete
2018-12-29 11:01:41 -05:00
Andrew Steinborn
256978fc15
Solve a bunch of Checkstyle warnings.
2018-12-29 10:57:55 -05:00
Andrew Steinborn
21b20d5dc3
Obfuscate exceptions from user connection.
2018-12-29 10:13:38 -05:00
Andrew Steinborn
2cedb457ce
[WIP] Inject commands for Minecraft 1.13+
2018-12-29 09:28:24 -05:00
Andrew Steinborn
b6944bbec2
Use EnumSet in StateRegistry.PacketRegistry.
2018-12-28 13:08:22 -05:00
Andrew Steinborn
9bbe25fc90
Improve efficiency of Java implementation of natives.
2018-12-28 13:02:46 -05:00
Andrew Steinborn
566a306d18
Clarity improvements.
2018-12-28 13:02:46 -05:00
Andrew Steinborn
e34d68e81a
Resolve some warnings.
2018-12-25 01:47:36 -05:00
Andrew Steinborn
1c2235af5a
Explicitly find and complain about BungeeCord and Bukkit plugins.
...
They aren't supported with Velocity and will never be.
2018-12-24 09:44:26 -05:00
Andrew Steinborn
4a872ffabe
Add asynchronous DNS resolution.
2018-12-24 07:37:59 -05:00
Andrew Steinborn
e71bac2028
Fix ProtocolUtil#readString() to respect Unicode.
...
This brings Velocity's to conformance to what Mojang does in
PacketDataSerializer.
2018-12-24 05:25:58 -05:00
Andrew Steinborn
267d306569
Remove all uses of (mark|reset)ReaderIndex()
...
This is removed in Netty 5.x: netty/netty#8636
2018-12-23 23:30:26 -05:00
Andrew Steinborn
11daaa986a
Add readable checks.
2018-12-23 18:50:02 -05:00
Andrew Steinborn
3a87e47796
Remove validation check since these usernames exist anyway.
2018-12-17 15:35:14 -05:00
Andrew Steinborn
5be64565e9
Print exception in task
2018-12-16 13:41:23 -05:00
Andrew Steinborn
ca915a44a9
Bump write mark, to see if it improves #152
2018-12-15 21:13:52 -05:00
Andrew Steinborn
4b5664ec91
Remove redundant check.
2018-12-14 15:09:52 -05:00
Andrew Steinborn
2884c2ea90
Strictly validate usernames for online mode.
2018-12-14 15:04:21 -05:00
Andrew Steinborn
10293aa542
Fix login with IPv6 and other potential security issues
2018-12-14 14:41:46 -05:00
Andrew Steinborn
9a15a80627
Merge pull request #161 from VelocityPowered/anonymize-user-disconnect-messages
...
Anonymize all exception/connection-related errors from the user.
2018-12-14 13:11:51 -05:00
Andrew Steinborn
cc5a7dba9b
Clean up PluginDependencyUtilsTest
2018-12-14 01:47:43 -05:00
Andrew Steinborn
2d54a2c15b
Record circular dependencies
2018-12-13 19:44:25 -05:00
Andrew Steinborn
da12008736
Fix more formatting issues.
2018-12-13 04:53:45 -05:00
Andrew Steinborn
0100cdd244
More comment on the plugin dependency stuff.
2018-12-13 04:50:08 -05:00
Andrew Steinborn
fc76a027de
Rewrite dependency plugin resolving.
...
Velocity now resolves plugin dependencies using a depth-first search
(DFS), instead of using Kahn's algorithm like before. This properly handles duplicate indirect dependencies.
Thanks to @creeper123123321 for noticing this issue!
2018-12-13 04:06:43 -05:00
Andrew Steinborn
f9843057ba
Anonymize all exception/connection-related errors from the user.
...
We still print these out in the logs.
2018-12-11 01:50:29 -05:00
Andrew Steinborn
ce6b061b79
Make Velocity's server list ping behavior more conformant.
...
This fixes pinging with 1.7.x and with certain ping libraries that send
the -1 protocol version.
2018-12-07 17:24:41 -05:00
Luck
6ff9180987
Remove redundant extra lambda in EventManager#fire implementation
2018-12-04 00:03:47 +00:00
Luck
3d3d6adf04
Remove redundant null check in VelocityMethodScanner
2018-12-03 23:55:39 +00:00
Luck
cfae542dd2
Slightly optimize SimpleEventBus usage in VelocityEventManager
2018-12-03 23:53:50 +00:00
Luck
43da3d4541
Allow the same EventHandler to be registered with different PostOrders
...
The #equals implementations in KyoriToVelocityHandler silently prevented this previously.
2018-12-03 23:53:06 +00:00
Andrew Steinborn
5b9a8f160b
Fallback to plugin ID.
2018-12-02 01:59:46 -05:00
Andrew Steinborn
65ca41cdb5
Warn when using Guava Subscribe annotation.
...
Additionally, registration of listeners will not be fatal if an
exception was thrown.
2018-12-02 01:58:21 -05:00
Andrew Steinborn
a3bfa292c6
Merge pull request #139 from VelocityPowered/reload-command
...
Reload command
2018-12-01 18:04:09 -05:00
Andrew Steinborn
bb01dc9edf
Revert "Revert "Refactor Forge support to track the handshake & include keepalives""
...
This reverts commit dc67ee99ed
.
2018-12-01 17:11:41 -05:00
Andrew Steinborn
a9ae53e527
Introduce ConsoleCommandSource. See #155
2018-12-01 17:08:34 -05:00
Andrew Steinborn
dc67ee99ed
Revert "Refactor Forge support to track the handshake & include keepalives"
2018-12-01 14:04:14 -05:00
Andrew Steinborn
ed4994a792
Merge pull request #136 from dualspiral/forge-handshake
...
Refactor Forge support to track the handshake & include keepalives
2018-12-01 14:03:16 -05:00
Andrew Steinborn
6e37fa5f33
When handling TabCompleteResponse, check if we have a command.
...
Fixes #154
2018-11-30 19:14:51 -05:00