Andrew Steinborn
d79c1d0407
Port of #325 for Velocity 1.1.0
...
Co-authored-by: Five (Xer) <admin@xernium.com>
2020-08-05 18:13:16 -04:00
Andrew Steinborn
3beaeb2df7
Merge pull request #341 from alexstaeding/feature/shutdown-api
...
Add shutdown methods to ProxyServer
2020-08-05 11:35:38 -04:00
Ivan Pekov
bb4bff7d34
Respect nodes' requirements ( #350 )
2020-08-05 11:33:03 -04:00
Jacob Allen
76173e4145
Add PRE_SERVER_JOIN to DisconnectEvent#LoginStatus ( #346 )
2020-08-04 16:30:17 -04:00
Andrew Steinborn
87bff1a123
Remove nextProtocolVersion from MinecraftConnection
...
ViaVersion was the only intended user. However, ViaVersion for Velocity 1.1.0 no longer uses this functionality, and so it doesn't make sense to keep it in Velocity 1.1.0.
2020-08-04 12:14:28 -04:00
Andrew Steinborn
e57c6d00c0
Move AutoReadHolderHandler after MinecraftDecoder.
2020-08-04 11:57:23 -04:00
Andrew Steinborn
2a04932112
Fix typo in register() where the primary alias would be unregistered if other aliases were specified.
2020-08-03 08:07:42 -04:00
xDark
a282afb5db
Return earlier, predict list's size for tab clearing
2020-07-31 19:23:19 +03:00
Andrew Steinborn
933c81b9bf
Fix legacy register command not allowing command overrides
2020-07-31 10:58:27 -04:00
Andrew Steinborn
5dcc0460a1
Merge pull request #340 from xxDark/channel-factory
...
Use channel factories to create new channels
2020-07-31 07:49:11 -04:00
xDark
76bef13377
Remove deprecated members
2020-07-31 14:17:31 +03:00
Andrew Steinborn
a6964bd31c
Update for breaking Adventure boss bar changes
2020-07-30 20:16:20 -04:00
Alexander Staeding
190bef375a
Add shutdown methods to ProxyServer
2020-07-30 21:48:58 +02:00
xDark
6379936f32
Fix code style
2020-07-30 17:36:57 +03:00
xDark
d65507d4d5
Use channel factories to create new channels
2020-07-30 17:34:37 +03:00
Andrew Steinborn
e3a95b4783
Actually fix accidental breaking change not allowing aliases to be overridden.
2020-07-30 06:06:37 -04:00
Andrew Steinborn
7f1ee77a69
Fix accidential breaking change not allowing aliases to be overridden.
2020-07-30 06:03:29 -04:00
Andrew Steinborn
306221a92f
Use default shutdown reason if the disconnect message is blank.
2020-07-30 06:01:38 -04:00
xDark
4958bb76e7
Add timeout property in default configuration
2020-07-29 17:30:24 +03:00
xDark
b79f6ad827
Make initial read timeout configurable
2020-07-29 16:59:39 +03:00
Andrew Steinborn
4c5636e6f7
Lie about command invocation succeeding if there is a syntax error.
...
See https://github.com/VelocityPowered/Velocity/issues/337#issuecomment-665568793
This will need an API change to resolve, but it's late right now.
2020-07-29 06:20:16 -04:00
Andrew Steinborn
b6a60b610a
Resolve (most) issues flagged by @hugmanrique in 65e1b7be87
...
This still needs to be configurable, but this is a first step towards shifting towards a more intuitive behavior.
2020-07-29 05:51:40 -04:00
Andrew Steinborn
89f98ce57d
Make Disposable interface implement Closeable
2020-07-29 05:34:15 -04:00
Andrew Steinborn
c2db8d4ac1
Swallow Throwable since plugins are naughty and don't do the right thing -_-
2020-07-29 03:58:04 -04:00
Andrew Steinborn
65e1b7be87
Hints will override the default catch-all by default
2020-07-29 03:55:59 -04:00
Andrew Steinborn
ae0bf6cfca
Fix compile with JDK 8
2020-07-29 03:47:02 -04:00
Hugo Manrique
6cc6e0f641
New command API ( #330 )
2020-07-29 03:43:16 -04:00
Andrew Steinborn
5a515f37a3
Add missing allowed check. Fixes #335
2020-07-28 16:50:34 -04:00
Andrew Steinborn
7ab56d0ca0
Correctly populate the server address in the Forge case. Fixes #334 (correctly).
2020-07-27 17:24:04 -04:00
Andrew Steinborn
c377ed4b57
Preserve plugin load order correctly
2020-07-25 17:21:42 -04:00
Andrew Steinborn
2a29813bde
Well, this is embarassing.
2020-07-24 21:15:07 -04:00
Andrew Steinborn
c3dcf9b1dd
Strictly validate server ping state
2020-07-23 11:44:48 -04:00
Andrew Steinborn
f34b5ac2fc
Yet another breaking change in the Adventure API
2020-07-22 11:18:46 -04:00
Andrew Steinborn
a55e690ad6
These aren't designed to be extended in any way.
2020-07-21 19:41:15 -04:00
Andrew Steinborn
250a35e53b
Fix typo, thanks @hugmanrique for spotting this
2020-07-21 11:52:31 -04:00
Andrew Steinborn
e32acbaae7
Disable Netty resource leak detector by default.
2020-07-21 11:20:15 -04:00
Andrew Steinborn
c3e2321994
Update this with the true default.
2020-07-20 22:08:30 -04:00
Andrew Steinborn
ecec5e487a
Add logging to command executions by players ( #332 )
2020-07-20 22:03:07 -04:00
Andrew Steinborn
cb261c6513
Better handle not failing over on a read timeout
...
The existing Velocity logic was pretty optimistic, hoping the player connection would stay alive long enough to accept a connection to another server. Now, if we notice a read timeout on the server end, we'll treat the disconnect as "unsafe" and disconnect the player immediately.
I've added a configuration option to solve the issue in the way BungeeCord does it. This could cause issues with servers that extensively modify the server pipeline and could degrade the user experience, though. Let's try this more conservative and see if it helps,
2020-07-20 21:55:33 -04:00
Andrew Steinborn
f9f60e1489
Small code cleanups and switch more stuff to adventure
2020-07-19 18:23:47 -04:00
Tim
da92d83b14
Make the logging of commands configurable
2020-07-19 21:49:12 +02:00
Tim
a9df92d308
Add logging to command executions by players
2020-07-19 19:46:10 +02:00
Andrew Steinborn
21ad6a433f
Add MessageRaw support to BungeeCordMessageResponder
2020-07-16 15:18:11 -04:00
Andrew Steinborn
f6bdab8e53
Clean up unused import
2020-07-16 12:44:36 -04:00
Andrew Steinborn
4f19bfde3d
Fix various problems with GS4QueryHandler
2020-07-16 12:44:02 -04:00
Andrew Steinborn
2296a9d8dd
Fix compile error caused by adventure changes
2020-07-16 11:50:48 -04:00
Andrew Steinborn
72ce5c86ba
Improve Velocity networking pipeline when under stress
2020-07-16 11:44:55 -04:00
Andrew Steinborn
f93e227491
Further improvements to pipeline in the worst-case scenario.
2020-07-15 18:26:48 -04:00
Andrew Steinborn
98f1faf759
Work around ByteToMessageDecoder trying to be send more messages upstream when we wanted to discard them altogether
2020-07-15 16:52:48 -04:00
Andrew Steinborn
ce74dcc483
Try not to be crafty here
2020-07-15 16:33:42 -04:00
Andrew Steinborn
ff99b2b248
Convert all Velocity commands to use adventure text components
2020-07-14 21:31:32 -04:00
Mariell Hoversholm
9c8c851d12
Add async command suggestions
2020-07-15 00:28:22 +02:00
Andrew Steinborn
4c3d9de5fe
Add ServerPostConnectEvent as a less confusing (and non-blocking) alternative to ServerConnectedEvent
2020-07-12 16:13:04 -04:00
Andrew Steinborn
f841d7590a
Remove unused parameter
2020-07-12 11:57:07 -04:00
Andrew Steinborn
21bc050f9c
Fix Checkstyle issues again
2020-07-12 11:56:50 -04:00
Andrew Steinborn
6e84261166
Merge branch 'dev/1.1.0' into adventure-api
2020-07-12 01:49:08 -04:00
Andrew Steinborn
86259f788f
Adjust for recent adventure API changes.
2020-07-11 12:00:54 -04:00
Andrew Steinborn
85d88d59d3
Fix pinging being "delayed" on 1.7
2020-07-03 19:16:55 -04:00
Andrew Steinborn
079b352c97
Add a new loginstatus for CANCELLED_BY_USER_BEFORE_COMPLETE
2020-07-03 17:48:20 -04:00
Andrew Steinborn
4c1db86760
Merge branch 'make-disconnectevent-more-sane' into dev/1.1.0
2020-07-03 17:26:24 -04:00
Andrew Steinborn
47560442ca
Remove SyncMap for now, use more obvious and correct MapMaker
2020-06-30 22:46:21 -04:00
Andrew Steinborn
1b8955a76b
Add initial adventure boss bar support
2020-06-30 22:33:07 -04:00
Andrew Steinborn
5285a3c155
Remove AdventureCompact in favor of the text 3.x serializer added in KyoriPowered/adventure-platform#23
2020-06-29 23:34:59 -04:00
Luck
ea52cedfdf
Fire ProxyShutdownEvent before closing the scheduler / event bus
...
Fixes #322
2020-06-29 11:18:52 -04:00
Andrew Steinborn
1938013ab2
Make DisconnectEvent more sane
...
This is a step towards fixing #289 and removing some less-than-optimal behavior in plugins I maintain internally.
2020-06-29 11:17:08 -04:00
Andrew Steinborn
70698246bf
Get everything compiling and Checkstyle clean
2020-06-28 23:20:46 -04:00
Andrew Steinborn
c2edd82b16
Use more idiomatic adventure text serializer
2020-06-28 23:13:57 -04:00
Andrew Steinborn
0c6039a773
Make sure console is included in the ProxyServer audience
2020-06-28 22:57:28 -04:00
Andrew Steinborn
c4f143a2bc
Implement adventure title APIs
2020-06-28 22:52:46 -04:00
Andrew Steinborn
5c02d6b007
RegisteredServer and ProxyServer now implement MultiAudience
2020-06-28 22:01:45 -04:00
Andrew Steinborn
70a989e955
Minor cleanup and add some missing Deprecated tags
2020-06-28 21:29:25 -04:00
Andrew Steinborn
2e7a598916
Initial commit of adventure-adapted Velocity API.
2020-06-28 21:23:01 -04:00
Andrew Steinborn
7fd76962f2
Graceful fallback if these values are absent
2020-06-27 23:03:47 -04:00
Andrew Steinborn
62703780e1
Fix a few areas of concern spotted by JITWatch
2020-06-27 21:33:05 -04:00
Andrew Steinborn
51819b563f
Tolerate broken brand sending by some bots.
2020-06-24 22:32:44 -04:00
Andrew Steinborn
28d2366c73
Switch Velocity from existing toml4j+homebrew TOML serializer to night-config.
...
This allows us to allow many more valid configurations and allows us to eliminate a bunch of ugly hacks.
2020-06-24 21:31:39 -04:00
Andrew Steinborn
4bebda2549
Loosen Checkstyle rules for this.
2020-06-24 11:34:13 -04:00
Andrew Steinborn
7eaa6ef939
Fix saving of escaped strings
2020-06-24 11:21:34 -04:00
Andrew Steinborn
283d8d71b6
Restore compatibility with TCPShield plugin with recent change
2020-06-24 00:07:27 -04:00
Andrew Steinborn
780e1c8be5
Handle duplicates from server pings gracefully
2020-06-23 23:03:19 -04:00
Andrew Steinborn
fd231c71fd
Restore server disconnect messages.
2020-06-23 21:57:16 -04:00
Andrew Steinborn
24cd1f4da0
Allow showing ping requests in the console.
...
The default is false, but this can be enabled in the configuration if desired.
2020-06-23 17:05:01 -04:00
Andrew Steinborn
1fe01596d2
Fix escaping issues with spaces in server names
...
Fixes #320
2020-06-23 16:07:25 -04:00
Andrew Steinborn
f7f4620b53
Temporarily revert DisconnectEvent changes due to some issues
2020-06-23 14:48:01 -04:00
Andrew Steinborn
ae6afc8b18
Fix Minecraft 1.7 support (bad merge)
2020-06-23 13:17:36 -04:00
Andrew Steinborn
0684e08f67
Really suppress the initial connection stuff
2020-06-23 08:32:47 -04:00
Andrew Steinborn
e9cc390abd
Revert "Clean up ClientPlaySessionHandler#handle(PluginMessage)"
...
This reverts commit ac4359ad21
.
Suspected to be causing problems with Fabric and Forge
2020-06-23 08:22:09 -04:00
Andrew Steinborn
df82c0b566
Suppress some really annoying spam
2020-06-23 07:56:19 -04:00
Andrew Steinborn
91743aaa9d
Merge branch 'dev/1.1.0' into future/1.16-velocity-1.1.0
...
# Conflicts:
# proxy/build.gradle
2020-06-21 13:40:19 -04:00
Andrew Steinborn
ab9115178b
Merge branch 'decode-multiple' into dev/1.1.0
2020-06-21 13:39:24 -04:00
Andrew Steinborn
d1a5d8dd82
Fix compile on JDK 8 and bad merge
2020-06-21 13:38:05 -04:00
Andrew Steinborn
09f71dede9
Rebase #310 on Velocity 1.1.0
...
Totally untested, proceed with caution.
2020-06-20 23:26:24 -04:00
Andrew Steinborn
ada35ff286
Merge branch 'Xernium-future/1.16' into future/1.16-velocity-1.1.0
...
# Conflicts:
# .travis.yml
# api/src/main/java/com/velocitypowered/api/network/ProtocolVersion.java
# build.gradle
# proxy/build.gradle
# proxy/src/main/java/com/velocitypowered/proxy/VelocityServer.java
# proxy/src/main/java/com/velocitypowered/proxy/connection/backend/VelocityServerConnection.java
# proxy/src/main/java/com/velocitypowered/proxy/connection/client/ClientPlaySessionHandler.java
# proxy/src/main/java/com/velocitypowered/proxy/connection/client/ConnectedPlayer.java
# proxy/src/main/java/com/velocitypowered/proxy/network/netty/DiscardHandler.java
# proxy/src/main/java/com/velocitypowered/proxy/protocol/ProtocolUtils.java
# proxy/src/main/java/com/velocitypowered/proxy/protocol/StateRegistry.java
# proxy/src/main/java/com/velocitypowered/proxy/protocol/netty/MinecraftCompressDecoder.java
# proxy/src/main/java/com/velocitypowered/proxy/protocol/netty/MinecraftDecoder.java
# proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/JoinGame.java
# proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/Respawn.java
# proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/ServerLoginSuccess.java
# proxy/src/test/java/com/velocitypowered/proxy/plugin/util/PluginDependencyUtilsTest.java
2020-06-20 23:24:32 -04:00
Andrew Steinborn
cd9bb61f20
Merge branch 'future/1.16' of https://github.com/Xernium/Velocity into Xernium-future/1.16
2020-06-20 23:11:19 -04:00
Andrew Steinborn
d6b1bc26d8
Read target of Forward message properly. Fixes #318
2020-06-19 05:36:52 -04:00
Andrew Steinborn
d1cbc7028a
Merge branch 'dev/1.1.0' into decode-multiple
2020-06-19 05:23:20 -04:00
Andrew Steinborn
f8e20ab3a7
Fix tab complete using proper vanilla limit.
2020-06-19 05:22:35 -04:00
Andrew Steinborn
b79d2d4a94
Fix tab complete using proper vanilla limit.
2020-06-19 05:22:19 -04:00
Five (Xer)
a1ab29186b
Changes 1.16-pre6
2020-06-16 17:56:56 +02:00
Andrew Steinborn
0109f4477a
Complete the teardown future anyway
2020-06-12 07:27:51 -04:00
Andrew Steinborn
8a6e77689b
Checkstyle strikes again
2020-06-12 07:26:25 -04:00
Andrew Steinborn
8b8fd284b3
Call DisconnectEvent explicitly instead of relying on ConnectedPlayer#teardown() to do it for us
...
Should fix (but not verified) #289
2020-06-12 07:24:17 -04:00
Andrew Steinborn
ac4359ad21
Clean up ClientPlaySessionHandler#handle(PluginMessage)
2020-06-12 07:16:43 -04:00
Andrew Steinborn
f4bc2ac131
Regenerate with random secret if not present in velocity.toml.
2020-06-12 03:10:25 -04:00
Five (Xer)
78b442a852
Changes 1.16-pre4 and Logic fixes
2020-06-11 23:39:16 +02:00
Andrew Steinborn
9bece076f5
Remove old Checker Framework relics.
...
Proper Checker Framework support needs to wait for a major Velocity version and almost necessities a total refactor, if not rewrite, of Velocity.
2020-06-11 02:08:04 -04:00
Andrew Steinborn
cf5f7fa38f
Fix a typo.
2020-06-11 01:56:41 -04:00
Andrew Steinborn
6e7c0298de
Remove Netty async DNS resolver completely
...
It "mostly works" - but it's not good enough. Instead, we'll offload
the DNS resolution outside the event loop. This is a middle-ground approach between doing the resolution on the calling method (and potentially a Netty I/O thread) and using the intermittently broken Netty async DNS resolver.
2020-06-11 01:54:12 -04:00
Five (Xer)
101a6a58dd
Changes 1.16-pre3
2020-06-10 21:00:18 +02:00
Five (Xer)
4e5f708bed
Resolve review
2020-06-07 00:51:21 +02:00
Five (Xer)
3ed5e7718c
Fix logic error
2020-06-07 00:33:06 +02:00
Five (Xer)
ef5b9cf183
Sync to IDE
2020-06-07 00:22:11 +02:00
Five (Xer)
f868cea583
Move to proper API
2020-06-07 00:14:23 +02:00
Lechner Markus
0377a6829f
Move to Registry
2020-06-05 16:00:51 +02:00
Lechner Markus
6368b47e78
Old sins
2020-06-05 15:58:34 +02:00
Lechner Markus
aa4a8de2fd
Stylize
2020-06-05 15:45:11 +02:00
Lechner Markus
368d50b455
Rework Dimension Registry
2020-06-05 15:22:55 +02:00
Five (Xer)
009f207883
More progress
2020-06-04 21:21:54 +02:00
Andrew Steinborn
bb69481f99
Lay down foundation for cross-architecture natives
...
We have dropped the rarely used kqueue and replaced it with the new Netty aarch64
native. In addition, lay down the foundation for other aarch64 natives.
2020-06-04 14:59:22 -04:00
Five (Xer)
6734ef3a08
Checkstyle-auto
2020-06-04 19:13:10 +02:00
Lechner Markus
18e5953976
Save progress
2020-06-04 15:36:58 +02:00
Andrew Steinborn
456b4b217f
Run closeWith() logic in the event loop
2020-06-04 01:35:32 -04:00
Andrew Steinborn
ee4bae60a9
Merge branch 'dev/1.1.0' into decode-multiple
2020-06-03 12:18:43 -04:00
Andrew Steinborn
669bd14779
Remove duplicate in-flight connection reset
2020-06-03 12:18:29 -04:00
Andrew Steinborn
042a9df4f1
Merge branch 'dev/1.1.0' into decode-multiple
2020-06-03 12:13:34 -04:00
Luck
4263c4e2d4
Fix config formatting
2020-06-03 00:58:26 +01:00
Luck
c563372ffd
Remove unnecessary imports
2020-06-03 00:35:04 +01:00
Luck
2cd9f081c3
Merge branch 'dev/1.1.0' into feature/bungeeguard
2020-06-03 00:32:27 +01:00
Luck
70abda9c5b
Implement legacy forwarding BungeeGuard handshake support
2020-06-02 23:48:42 +01:00
Andrew Steinborn
46e92a069b
Fix an issue with too short not breaking the loop
2020-05-31 14:01:27 -04:00
Andrew Steinborn
f27aa8e3ba
Handle empty packets too
2020-05-31 09:54:47 -04:00
Andrew Steinborn
c856635ac5
Try two, with improved state maintenance and some bugs fixed
2020-05-31 08:14:33 -04:00
Andrew Steinborn
3a8ba76f25
This did not work :(
2020-05-31 07:55:19 -04:00
Andrew Steinborn
869f2a6b32
Merge branch 'dev/1.1.0' into decode-multiple
2020-05-29 21:37:10 -04:00
Andrew Steinborn
e83662e8c3
Clean up imports and remove some legacy declarations.
2020-05-29 21:36:58 -04:00
Andrew Steinborn
11fb5f2be3
Simplify the discard logic.
2020-05-29 21:35:07 -04:00
Andrew Steinborn
dd2e1ad241
Handle partially sent varints better
2020-05-29 21:11:21 -04:00
Andrew Steinborn
b6f1dcc166
Optimize varint frame decoding again
...
Use ByteProcessor in a controlled matter in one specific case. Performance measurements with my Ryzen 5 3600 indicate a 25-35% improvement in time spent framing incoming packets.
2020-05-29 20:52:04 -04:00
Andrew Steinborn
9f6d8e1840
Merge branch 'dev/1.1.0' into decode-multiple
2020-05-29 19:03:03 -04:00
Andrew Steinborn
cb99b184ed
Allow plugins to mutate available commands sent to the client.
...
This is the first unstable API being introduced and is primarily to get feedback on the system.
2020-05-28 07:14:49 -04:00
Andrew Steinborn
d66766a38b
Merge branch 'dev/1.1.0' into decode-multiple
2020-05-26 05:25:11 -04:00
Andrew Steinborn
eeb660ce00
Fix bad ordering
2020-05-26 05:25:03 -04:00
Andrew Steinborn
0d1acdb056
Merge branch 'dev/1.1.0' into decode-multiple
2020-05-25 16:09:19 -04:00
Andrew Steinborn
ebad3d1005
Use Integer.MIN_VALUE for the sentinel for readVarIntSafely()
2020-05-25 16:05:36 -04:00
Andrew Steinborn
d7bbe7531a
Additional protocol hardening.
2020-05-25 15:58:52 -04:00
Andrew Steinborn
62d3f61a77
Merge branch 'dev/1.1.0' into decode-multiple
...
# Conflicts:
# proxy/src/main/java/com/velocitypowered/proxy/connection/client/ConnectedPlayer.java
2020-05-25 13:27:44 -04:00
Andrew Steinborn
abd81a0216
Fix Checkstyle errors.
2020-05-25 13:24:41 -04:00
Andrew Steinborn
0cb4c02107
Run all commands on a separate thread pool.
2020-05-25 13:09:04 -04:00
Andrew Steinborn
ec1fc3944d
Make sure this runs on the event loop.
2020-05-25 12:08:24 -04:00
Andrew Steinborn
942e2f2e1a
Better generic cleanup.
2020-05-25 11:56:56 -04:00