3
0
Mirror von https://github.com/PaperMC/Velocity.git synchronisiert 2024-11-17 05:20:14 +01:00
Commit graph

1279 Commits

Autor SHA1 Nachricht Datum
Remynfv
495b796816
Fix grammar in obscure error message (#880)
The title really says it all. Change ``The forwarding-secret-file does not exists.`` to ``The forwarding-secret-file does not exist.``
2022-12-11 22:40:58 -05:00
JOO200
97770cd1a6
Reduce Spam from the TabList by not sending every package multiple times (#902)
* Reduce Spam from the TabList by not sending every package multiple times

VelocityTabList#processUpsert called entry.setX which will create a package and send it to the client.
BackendPlaySessionHandler doesn't return true for those packages, therefore the package for tab list updates will be send two times.

* Cleanup TabList#buildEntry, added listed status to Entry builder
2022-12-09 13:40:30 -05:00
James58899
fa17a5d4cc
Fix command packet (#900)
fix https://github.com/PaperMC/Velocity/issues/898
2022-12-08 18:13:57 +00:00
Petr Ilin
d3e5dc1354
Fix TitleTimes packet ID for Minecraft 1.19.3 (#899) 2022-12-08 17:03:16 +00:00
Corey Shupe
361f6335ac
Merge pull request #897 from RoccoDev/fix/1.19.3-unsigned-encode
chat: fix encoding for changed unsigned messages
2022-12-07 13:57:40 -05:00
RoccoDev
3ae3af45bc
chat: fix unsigned encoding for changed messages 2022-12-07 19:51:12 +01:00
Corey Shupe
2a0d657a0c Fix profile presence 2022-12-07 13:26:01 -05:00
Corey Shupe
cc7d199f47
Merge pull request #895 from RoccoDev/fix/1.19.3-legacy-cancel
regression: fix legacy chat cancelling on < 1.19
2022-12-07 13:19:07 -05:00
RoccoDev
039799b2d3
legacy-chat: fix cancel on < 1.19 2022-12-07 19:14:32 +01:00
Corey Shupe
0250d1ef8a Fix null timestamps being passed to timekeeper improperly. 2022-12-07 12:56:27 -05:00
Corey Shupe
b504e0857c
Update to 1.19.3-rc3 (#893) 2022-12-07 14:12:48 +01:00
Shane Freeder
f6b032cb04
Fix misrenamed illegal chat chars translation key 2022-09-15 21:48:28 +01:00
OOP-778
cae41c33a1
Fix connection error spamming (#847)
* Fix "pointers" for players never being used lol

* Added Platform Facet API to add Type pointers

* Remove duplicate

* Fix some connection things

* Make checkstyle happy?
2022-08-19 22:46:57 -04:00
Outfluencer
47cd9faf65
A char can be 3 bytes (#843)
BungeeCord reference: b5365dcba7
2022-08-19 22:45:58 -04:00
kyngs
3293f7a9eb
Fix #828 (#829)
Co-authored-by: kyngs <kyngs@users.noreply.github.com>
2022-08-09 15:03:03 -04:00
Andrew Steinborn
6496983ca3 Fix cancelling commands on <1.19 clients (#827) 2022-08-08 00:42:31 -04:00
JNNGL
62bd58d356
Fix decoding of unsigned messages on 1.19.1 (#814) 2022-08-03 11:20:25 -04:00
Rocco
8344082b1a
Fix chat decoding for legacy versions (#815) 2022-08-03 09:19:30 -04:00
James58899
88a5abd26c
Fix command packet wrong mark as unsigned (#810)
Dropping previousMessages will break the chat chain
2022-08-03 10:42:43 +00:00
Corey Shupe
e5b84ecf1d
Update/chat order queue (#801)
* Implement chat queue for ordered chat.

* Update system to handle spoofed chat as well.

* Fix checkstyle erroring on bad indentation.

* Fix ChatQueue to use whenComplete instead of thenRun

* Merge upstream.

* Checkstyle

* Deny denied commands.
2022-08-02 20:50:01 -04:00
FivePB (Xer)
1a3fba4250
Update to 1.19.1 (#772)
* 1.19.1-rc1

* More signature changes

* Further 1.19.1 changes

I also started on the checkstyle update, see the developers notes
for the rest I haven't gotten around to fixing yet.

* Fix checkstyle

* Checkstyle imports

* Fix logic error

* Changes 1.19.1-pre2

* 1.19-pre3

* Progress, some parts still WIP

* Overlooked changes

* Fix ServerData

* Fix ServerLogin send check

* Workaround the broken behavior of "No Chat Reports"

Note that if we ever choose to enforce chat signatures, then the mod will just break again... not our fault if we do that, you get what you pay for.

* more

Co-authored-by: Shane Freeder <theboyetronic@gmail.com>
Co-authored-by: Andrew Steinborn <git@steinborn.me>
2022-07-30 19:30:03 -04:00
56738
6be344d919
Decode ServerData packet (#799) 2022-07-19 15:34:27 +02:00
Gero
e8bf6ab522
Fix missing assignment of playerKey in ServerLogin constructor (#776) 2022-06-26 13:24:20 +01:00
Shane Freeder
c03d7e259c
Validate that we have a target 2022-06-25 21:38:55 +01:00
Andrew Steinborn
662fbc4e3c
Implement the ServerData packet by firing ProxyPingEvent (#771)
* Implement the ServerData packet by firing ProxyPingEvent

Mojang introduced the enable-status server property with Minecraft 1.19, which if enabled causes servers to close the connection when a client tries to ping them. Mojang wants to show the MOTD and favicon on the server select screen for those who manage to log in, so we need to implement this packet as well.

The good news is that we can send this packet as many times as needed on the same connection

This matches the behavior of pinging the server. This is a minor, but completely backwards-compatible, API breakage: Player inherits from InboundConnection so we do not have to change ProxyPingEvent, however plugins not expecting a Player might get confused.

* typo
2022-06-23 23:59:13 -04:00
foxley
86c65f3910
adding equals and hashcode in ClientSettings, ClientSettingsWrapper and SkinParts (#765)
* adding equals and hashcode in ClientSettings, ClientSettingsWrapper and SkinParts

* fixing format
2022-06-22 23:37:38 -04:00
Shane Freeder
0caff79bf8
hard over system message chat type for 1.19+ 2022-06-22 05:30:27 +01:00
FivePB (Xer)
1a1391a519
Tablist-changes for 1.19 (#761)
This change helps ensure player signatures are propagated correctly.
Signatures should never be removed, so to compensate for legacy plugins and for the
proxy api function we have to enforce this.
2022-06-19 18:19:32 +02:00
Adrian
508c1edb3a
Fixed possible IOException if forwarding-secret-file path is a directory (#743)
* Fixed possible IOException if path is a directory

* Removed File usage

* Catch possible NumberFormatException on invalid config version

!Files.exists -> Files.notExists
2022-06-18 20:06:51 -04:00
4drian3d
74edac9642
Fixed BungeeGuard support (#739) 2022-06-09 18:08:55 +01:00
FivePB (Xer)
64bfa285fe
Finish Modern forwarding v2 2022-06-09 16:27:25 +02:00
Shane Freeder
3501969960
move force key checking into a system property (#736) 2022-06-09 12:07:24 +01:00
logsym
da52d09338
Add config support for using file as forwarding secret (#712)
* add config support for using file as forwarding secret

* deprecate forwarding-secret and change default to forwarding-secret-file

* change forwarding-secret-file handling to a versioned system
2022-06-09 03:28:14 -04:00
4drian3d
e45ca5f357
Improved Scheduler API (#696)
* Improved Scheduler API

- Added `Scheduler#builder(plugin)`
This method allows a more simplified builder while maintaining the main requirement of the executor plugin
- Added `Scheduler#taskByPlugin(plugin)`
Allows to obtain the tasks that a plugin has sent to execute and that are currently active
- Added `TaskBuilder#task(Consumer<SchuledTask>)`
Allows to specify a task with access to the task itself with the ability to cancel itself

* Applied requested changes

- Removed tasks builder method
- Added `Scheduler#buildTask(plugin, Consumer<ScheduledTask>)`

* Removed some unused imports

* Applied suggested change

* Fix possible test bug

* Applied more suggested changes

* Fixed tests inside tasks
2022-06-09 03:27:06 -04:00
Corey Shupe
04d3ed6820
Fix unsigned chat breaking decode on PlayerChat. (#730) 2022-06-08 00:12:56 -04:00
Andrew Steinborn
c2b237f196 DRY - one function to create respawn packets from JoinGame packets 2022-06-07 23:35:43 -04:00
Corey Shupe
c45597c885
Hotfix registry and argument ser/de (#729)
* Hotfix argument parser missing

* Fix join game registry announcing.
2022-06-07 23:23:50 -04:00
Corey Shupe
28b6f6dcef
Hotfix/patch modern forwarding v2 (#727) 2022-06-07 21:11:53 -04:00
Corey Shupe
d97ed956a7
Update/1.19 (#726)
Co-authored-by: FivePB <admin@fivepb.me>
2022-06-07 21:00:24 -04:00
Pasqual Koschmieder
3ae93875b8
fix missing server info in some events when kicked from current server (#703) 2022-05-08 23:08:50 -04:00
Andrew Steinborn
aa38d3e561 Implement a proper login state machine for logins
Fixes #688 and probably a host of other potential problems.
2022-04-23 18:07:34 -04:00
Robin
5ee96606f6
Override correct sendMessage method (#698) 2022-04-19 22:36:25 -04:00
4drian3d
acc407a6d5
Added ability to customize translations (#692)
* Added ability to customize translations

* Removed remaining usage of `Paths#get`

As of java 11 its replacement `Path#of` was created, which is called when using `Paths#get`, besides, according to documentation, it mentions that it can be deprecated at any time

And fix a minor typo in LegacyChannelIdentifier
2022-04-16 00:38:44 -04:00
4drian3d
3cb10f6ad4
Implement missing Pointers (#694)
- Implement Player's LOCALE and DISPLAY_NAME pointers
- Implement VelocityConsole's LOCALE pointer
2022-04-16 00:37:35 -04:00
Andrew Steinborn
d59d4505cb Add stop command alias for ShutdownCommand
Fixes #678
2022-04-08 23:00:03 -04:00
4drian3d
2a39b24770
Shutdown command improvements (#680)
- Migrate to Brigadier usage
- Added MiniMessage support for custom shutdown reason
2022-04-08 22:56:41 -04:00
4drian3d
b8223686ea
Added logPlayerConnections configuration option (#673) 2022-04-03 15:30:47 -04:00
Andrew Steinborn
95a32ad421 fix 2022-03-31 22:13:05 -04:00
4drian3d
9fc4341f40
Replacement of some deprecated method (#672)
- PlainComponentSerializer -> PlainTextComponentSerializer
- BinaryTagHolder#of -> BinaryTagHolder#binaryTagHolder
2022-03-31 22:09:44 -04:00
OOP-778
9f77431f36
Fix "pointers" for players never being used lol & Type pointers (#674)
* Fix "pointers" for players never being used lol

* Added Platform Facet API to add Type pointers

* Remove duplicate
2022-03-31 22:09:10 -04:00
virustotalop
e2743ffa4e
Add proxy shutdown localization (#663) 2022-03-19 18:54:24 -04:00
kyngs
f0ea638fa1
Disable Log4J's built-in shutdown hook, because it broke logging in the shutdown sequence when exiting by interrupting the process. This was caused by the Log4J's hook running before ours. (#637) 2022-03-13 23:59:50 -04:00
ebony-lamp
94e8b0df43
Add option to disable ip logging (#614) (#650) 2022-03-09 02:24:45 -05:00
Andrew Steinborn
b5dcaa2315 Provide a more descriptive error message if Velocity isn't able to authenticate with Mojang servers
Fixes #636
2022-03-09 02:23:22 -05:00
Corey Shupe
9c44aff8c3
Flip output for queued resource pack status passthrough conditional (#659)
* Flip output for queued resource pack status passthrough conditional

* Hotfix to queue the intended resource pack info.
2022-03-03 01:52:21 -05:00
Shane Freeder
2fe50bedc5
1.18.2 support 2022-02-28 14:27:57 +00:00
kyngs
7bd0f9ea14
Add support for custom class loaders. (#647) 2022-02-19 16:04:56 -05:00
Rocco
8ab071badb
Fire events for queued login plugin messages (#632) 2022-02-19 16:03:09 -05:00
Andrew Steinborn
b2800087d8 Ensure Forward doesn't broadcast to the current server
Fixes #641
2022-02-07 23:43:40 -05:00
Corey Shupe
596d4758ba
Implement resource pack send event. (#625) 2022-02-01 23:30:45 -05:00
Vincent
3315397934
add legacy connection toString (#604) 2021-12-14 19:43:18 -05:00
Shane Freeder
5fe3663d51
Update Log4J 2021-12-10 01:57:42 +00:00
Shane Freeder
2cff5b3b02
Backport log4j 2.15.0 bugfix 2021-12-09 18:46:55 +00:00
FivePB (Xer)
30dd2ed380
Merge 1.18 Update
Merge pull request #577 from Xernium/future/1.18: [Future] Support for Minecraft 1.18
2021-11-25 19:24:39 +01:00
FivePB
7ed4f4c03a
Add new ClientSettings API
Add the new API introducted with the ClientSettings packet changes in 1.18
2021-11-25 17:04:10 +01:00
Riley Park
2586210ca6 Move to PaperMC organisation 2021-11-18 10:49:54 -08:00
Five (Xer)
315ff265c6
Snapshot 21w44a 2021-11-12 10:53:26 +01:00
Andrew Steinborn
d3b3ef231b Update forwarding documentation link(!) 2021-11-07 13:00:58 -05:00
Ivan Pekov
111d14c3fb
Introduce VelocityBrigadierMessage (#588) 2021-11-02 16:20:15 -04:00
Andrew Steinborn
6b2b28796b Clean up and clarify plugin loader logic. 2021-10-31 23:24:39 -04:00
Andrew Steinborn
0b0c36dcfc Correct command meta alias removal behavior and add appropriate unit tests.
Apparently @hugmanrique caught the issue but suggested the wrong fix. This is the correct fix, and respects the Javadoc.
2021-10-31 19:05:21 -04:00
Andrew Steinborn
895eb1a424 Clean up and comment PluginDependencyUtils#sortCandidates 2021-10-31 18:56:13 -04:00
Andrew Steinborn
cb8781b3c9
Add support for sending and receiving login plugin messages from players and servers (#587) 2021-10-31 16:27:03 -04:00
Frank van der Heijden
922c001b59
Expose CommandMeta in CommandManager and add a ref to the plugin instance (#544) 2021-10-31 16:23:35 -04:00
James Puleo
996ada1f39
Introduce PlayerClientBrandEvent, fired when the player sends the minecraft:brand message (#567) 2021-10-15 10:26:25 -04:00
Andrew Steinborn
41f66c7c04 Also guard sendTitlePart behind a protocol version check. 2021-10-15 10:16:34 -04:00
Andrew Steinborn
d5047b6665 Fix copy-paste error 2021-10-15 08:30:11 -04:00
Andrew Steinborn
3f647e4eb2 Implement sendTitlePart for Players 2021-10-15 08:28:05 -04:00
Andrew Steinborn
0b088590a0 Fix license text 2021-10-10 16:39:59 -04:00
Andrew Steinborn
1aaecfff08 Add tests for EventTask#resumeWhenComplete and clarify Javadoc. 2021-10-10 16:37:22 -04:00
Foorcee
08f1b87267
Redirect player without message (#581) 2021-10-09 20:32:04 -04:00
Five (Xer)
4ba4054f23
Snapshot 21w40a 2021-10-09 00:08:51 +02:00
Hugo Manrique
567582b2e2
Fix thread-unsafe command unregistration (#583)
Access to the dispatcher is guarded by `lock`.
2021-10-04 15:17:36 -04:00
Foorcee
aa210b3544
Don't allow illegal characters (#580) 2021-10-03 16:09:29 -04:00
Cubxity
d619bb56fd
feat: added VELOCITY_FORWARDING_SECRET environment variable (#582) 2021-10-03 16:07:45 -04:00
Andrew Steinborn
340e1b23d6 Fix none vhost forwarding with legacy Forge. 2021-09-27 00:37:58 -04:00
Andrew Steinborn
effca0da82 Preserve virtual host the player connected to for modern/none forwarding
This makes these modes in-line with legacy forwarding
2021-09-25 17:51:58 -04:00
sagan
ea07c6661a
Don't crash when attempt servers order is empty, return empty optional instead (#576) 2021-09-15 07:42:14 -04:00
Andrew Steinborn
d1135bd190 Allow the BungeeCord plugin messaging channel to be used by the server at transition time 2021-09-07 07:38:30 -04:00
Joshua Dean Küpper
9e38aec129
fix the order of title packages (#572) 2021-09-01 07:42:44 -04:00
Andrew Steinborn
849e416c8d Fix IPv6 scope issue in legacy forwarding too 2021-09-01 07:14:38 -04:00
mdxd44
bfe2358386
Fix legacy handshake with hostnames that include IP addresses (#571) 2021-09-01 05:03:49 -04:00
Andrew Steinborn
9a15c7e170 Fix Brigadier command node redirect serialization (#565) 2021-08-24 13:58:13 -04:00
Andrew Steinborn
5303239f66 fix bug 2021-08-21 02:23:29 -04:00
Andrew Steinborn
e6a93ad0c6 Clean up JoinGame packet encoding/decoding
Specifically, the JoinGame packet handling is now split between pre-1.16 encodings of the packet and post-1.16 handlings of the packet. This packet is one of the most amorphous packets in the entire Minecraft protocol, from Velocity's perspective.
2021-08-21 02:17:34 -04:00
Andrew Steinborn
65db0fad6a Fix bug 2021-08-17 13:39:35 -04:00
Andrew Steinborn
6d4cb3b18f Fix TabList population
Bug reported by JakubBien on Discord
2021-08-17 13:30:15 -04:00
Corey Shupe
ec4d2d45a1
Make Mojang Sessionserver Configurable (#560) 2021-08-17 13:14:39 -04:00
Andrew Steinborn
d3ff6f8e33 Make sure to issue a backpressure-solving flush on a future iteration of the event loop
Thanks to @Spottedleaf for finding this issue.
2021-08-04 23:37:27 -04:00
Andrew Steinborn
c32bc88064 Fix not forwarding channelReadComplete events in some cases 2021-08-04 23:01:28 -04:00