From 92571a65db5ccce552182b49753b9e5087091063 Mon Sep 17 00:00:00 2001 From: Andrew Steinborn Date: Tue, 14 Jan 2020 22:18:05 -0500 Subject: [PATCH] Another experiment for memory leaks: Create a brand-new buffer for passthrough uncompressed content --- .../proxy/protocol/netty/MinecraftCompressDecoder.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/proxy/src/main/java/com/velocitypowered/proxy/protocol/netty/MinecraftCompressDecoder.java b/proxy/src/main/java/com/velocitypowered/proxy/protocol/netty/MinecraftCompressDecoder.java index cf68e134b..f76e82f95 100644 --- a/proxy/src/main/java/com/velocitypowered/proxy/protocol/netty/MinecraftCompressDecoder.java +++ b/proxy/src/main/java/com/velocitypowered/proxy/protocol/netty/MinecraftCompressDecoder.java @@ -29,7 +29,8 @@ public class MinecraftCompressDecoder extends MessageToMessageDecoder { int claimedUncompressedSize = ProtocolUtils.readVarInt(in); if (claimedUncompressedSize == 0) { // Strip the now-useless uncompressed size, this message is already uncompressed. - out.add(in.retainedSlice()); + out.add(in.copy()); + in.skipBytes(in.readableBytes()); return; }