Print a warning message instead of crashing.
We shouldn't prevent a plugin from adding packet listeners just because the plugin verifier failed.
Dieser Commit ist enthalten in:
Ursprung
8d0e8139de
Commit
ef4476a72e
@ -85,6 +85,7 @@ public final class PacketFilterManager implements ProtocolManager, ListenerInvok
|
|||||||
public static final ReportType REPORT_CANNOT_INJECT_PLAYER = new ReportType("Unable to inject player.");
|
public static final ReportType REPORT_CANNOT_INJECT_PLAYER = new ReportType("Unable to inject player.");
|
||||||
|
|
||||||
public static final ReportType REPORT_CANNOT_UNREGISTER_PLUGIN = new ReportType("Unable to handle disabled plugin.");
|
public static final ReportType REPORT_CANNOT_UNREGISTER_PLUGIN = new ReportType("Unable to handle disabled plugin.");
|
||||||
|
public static final ReportType REPORT_PLUGIN_VERIFIER_ERROR = new ReportType("Verifier error: %s");
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Sets the inject hook type. Different types allow for maximum compatibility.
|
* Sets the inject hook type. Different types allow for maximum compatibility.
|
||||||
@ -298,12 +299,16 @@ public final class PacketFilterManager implements ProtocolManager, ListenerInvok
|
|||||||
* @param plugin - plugin to check.
|
* @param plugin - plugin to check.
|
||||||
*/
|
*/
|
||||||
private void printPluginWarnings(Plugin plugin) {
|
private void printPluginWarnings(Plugin plugin) {
|
||||||
switch (pluginVerifier.verify(plugin)) {
|
try {
|
||||||
case NO_DEPEND:
|
switch (pluginVerifier.verify(plugin)) {
|
||||||
reporter.reportWarning(this, Report.newBuilder(REPORT_PLUGIN_DEPEND_MISSING).messageParam(plugin.getName()));
|
case NO_DEPEND:
|
||||||
case VALID:
|
reporter.reportWarning(this, Report.newBuilder(REPORT_PLUGIN_DEPEND_MISSING).messageParam(plugin.getName()));
|
||||||
// Do nothing
|
case VALID:
|
||||||
break;
|
// Do nothing
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
} catch (IllegalStateException e) {
|
||||||
|
reporter.reportWarning(this, Report.newBuilder(REPORT_PLUGIN_VERIFIER_ERROR).messageParam(e.getMessage()));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
In neuem Issue referenzieren
Einen Benutzer sperren