Archiviert
13
0

Precreate the inputBuffers set, avoiding a trivial NPE.

Dieser Commit ist enthalten in:
Kristian S. Stangeland 2013-12-05 20:51:28 +01:00
Ursprung 348019c1e1
Commit be6d4fb720
3 geänderte Dateien mit 19 neuen und 2 gelöschten Zeilen

Datei anzeigen

@ -332,16 +332,33 @@ public abstract class PacketAdapter implements PacketListener {
* Construct a helper object for passing parameters to the packet adapter.
* <p>
* This is often simpler and better than passing them directly to each constructor.
* <p>
* Deprecated: Use {@link #params(Plugin, PacketType...)} instead.
* @param plugin - the plugin that spawned this listener.
* @param packets - the packet IDs the listener is looking for.
* @return Helper object.
*/
@Deprecated
public static AdapterParameteters params(Plugin plugin, Integer... packets) {
return new AdapterParameteters().plugin(plugin).packets(packets);
}
/**
* Construct a helper object for passing parameters to the packet adapter.
* <p>
* This is often simpler and better than passing them directly to each constructor.
* @param plugin - the plugin that spawned this listener.
* @param packets - the packet types the listener is looking for.
* @return Helper object.
*/
public static AdapterParameteters params(Plugin plugin, PacketType... packets) {
return new AdapterParameteters().plugin(plugin).types(packets);
}
/**
* Represents a builder for passing parameters to the packet adapter constructor.
* <p>
* Note: Never make spelling mistakes in a public API!
* @author Kristian
*/
public static class AdapterParameteters {

Datei anzeigen

@ -51,7 +51,7 @@ public class NettyProtocolInjector implements ChannelListener {
private PacketTypeSet reveivedFilters = new PacketTypeSet();
// Which packets are buffered
private PacketTypeSet bufferedPackets;
private PacketTypeSet bufferedPackets = new PacketTypeSet();
private ListenerInvoker invoker;
// Handle errors

Datei anzeigen

@ -72,7 +72,7 @@ public class TestPingPacket {
@Override
public String call() throws Exception {
SimpleMinecraftClient client = new SimpleMinecraftClient(
new MinecraftVersion(CRAFTBUKKIT_VERSION), PROTOCOL_VERSION);
new MinecraftVersion(CRAFTBUKKIT_VERSION), PROTOCOL_VERSION);
String information = client.queryLocalPing();
// Wait for the listener to catch up