From 4e9b5009c8e1a07dc57cd02051f325788ac8e3d1 Mon Sep 17 00:00:00 2001 From: "Kristian S. Stangeland" Date: Tue, 23 Oct 2012 00:54:41 +0200 Subject: [PATCH] Don't print messages to the console without a plugin prefix. It's bad practice. --- .../src/main/java/com/comphenix/protocol/ProtocolLibrary.java | 4 ++-- .../java/com/comphenix/protocol/async/PacketSendingQueue.java | 2 +- .../protocol/injector/player/PlayerInjectionHandler.java | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ProtocolLib/src/main/java/com/comphenix/protocol/ProtocolLibrary.java b/ProtocolLib/src/main/java/com/comphenix/protocol/ProtocolLibrary.java index d36cebe1..9878ab66 100644 --- a/ProtocolLib/src/main/java/com/comphenix/protocol/ProtocolLibrary.java +++ b/ProtocolLib/src/main/java/com/comphenix/protocol/ProtocolLibrary.java @@ -117,7 +117,7 @@ public class ProtocolLibrary extends JavaPlugin { public void onPacketReceiving(PacketEvent event) { Object handle = event.getPacket().getHandle(); - System.out.println(String.format( + logger.info(String.format( "RECEIVING %s@%s from %s.", handle.getClass().getSimpleName(), handle.hashCode(), event.getPlayer().getName() )); @@ -126,7 +126,7 @@ public class ProtocolLibrary extends JavaPlugin { public void onPacketSending(PacketEvent event) { Object handle = event.getPacket().getHandle(); - System.out.println(String.format( + logger.info(String.format( "SENDING %s@%s from %s.", handle.getClass().getSimpleName(), handle.hashCode(), event.getPlayer().getName() )); diff --git a/ProtocolLib/src/main/java/com/comphenix/protocol/async/PacketSendingQueue.java b/ProtocolLib/src/main/java/com/comphenix/protocol/async/PacketSendingQueue.java index 01fd8449..e9816259 100644 --- a/ProtocolLib/src/main/java/com/comphenix/protocol/async/PacketSendingQueue.java +++ b/ProtocolLib/src/main/java/com/comphenix/protocol/async/PacketSendingQueue.java @@ -205,7 +205,7 @@ class PacketSendingQueue { } catch (PlayerLoggedOutException e) { System.out.println(String.format( - "Warning: Dropped packet index %s of ID %s", + "[ProtocolLib] Warning: Dropped packet index %s of ID %s", marker.getOriginalSendingIndex(), event.getPacketID() )); diff --git a/ProtocolLib/src/main/java/com/comphenix/protocol/injector/player/PlayerInjectionHandler.java b/ProtocolLib/src/main/java/com/comphenix/protocol/injector/player/PlayerInjectionHandler.java index e601dc72..afc432b9 100644 --- a/ProtocolLib/src/main/java/com/comphenix/protocol/injector/player/PlayerInjectionHandler.java +++ b/ProtocolLib/src/main/java/com/comphenix/protocol/injector/player/PlayerInjectionHandler.java @@ -198,7 +198,7 @@ public class PlayerInjectionHandler { if (injector != null) { return injector.getPlayer(); } else { - System.out.println("Unable to find stream: " + inputStream); + logger.warning("Unable to find stream: " + inputStream); return null; }