Archiviert
13
0

Syncronize before hacking into the packet list. In addition,

copy over any unprocessed packets into the new list.

When we're done, we'll also clean up properly by copying over 
any remaining packets.
Dieser Commit ist enthalten in:
Kristian S. Stangeland 2012-09-13 16:08:41 +02:00
Ursprung 5a6f3be219
Commit 1710ef343b

Datei anzeigen

@ -214,7 +214,12 @@ class PlayerInjector {
for (Field field : list.getFields()) { for (Field field : list.getFields()) {
VolatileField overwriter = new VolatileField(field, networkManager, true); VolatileField overwriter = new VolatileField(field, networkManager, true);
overwriter.setValue(Collections.synchronizedList(new ArrayList<Packet>() { @SuppressWarnings("unchecked")
List<Packet> minecraftList = (List<Packet>) overwriter.getOldValue();
synchronized(minecraftList) {
// The list we'll be inserting
List<Packet> hackedList = new ArrayList<Packet>() {
@Override @Override
public boolean add(Packet packet) { public boolean add(Packet packet) {
@ -245,7 +250,18 @@ class PlayerInjector {
throw new RuntimeException("Reverting cancelled packet failed.", e.getTargetException()); throw new RuntimeException("Reverting cancelled packet failed.", e.getTargetException());
} }
} }
})); };
// Add every previously stored packet
for (Packet packet : minecraftList) {
hackedList.add(packet);
}
// Don' keep stale packets around
minecraftList.clear();
overwriter.setValue(Collections.synchronizedList(hackedList));
}
overridenLists.add(overwriter); overridenLists.add(overwriter);
} }
} }
@ -341,11 +357,29 @@ class PlayerInjector {
} }
} }
@SuppressWarnings("unchecked")
public void cleanupAll() { public void cleanupAll() {
// Clean up // Clean up
for (VolatileField overriden : overridenLists) { for (VolatileField overriden : overridenLists) {
List<Packet> minecraftList = (List<Packet>) overriden.getOldValue();
List<Packet> hacketList = (List<Packet>) overriden.getValue();
if (minecraftList == hacketList) {
return;
}
// Get a lock before we modify the list
synchronized(hacketList) {
try {
// Copy over current packets
for (Packet packet : (List<Packet>) overriden.getValue()) {
minecraftList.add(packet);
}
} finally {
overriden.revertValue(); overriden.revertValue();
} }
}
}
overridenLists.clear(); overridenLists.clear();
} }
} }