geforkt von Mirrors/Paper
8c5b837e05
Firstly, the old methods all routed to the CompletableFuture method. However, the CF method could not guarantee that if the caller was off-main that the future would be "completed" on-main. Since the callback methods used the CF one, this meant that the callback methods did not guarantee that the callbacks were to be called on the main thread. Now, all methods route to getChunkAtAsync(x, z, gen, urgent, cb) so that the methods with the callback are guaranteed to invoke the callback on the main thread. The CF behavior remains unchanged; it may still appear to complete on main if invoked off-main. Secondly, remove the scheduleOnMain invocation in the async chunk completion. This unnecessarily delays the callback by 1 tick. Thirdly, add getChunksAtAsync(minX, minZ, maxX, maxZ, ...) which will load chunks within an area. This method is provided as a helper as keeping all chunks loaded within an area can be complicated to implement for plugins (due to the lacking ticket API), and is already implemented internally anyways. Fourthly, remove the ticket addition that occured with getChunkAt and getChunkAtAsync. The ticket addition may delay the unloading of the chunk unnecessarily. It also fixes a very rare timing bug where the future/callback would be completed after the chunk unloads.
47 Zeilen
2.0 KiB
Diff
47 Zeilen
2.0 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Owen1212055 <23108066+Owen1212055@users.noreply.github.com>
|
|
Date: Sat, 4 Dec 2021 13:29:36 -0500
|
|
Subject: [PATCH] Add Moving Piston API
|
|
|
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/block/CraftMovingPiston.java b/src/main/java/org/bukkit/craftbukkit/block/CraftMovingPiston.java
|
|
index 25b759dee5ae2b311965f26ba311591199894be4..293ac0b658224fc0b3c2acdfc86eff3c8a9fdc04 100644
|
|
--- a/src/main/java/org/bukkit/craftbukkit/block/CraftMovingPiston.java
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/block/CraftMovingPiston.java
|
|
@@ -4,7 +4,7 @@ import net.minecraft.world.level.block.piston.PistonMovingBlockEntity;
|
|
import org.bukkit.Location;
|
|
import org.bukkit.World;
|
|
|
|
-public class CraftMovingPiston extends CraftBlockEntityState<PistonMovingBlockEntity> {
|
|
+public class CraftMovingPiston extends CraftBlockEntityState<PistonMovingBlockEntity> implements io.papermc.paper.block.MovingPiston { // Paper - Add Moving Piston API
|
|
|
|
public CraftMovingPiston(World world, PistonMovingBlockEntity tileEntity) {
|
|
super(world, tileEntity);
|
|
@@ -23,4 +23,26 @@ public class CraftMovingPiston extends CraftBlockEntityState<PistonMovingBlockEn
|
|
public CraftMovingPiston copy(Location location) {
|
|
return new CraftMovingPiston(this, location);
|
|
}
|
|
+
|
|
+ // Paper start - Add Moving Piston API
|
|
+ @Override
|
|
+ public org.bukkit.block.data.BlockData getMovingBlock() {
|
|
+ return org.bukkit.craftbukkit.block.data.CraftBlockData.fromData(this.getTileEntity().getMovedState());
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public org.bukkit.block.BlockFace getDirection() {
|
|
+ return org.bukkit.craftbukkit.block.CraftBlock.notchToBlockFace(this.getTileEntity().getDirection());
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public boolean isExtending() {
|
|
+ return this.getTileEntity().isExtending();
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public boolean isPistonHead() {
|
|
+ return this.getTileEntity().isSourcePiston();
|
|
+ }
|
|
+ // Paper end - Add Moving Piston API
|
|
}
|