From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Spottedleaf Date: Mon, 1 Feb 2021 15:35:14 -0800 Subject: [PATCH] Fix chunks refusing to unload at low TPS The full chunk future is appended to the chunk save future, but when moving to unloaded ticket level it is not being completed with the empty chunk access, so the chunk save must wait for the full chunk future to complete. We can simply schedule to the immediate executor to get this effect, rather than the main mailbox. diff --git a/src/main/java/net/minecraft/server/level/ChunkMap.java b/src/main/java/net/minecraft/server/level/ChunkMap.java index 0bee0f348a6123a27b8bcf02d2a93df9b007b689..52d0896356529d07ce43c0006423ab169cc3b068 100644 --- a/src/main/java/net/minecraft/server/level/ChunkMap.java +++ b/src/main/java/net/minecraft/server/level/ChunkMap.java @@ -1297,9 +1297,7 @@ public class ChunkMap extends ChunkStorage implements ChunkHolder.PlayerProvider return chunk; }); - }, (runnable) -> { - this.mainThreadMailbox.tell(ChunkTaskPriorityQueueSorter.message(playerchunk, runnable)); - }); + }, this.mainThreadExecutor); // Paper - queue to execute immediately so this doesn't delay chunk unloading } public int getTickingGenerated() {