SPIGOT-6851: removeRecipe not unregistering recipe ID

By: md_5 <git@md-5.net>

paper-server/nms-patches/net/minecraft/world/item/crafting/CraftingManager.patch

@@ -116,7 +116,7 @@
              });
              MinecraftKey minecraftkey = irecipe.getId();
              IRecipe<?> irecipe1 = (IRecipe) map1.put(minecraftkey, irecipe);
-@@ -160,6 +186,18 @@
+@@ -160,6 +186,26 @@
              }
          });
          this.recipes = ImmutableMap.copyOf(map);
@@ -125,6 +125,14 @@
 +    }
 +
 +    // CraftBukkit start
++    public boolean removeRecipe(MinecraftKey mcKey) {
++        for (Object2ObjectLinkedOpenHashMap<MinecraftKey, IRecipe<?>> recipes : recipes.values()) {
++            recipes.remove(mcKey);
++        }
++
++        return byName.remove(mcKey) != null;
++    }
++
 +    public void clearRecipes() {
 +        this.recipes = Maps.newHashMap();
 +

paper-server/src/main/java/org/bukkit/craftbukkit/CraftServer.java

@@ -1364,13 +1364,7 @@ public final class CraftServer implements Server {
         Preconditions.checkArgument(recipeKey != null, "recipeKey == null");
 
         MinecraftKey mcKey = CraftNamespacedKey.toMinecraft(recipeKey);
-        for (Object2ObjectLinkedOpenHashMap<MinecraftKey, IRecipe<?>> recipes : getServer().getRecipeManager().recipes.values()) {
+        return getServer().getRecipeManager().removeRecipe(mcKey);
-            if (recipes.remove(mcKey) != null) {
-                return true;
-            }
-        }
-
-        return false;
     }
 
     @Override