From c637868aef5a1f53b40964a1b8cd890378f32b62 Mon Sep 17 00:00:00 2001 From: David Slovikosky Date: Tue, 9 Jun 2020 00:10:03 -0700 Subject: [PATCH] Fix missing chunks due to integer overflow This patch fixes a bug in the EndIslandDensityFunction class where the distance from 0,0 squared overflows the maximum size of an integer. The overflow leads to hard chunk borders around 370,000 blocks from 0,0. After this cutoff there is a few hundred thousand block gap before end land resuming to generate at 530,000 blocks from spawn. This is due to the integer flipping back and forth. The fix for the issue is quite simple, casting chunk coordinates to longs allows the distance calculation to avoid overflow and work as intended. This issue is being tracked in Mojira ticket MC-159283 --- .../world/level/levelgen/DensityFunctions.java.patch | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 paper-server/patches/sources/net/minecraft/world/level/levelgen/DensityFunctions.java.patch diff --git a/paper-server/patches/sources/net/minecraft/world/level/levelgen/DensityFunctions.java.patch b/paper-server/patches/sources/net/minecraft/world/level/levelgen/DensityFunctions.java.patch new file mode 100644 index 0000000000..d04089f013 --- /dev/null +++ b/paper-server/patches/sources/net/minecraft/world/level/levelgen/DensityFunctions.java.patch @@ -0,0 +1,11 @@ +--- a/net/minecraft/world/level/levelgen/DensityFunctions.java ++++ b/net/minecraft/world/level/levelgen/DensityFunctions.java +@@ -521,7 +521,7 @@ + int j = z / 2; + int k = x % 2; + int l = z % 2; +- float f = 100.0F - Mth.sqrt((float)(x * x + z * z)) * 8.0F; ++ float f = 100.0F - Mth.sqrt((long) x * (long) x + (long) z * (long) z) * 8.0F; // Paper - cast ints to long to avoid integer overflow + f = Mth.clamp(f, -100.0F, 80.0F); + + for (int m = -12; m <= 12; m++) {