From 5eb61dd432650bc816bc49374a00e6bd794667ff Mon Sep 17 00:00:00 2001 From: Shane Freeder Date: Sat, 19 Mar 2022 12:22:31 +0000 Subject: [PATCH] Buffer OOB setBlock calls lets debug mode throw a trace in order to potentially see where such calls are cascading from easier, but, generally, if you see one setBlock call, you're gonna see more, and this just potentially causes a flood of logs which can cause issues for slower terminals, etc. We can limit the flood by just allowing one for a single gen region, we'll also only gen a trace for the first one, I see no real pressing need to generate more, given that that would *massively* negate this patch otherwise --- .../0883-Buffer-OOB-setBlock-calls.patch | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 patches/server/0883-Buffer-OOB-setBlock-calls.patch diff --git a/patches/server/0883-Buffer-OOB-setBlock-calls.patch b/patches/server/0883-Buffer-OOB-setBlock-calls.patch new file mode 100644 index 0000000000..af5f320e73 --- /dev/null +++ b/patches/server/0883-Buffer-OOB-setBlock-calls.patch @@ -0,0 +1,42 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: Shane Freeder +Date: Sat, 19 Mar 2022 12:12:22 +0000 +Subject: [PATCH] Buffer OOB setBlock calls + +lets debug mode throw a trace in order to potentially see where +such calls are cascading from easier, but, generally, if you see one setBlock +call, you're gonna see more, and this just potentially causes a flood of logs +which can cause issues for slower terminals, etc. + +We can limit the flood by just allowing one for a single gen region, +we'll also only gen a trace for the first one, I see no real pressing need +to generate more, given that that would *massively* negate this patch otherwise + +diff --git a/src/main/java/net/minecraft/server/level/WorldGenRegion.java b/src/main/java/net/minecraft/server/level/WorldGenRegion.java +index a24f605bd033f249a374e83ba094880106260eee..1e656438d9ee89b97c660f3b3ec671be6546c6b7 100644 +--- a/src/main/java/net/minecraft/server/level/WorldGenRegion.java ++++ b/src/main/java/net/minecraft/server/level/WorldGenRegion.java +@@ -266,6 +266,7 @@ public class WorldGenRegion implements WorldGenLevel { + } + } + ++ private boolean hasSetFarWarned = false; // Paper + @Override + public boolean ensureCanWrite(BlockPos pos) { + int i = SectionPos.blockToSectionCoord(pos.getX()); +@@ -285,7 +286,15 @@ public class WorldGenRegion implements WorldGenLevel { + + return true; + } else { ++ // Paper start ++ if (!hasSetFarWarned) { + Util.logAndPauseIfInIde("Detected setBlock in a far chunk [" + i + ", " + j + "], pos: " + pos + ", status: " + this.generatingStatus + (this.currentlyGenerating == null ? "" : ", currently generating: " + (String) this.currentlyGenerating.get())); ++ hasSetFarWarned = true; ++ if (this.getServer() != null && this.getServer().isDebugging()) { ++ io.papermc.paper.util.TraceUtil.dumpTraceForThread("far setBlock call"); ++ } ++ } ++ // Paper end + return false; + } + }