From 3f4b9fd3655e8fc503c5006ca96deab8a102b0ed Mon Sep 17 00:00:00 2001 From: Aikar Date: Mon, 21 Dec 2020 11:01:42 -0500 Subject: [PATCH] Optimize Dynamic#get Missing Keys get was calling toString() on every NBT object that was ever asked for an optional key from the object to build a string for the error text. When done on large NBT objects, this was using a ton of computation time building the JSON representation of the NBT object. Now we will just skip the value when 99.9999% of the time the text is never even printed. --- .../mojang/serialization/Dynamic.java.patch | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 paper-server/patches/sources/com/mojang/serialization/Dynamic.java.patch diff --git a/paper-server/patches/sources/com/mojang/serialization/Dynamic.java.patch b/paper-server/patches/sources/com/mojang/serialization/Dynamic.java.patch new file mode 100644 index 0000000000..cdd24c2f21 --- /dev/null +++ b/paper-server/patches/sources/com/mojang/serialization/Dynamic.java.patch @@ -0,0 +1,19 @@ +--- a/com/mojang/serialization/Dynamic.java ++++ b/com/mojang/serialization/Dynamic.java +@@ -19,6 +19,7 @@ + + @SuppressWarnings("unused") + public class Dynamic extends DynamicLike { ++ private static final boolean DEBUG_MISSING_KEYS = Boolean.getBoolean("Paper.debugDynamicMissingKeys"); // Paper - Perf: Skip toString on values like NBT + private final T value; + + public Dynamic(final DynamicOps ops) { +@@ -120,7 +121,7 @@ + return new OptionalDynamic<>(ops, ops.getMap(value).flatMap(m -> { + final T value = m.get(key); + if (value == null) { +- return DataResult.error(() -> "key missing: " + key + " in " + this.value); ++ return DataResult.error(() -> DEBUG_MISSING_KEYS ? "key missing: " + key + " in " + this.value : "key missing: " + key); // Paper - Perf: Skip toString on values like NBT + } + return DataResult.success(new Dynamic<>(ops, value)); + }));