13
0
geforkt von Mirrors/Paper

Catch all exceptions in jansi initialization. Fixes BUKKIT-4936

Both log4j and our own jline/jansi initialization attempt to catch
errors caused by jansi's use of native libraries. However both of them use
the Exception type which does not catch all errors. On Windows Server 2008
R2 Enterprise without installing extra software the required C++ libraries
are not available which causes an error that does not extend Exception. To
ensure we catch all errors I've changed both of these to catch Throwable
instead which gets us a working console minus jansi functionality.

By: Travis Watkins <amaranth@ubuntu.com>
Dieser Commit ist enthalten in:
CraftBukkit/Spigot 2013-12-02 15:43:55 -06:00
Ursprung 503d91b89d
Commit 2217dbe212

Datei anzeigen

@ -130,7 +130,7 @@ public final class ConsoleAppender extends AbstractOutputStreamAppender {
LOGGER.debug("Jansi is not installed, cannot find {}", JANSI_CLASS); LOGGER.debug("Jansi is not installed, cannot find {}", JANSI_CLASS);
} catch (final NoSuchMethodException nsme) { } catch (final NoSuchMethodException nsme) {
LOGGER.warn("{} is missing the proper constructor", JANSI_CLASS); LOGGER.warn("{} is missing the proper constructor", JANSI_CLASS);
} catch (final Exception ex) { } catch (final Throwable ex) { // CraftBukkit - Exception -> Throwable
LOGGER.warn("Unable to instantiate {}", JANSI_CLASS); LOGGER.warn("Unable to instantiate {}", JANSI_CLASS);
} }
return printStream; return printStream;