2019-04-22 23:36:14 +02:00
|
|
|
From 6287458c83ada09b092886a8aa35534838222ed2 Mon Sep 17 00:00:00 2001
|
2018-08-26 20:11:49 +02:00
|
|
|
From: Aikar <aikar@aikar.co>
|
|
|
|
Date: Sun, 26 Aug 2018 20:49:50 -0400
|
|
|
|
Subject: [PATCH] Optimize RegistryMaterials
|
|
|
|
|
|
|
|
Use larger initial sizes to increase bucket capacity on the BiMap
|
|
|
|
|
|
|
|
BiMap.get was seen to be using a good bit of CPU time.
|
|
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/RegistryMaterials.java b/src/main/java/net/minecraft/server/RegistryMaterials.java
|
2019-04-22 23:36:14 +02:00
|
|
|
index 1521ed759b..78de740acf 100644
|
2018-08-26 20:11:49 +02:00
|
|
|
--- a/src/main/java/net/minecraft/server/RegistryMaterials.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/RegistryMaterials.java
|
2019-01-01 04:15:55 +01:00
|
|
|
@@ -15,9 +15,9 @@ import org.apache.logging.log4j.Logger;
|
2018-09-01 00:56:57 +02:00
|
|
|
public class RegistryMaterials<V> implements IRegistry<V> {
|
2019-01-01 04:15:55 +01:00
|
|
|
|
2018-08-26 20:11:49 +02:00
|
|
|
protected static final Logger a = LogManager.getLogger();
|
2019-01-01 04:15:55 +01:00
|
|
|
- protected final RegistryID<V> b = new RegistryID<>(256);
|
2018-08-26 20:11:49 +02:00
|
|
|
- protected final BiMap<MinecraftKey, V> c = HashBiMap.create();
|
2019-01-01 04:15:55 +01:00
|
|
|
- protected Object[] d;
|
2018-09-01 00:56:57 +02:00
|
|
|
+ protected final RegistryID<V> b = new RegistryID<V>(2048); // Paper - use bigger expected size to reduce collisions
|
2018-08-26 20:11:49 +02:00
|
|
|
+ protected final BiMap<MinecraftKey, V> c = HashBiMap.create(2048); // Paper - use bigger expected size to reduce collisions
|
2019-01-01 04:15:55 +01:00
|
|
|
+ protected V[] d; // Paper - Decompile fix
|
2018-08-26 20:11:49 +02:00
|
|
|
private int x;
|
|
|
|
|
2019-01-01 04:15:55 +01:00
|
|
|
public RegistryMaterials() {}
|
|
|
|
@@ -90,7 +90,7 @@ public class RegistryMaterials<V> implements IRegistry<V> {
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
|
|
|
|
- this.d = collection.toArray(new Object[collection.size()]);
|
|
|
|
+ this.d = (V[]) collection.toArray(new Object[collection.size()]); // Paper - Decompile fix
|
|
|
|
}
|
|
|
|
|
|
|
|
return this.d[random.nextInt(this.d.length)];
|
2018-08-26 20:11:49 +02:00
|
|
|
--
|
2019-03-20 02:46:00 +01:00
|
|
|
2.21.0
|
2018-08-26 20:11:49 +02:00
|
|
|
|