2021-06-11 14:02:28 +02:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
From: Aikar <aikar@aikar.co>
|
|
|
|
Date: Tue, 1 Mar 2016 23:52:34 -0600
|
|
|
|
Subject: [PATCH] Prevent tile entity and entity crashes
|
|
|
|
|
|
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/world/level/Level.java b/src/main/java/net/minecraft/world/level/Level.java
|
2021-11-23 13:15:10 +01:00
|
|
|
index e112598c854a2c93a8e6b6bda3cfdd4ee4091980..1195a4b79103d62ed4f8c91dd36ccd77fa561f01 100644
|
2021-06-11 14:02:28 +02:00
|
|
|
--- a/src/main/java/net/minecraft/world/level/Level.java
|
|
|
|
+++ b/src/main/java/net/minecraft/world/level/Level.java
|
2021-11-23 13:15:10 +01:00
|
|
|
@@ -737,11 +737,11 @@ public abstract class Level implements LevelAccessor, AutoCloseable {
|
2021-06-11 14:02:28 +02:00
|
|
|
try {
|
|
|
|
tickConsumer.accept(entity);
|
|
|
|
} catch (Throwable throwable) {
|
|
|
|
- CrashReport crashreport = CrashReport.forThrowable(throwable, "Ticking entity");
|
|
|
|
- CrashReportCategory crashreportsystemdetails = crashreport.addCategory("Entity being ticked");
|
|
|
|
-
|
|
|
|
- entity.fillCrashReportCategory(crashreportsystemdetails);
|
|
|
|
- throw new ReportedException(crashreport);
|
|
|
|
+ // Paper start - Prevent tile entity and entity crashes
|
2021-06-21 10:09:18 +02:00
|
|
|
+ final String msg = String.format("Entity threw exception at %s:%s,%s,%s", entity.level.getWorld().getName(), entity.getX(), entity.getY(), entity.getZ());
|
|
|
|
+ MinecraftServer.LOGGER.error(msg, throwable);
|
2021-06-12 00:37:16 +02:00
|
|
|
+ entity.discard();
|
2021-06-11 14:02:28 +02:00
|
|
|
+ // Paper end
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/world/level/block/entity/BlockEntity.java b/src/main/java/net/minecraft/world/level/block/entity/BlockEntity.java
|
2021-11-23 13:15:10 +01:00
|
|
|
index e1cbecc402bfc14fb9e36d5c449cd404f119752d..52b4c231faa2f33f766f50399e52e30184fb01a7 100644
|
2021-06-11 14:02:28 +02:00
|
|
|
--- a/src/main/java/net/minecraft/world/level/block/entity/BlockEntity.java
|
|
|
|
+++ b/src/main/java/net/minecraft/world/level/block/entity/BlockEntity.java
|
2021-11-23 13:15:10 +01:00
|
|
|
@@ -233,7 +233,12 @@ public abstract class BlockEntity implements io.papermc.paper.util.KeyedObject {
|
2021-06-12 00:37:16 +02:00
|
|
|
return minecraftkey + " // " + this.getClass().getCanonicalName();
|
2021-06-11 14:02:28 +02:00
|
|
|
});
|
|
|
|
if (this.level != null) {
|
2021-06-12 00:37:16 +02:00
|
|
|
- CrashReportCategory.populateBlockDetails(crashReportSection, this.level, this.worldPosition, this.getBlockState());
|
2021-06-11 14:02:28 +02:00
|
|
|
+ // Paper start - Prevent TileEntity and Entity crashes
|
|
|
|
+ BlockState block = this.getBlockState();
|
|
|
|
+ if (block != null) {
|
2021-06-12 00:37:16 +02:00
|
|
|
+ CrashReportCategory.populateBlockDetails(crashReportSection, this.level, this.worldPosition, block);
|
2021-06-11 14:02:28 +02:00
|
|
|
+ }
|
|
|
|
+ // Paper end
|
2021-06-12 00:37:16 +02:00
|
|
|
CrashReportCategory.populateBlockDetails(crashReportSection, this.level, this.worldPosition, this.level.getBlockState(this.worldPosition));
|
2021-06-11 14:02:28 +02:00
|
|
|
}
|
|
|
|
}
|
2021-06-12 00:37:16 +02:00
|
|
|
diff --git a/src/main/java/net/minecraft/world/level/chunk/LevelChunk.java b/src/main/java/net/minecraft/world/level/chunk/LevelChunk.java
|
2021-11-23 13:15:10 +01:00
|
|
|
index 3e4ece7b607d06c9d88322ce79f4888e1cc07aee..cadcafec7dc8af1e938b20d07bd9a24acd350ab1 100644
|
2021-06-12 00:37:16 +02:00
|
|
|
--- a/src/main/java/net/minecraft/world/level/chunk/LevelChunk.java
|
|
|
|
+++ b/src/main/java/net/minecraft/world/level/chunk/LevelChunk.java
|
2021-11-23 13:15:10 +01:00
|
|
|
@@ -1029,11 +1029,11 @@ public class LevelChunk extends ChunkAccess {
|
2021-06-12 00:37:16 +02:00
|
|
|
|
|
|
|
gameprofilerfiller.pop();
|
|
|
|
} catch (Throwable throwable) {
|
|
|
|
- CrashReport crashreport = CrashReport.forThrowable(throwable, "Ticking block entity");
|
|
|
|
- CrashReportCategory crashreportsystemdetails = crashreport.addCategory("Block entity being ticked");
|
|
|
|
-
|
|
|
|
- this.blockEntity.fillCrashReportCategory(crashreportsystemdetails);
|
|
|
|
- throw new ReportedException(crashreport);
|
|
|
|
+ // Paper start - Prevent tile entity and entity crashes
|
2021-06-21 10:09:18 +02:00
|
|
|
+ final String msg = String.format("BlockEntity threw exception at %s:%s,%s,%s", LevelChunk.this.getLevel().getWorld().getName(), this.getPos().getX(), this.getPos().getY(), this.getPos().getZ());
|
|
|
|
+ net.minecraft.server.MinecraftServer.LOGGER.error(msg, throwable);
|
2021-06-12 00:37:16 +02:00
|
|
|
+ LevelChunk.this.removeBlockEntity(this.getPos());
|
|
|
|
+ // Paper end
|
|
|
|
// Spigot start
|
|
|
|
} finally {
|
|
|
|
this.blockEntity.tickTimer.stopTiming();
|