2022-07-30 18:28:24 +02:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
|
From: Owen1212055 <23108066+Owen1212055@users.noreply.github.com>
|
|
|
|
|
Date: Sat, 30 Jul 2022 11:23:05 -0400
|
|
|
|
|
Subject: [PATCH] Custom Chat Completion Suggestions API
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java b/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java
|
Rework async chunk api implementation
Firstly, the old methods all routed to the CompletableFuture method.
However, the CF method could not guarantee that if the caller
was off-main that the future would be "completed" on-main. Since
the callback methods used the CF one, this meant that the callback
methods did not guarantee that the callbacks were to be called on
the main thread.
Now, all methods route to getChunkAtAsync(x, z, gen, urgent, cb)
so that the methods with the callback are guaranteed to invoke
the callback on the main thread. The CF behavior remains unchanged;
it may still appear to complete on main if invoked off-main.
Secondly, remove the scheduleOnMain invocation in the async
chunk completion. This unnecessarily delays the callback
by 1 tick.
Thirdly, add getChunksAtAsync(minX, minZ, maxX, maxZ, ...) which
will load chunks within an area. This method is provided as a helper
as keeping all chunks loaded within an area can be complicated to
implement for plugins (due to the lacking ticket API), and is
already implemented internally anyways.
Fourthly, remove the ticket addition that occured with getChunkAt
and getChunkAtAsync. The ticket addition may delay the unloading
of the chunk unnecessarily. It also fixes a very rare timing bug
where the future/callback would be completed after the chunk
unloads.
2024-11-19 07:34:32 +01:00
|
|
|
index 87aa5f0d594ff697b87bc06019351d22b6c8c8e5..51b6b8d54b139bc89e0343c7c1ec5acedcf6f8a2 100644
|
2022-07-30 18:28:24 +02:00
|
|
|
--- a/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java
|
|
|
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java
|
2024-11-09 21:17:42 +01:00
|
|
|
@@ -696,6 +696,24 @@ public class CraftPlayer extends CraftHumanEntity implements Player {
|
2022-07-30 18:28:24 +02:00
|
|
|
}
|
2024-01-19 22:13:42 +01:00
|
|
|
// Paper end - Add sendOpLevel API
|
2023-11-04 21:20:13 +01:00
|
|
|
|
|
|
|
|
+ // Paper start - custom chat completions API
|
2022-07-30 18:28:24 +02:00
|
|
|
+ @Override
|
|
|
|
|
+ public void addAdditionalChatCompletions(@NotNull Collection<String> completions) {
|
|
|
|
|
+ this.getHandle().connection.send(new net.minecraft.network.protocol.game.ClientboundCustomChatCompletionsPacket(
|
|
|
|
|
+ net.minecraft.network.protocol.game.ClientboundCustomChatCompletionsPacket.Action.ADD,
|
|
|
|
|
+ new ArrayList<>(completions)
|
|
|
|
|
+ ));
|
|
|
|
|
+ }
|
|
|
|
|
+
|
|
|
|
|
+ @Override
|
|
|
|
|
+ public void removeAdditionalChatCompletions(@NotNull Collection<String> completions) {
|
|
|
|
|
+ this.getHandle().connection.send(new net.minecraft.network.protocol.game.ClientboundCustomChatCompletionsPacket(
|
|
|
|
|
+ net.minecraft.network.protocol.game.ClientboundCustomChatCompletionsPacket.Action.REMOVE,
|
|
|
|
|
+ new ArrayList<>(completions)
|
|
|
|
|
+ ));
|
|
|
|
|
+ }
|
2023-11-04 21:20:13 +01:00
|
|
|
+ // Paper end - custom chat completions API
|
|
|
|
|
+
|
2022-07-30 18:28:24 +02:00
|
|
|
@Override
|
2023-11-04 21:20:13 +01:00
|
|
|
public void setCompassTarget(Location loc) {
|
|
|
|
|
Preconditions.checkArgument(loc != null, "Location cannot be null");
|