Paper/Spigot-Server-Patches/0349-Don-t-check-ConvertSigns-boolean-every-sign-save.patch

From 772930536a82a47d4a6dda82e42aca2a60c48f30 Mon Sep 17 00:00:00 2001
From: Aikar <aikar@aikar.co>
Date: Sat, 2 Mar 2019 11:11:29 -0500
Subject: [PATCH] Don't check ConvertSigns boolean every sign save

property lookups arent super cheap. they synchronize, validate
and check security managers.

diff --git a/src/main/java/net/minecraft/server/TileEntitySign.java b/src/main/java/net/minecraft/server/TileEntitySign.java
index a93402019..0e9a90b70 100644
--- a/src/main/java/net/minecraft/server/TileEntitySign.java
+++ b/src/main/java/net/minecraft/server/TileEntitySign.java
@@ -11,6 +11,7 @@ public class TileEntitySign extends TileEntity implements ICommandListener { //
     private final String[] g = new String[4];
     private EnumColor color;
     public java.util.UUID signEditor; // Paper
+    private static final boolean CONVERT_LEGACY_SIGNS = Boolean.getBoolean("convertLegacySigns"); // Paper
 
     public TileEntitySign() {
         super(TileEntityTypes.SIGN);
@@ -28,7 +29,7 @@ public class TileEntitySign extends TileEntity implements ICommandListener { //
         }
 
         // CraftBukkit start
-        if (Boolean.getBoolean("convertLegacySigns")) {
+        if (CONVERT_LEGACY_SIGNS) { // Paper
             nbttagcompound.setBoolean("Bukkit.isConverted", true);
         }
         // CraftBukkit end
-- 
2.25.0