2019-06-14 04:27:40 +02:00
|
|
|
From 880183aec51a5b5a20c61fb20be1c179c4fb0022 Mon Sep 17 00:00:00 2001
|
2016-03-09 05:42:08 +01:00
|
|
|
From: Aikar <aikar@aikar.co>
|
|
|
|
Date: Tue, 8 Mar 2016 23:25:45 -0500
|
|
|
|
Subject: [PATCH] Disable Scoreboards for non players by default
|
|
|
|
|
|
|
|
Entities collision is checking for scoreboards setting.
|
|
|
|
This is very heavy to do map lookups for every collision to check
|
|
|
|
this setting.
|
|
|
|
|
|
|
|
So avoid looking up scoreboards and short circuit to the "not on a team"
|
|
|
|
logic which is most likely to be true.
|
|
|
|
|
|
|
|
diff --git a/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java b/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
|
2019-05-28 01:01:45 +02:00
|
|
|
index 94f5c90b3c..30f0dcfd51 100644
|
2016-03-09 05:42:08 +01:00
|
|
|
--- a/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
|
|
|
|
+++ b/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
|
2019-04-26 03:24:00 +02:00
|
|
|
@@ -196,4 +196,9 @@ public class PaperWorldConfig {
|
2016-03-09 05:42:08 +01:00
|
|
|
private void disableTeleportationSuffocationCheck() {
|
|
|
|
disableTeleportationSuffocationCheck = getBoolean("disable-teleportation-suffocation-check", false);
|
|
|
|
}
|
|
|
|
+
|
|
|
|
+ public boolean nonPlayerEntitiesOnScoreboards = false;
|
|
|
|
+ private void nonPlayerEntitiesOnScoreboards() {
|
|
|
|
+ nonPlayerEntitiesOnScoreboards = getBoolean("allow-non-player-entities-on-scoreboards", false);
|
|
|
|
+ }
|
|
|
|
}
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/Entity.java b/src/main/java/net/minecraft/server/Entity.java
|
2019-06-06 17:36:57 +02:00
|
|
|
index 8165655c31..3d739c4316 100644
|
2016-03-09 05:42:08 +01:00
|
|
|
--- a/src/main/java/net/minecraft/server/Entity.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/Entity.java
|
2019-05-26 03:56:30 +02:00
|
|
|
@@ -2213,6 +2213,7 @@ public abstract class Entity implements INamableTileEntity, ICommandListener, Ke
|
2016-03-09 05:42:08 +01:00
|
|
|
|
2016-05-12 04:07:46 +02:00
|
|
|
@Nullable
|
2018-12-17 06:18:06 +01:00
|
|
|
public ScoreboardTeamBase getScoreboardTeam() {
|
2016-03-09 05:42:08 +01:00
|
|
|
+ if (!this.world.paperConfig.nonPlayerEntitiesOnScoreboards && !(this instanceof EntityHuman)) { return null; } // Paper
|
2018-07-15 03:53:17 +02:00
|
|
|
return this.world.getScoreboard().getPlayerTeam(this.getName());
|
2016-03-09 05:42:08 +01:00
|
|
|
}
|
|
|
|
|
2018-07-15 03:53:17 +02:00
|
|
|
diff --git a/src/main/java/net/minecraft/server/EntityLiving.java b/src/main/java/net/minecraft/server/EntityLiving.java
|
2019-06-06 17:36:57 +02:00
|
|
|
index 061f708aea..d6475338b5 100644
|
2018-07-15 03:53:17 +02:00
|
|
|
--- a/src/main/java/net/minecraft/server/EntityLiving.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/EntityLiving.java
|
2019-05-28 01:01:45 +02:00
|
|
|
@@ -582,6 +582,7 @@ public abstract class EntityLiving extends Entity {
|
2018-07-15 03:53:17 +02:00
|
|
|
if (nbttagcompound.hasKeyOfType("Team", 8)) {
|
|
|
|
String s = nbttagcompound.getString("Team");
|
|
|
|
ScoreboardTeam scoreboardteam = this.world.getScoreboard().getTeam(s);
|
|
|
|
+ if (!world.paperConfig.nonPlayerEntitiesOnScoreboards && !(this instanceof EntityHuman)) { scoreboardteam = null; } // Paper
|
2019-04-26 03:24:00 +02:00
|
|
|
boolean flag = scoreboardteam != null && this.world.getScoreboard().addPlayerToTeam(this.getUniqueIDString(), scoreboardteam);
|
2018-07-15 03:53:17 +02:00
|
|
|
|
|
|
|
if (!flag) {
|
2016-03-09 05:42:08 +01:00
|
|
|
--
|
2019-04-05 06:52:02 +02:00
|
|
|
2.21.0
|
2016-03-09 05:42:08 +01:00
|
|
|
|