2021-06-11 14:02:28 +02:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
From: Aikar <aikar@aikar.co>
|
|
|
|
Date: Tue, 8 Mar 2016 23:25:45 -0500
|
|
|
|
Subject: [PATCH] Disable Scoreboards for non players by default
|
|
|
|
|
|
|
|
Entities collision is checking for scoreboards setting.
|
|
|
|
This is very heavy to do map lookups for every collision to check
|
|
|
|
this setting.
|
|
|
|
|
|
|
|
So avoid looking up scoreboards and short circuit to the "not on a team"
|
|
|
|
logic which is most likely to be true.
|
|
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/world/entity/Entity.java b/src/main/java/net/minecraft/world/entity/Entity.java
|
2023-05-12 13:10:08 +02:00
|
|
|
index faa958b79b3e6d767f009e7b8b4a6cf1296e39ac..606f3038f6c4a92cb0ae7debb97795abc70a8fb8 100644
|
2021-06-11 14:02:28 +02:00
|
|
|
--- a/src/main/java/net/minecraft/world/entity/Entity.java
|
|
|
|
+++ b/src/main/java/net/minecraft/world/entity/Entity.java
|
2023-05-12 13:10:08 +02:00
|
|
|
@@ -2682,6 +2682,7 @@ public abstract class Entity implements Nameable, EntityAccess, CommandSource {
|
2021-06-11 14:02:28 +02:00
|
|
|
|
|
|
|
@Nullable
|
|
|
|
public Team getTeam() {
|
2022-06-09 10:51:45 +02:00
|
|
|
+ if (!this.level.paperConfig().scoreboards.allowNonPlayerEntitiesOnScoreboards && !(this instanceof Player)) { return null; } // Paper
|
2021-06-12 02:57:04 +02:00
|
|
|
return this.level.getScoreboard().getPlayersTeam(this.getScoreboardName());
|
2021-06-11 14:02:28 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/world/entity/LivingEntity.java b/src/main/java/net/minecraft/world/entity/LivingEntity.java
|
2023-05-12 13:10:08 +02:00
|
|
|
index 4dcaaa2c10966b975d612de8453af7a7f1c32b16..02b3e953f48721030d8c2b4cf82d1b93a4ccf1bf 100644
|
2021-06-11 14:02:28 +02:00
|
|
|
--- a/src/main/java/net/minecraft/world/entity/LivingEntity.java
|
|
|
|
+++ b/src/main/java/net/minecraft/world/entity/LivingEntity.java
|
2023-03-14 19:36:39 +01:00
|
|
|
@@ -816,6 +816,7 @@ public abstract class LivingEntity extends Entity implements Attackable {
|
2021-06-12 02:57:04 +02:00
|
|
|
if (nbt.contains("Team", 8)) {
|
|
|
|
String s = nbt.getString("Team");
|
|
|
|
PlayerTeam scoreboardteam = this.level.getScoreboard().getPlayerTeam(s);
|
2022-06-09 10:51:45 +02:00
|
|
|
+ if (!level.paperConfig().scoreboards.allowNonPlayerEntitiesOnScoreboards && !(this instanceof net.minecraft.world.entity.player.Player)) { scoreboardteam = null; } // Paper
|
2021-06-11 14:02:28 +02:00
|
|
|
boolean flag = scoreboardteam != null && this.level.getScoreboard().addPlayerToTeam(this.getStringUUID(), scoreboardteam);
|
|
|
|
|
|
|
|
if (!flag) {
|