Paper/Spigot-Server-Patches/0134-Fix-AIOOBE-in-inventory-handling.patch

From a01021102b786403cb71a732788e62ec111eee75 Mon Sep 17 00:00:00 2001
From: Brokkonaut <hannos17@gmx.de>
Date: Sun, 4 Sep 2016 16:35:43 -0500
Subject: [PATCH] Fix AIOOBE in inventory handling


diff --git a/src/main/java/net/minecraft/server/PlayerConnection.java b/src/main/java/net/minecraft/server/PlayerConnection.java
index 0fe8d1c3f1..ed02cd7a7a 100644
--- a/src/main/java/net/minecraft/server/PlayerConnection.java
+++ b/src/main/java/net/minecraft/server/PlayerConnection.java
@@ -2086,7 +2086,7 @@ public class PlayerConnection implements PacketListenerPlayIn, ITickable {
                     case CLONE:
                         if (packetplayinwindowclick.d() == 2) {
                             click = ClickType.MIDDLE;
-                            if (packetplayinwindowclick.c() == -999) {
+                            if (packetplayinwindowclick.c() < 0) { // Paper - GH-404
                                 action = InventoryAction.NOTHING;
                             } else {
                                 Slot slot = this.player.activeContainer.getSlot(packetplayinwindowclick.c());
-- 
2.18.0
[Auto] Update Upstream Upstream has released updates that appear to apply compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing. Bukkit Changes: d2834556 SPIGOT-4219: Event for PigZombies angering. CraftBukkit Changes: a9c796f1 SPIGOT-4184: Fix furnaces not matching Vanilla smelt or animations 195f071e SPIGOT-4219: Event for PigZombies angering. 5e3082c7 SPIGOT-4230: Improve legacy block types 2018-08-06 01:46:43 +02:00			`From a01021102b786403cb71a732788e62ec111eee75 Mon Sep 17 00:00:00 2001`
Fix an AIOOBE in inventory handling Closes GH-404 2016-09-04 23:49:29 +02:00			`From: Brokkonaut <hannos17@gmx.de>`
			`Date: Sun, 4 Sep 2016 16:35:43 -0500`
			`Subject: [PATCH] Fix AIOOBE in inventory handling`


			`diff --git a/src/main/java/net/minecraft/server/PlayerConnection.java b/src/main/java/net/minecraft/server/PlayerConnection.java`
Explictly reset chat format in vanilla scoreboard display (fixes #1263) Vanilla now uses chat components for scoreboards, thus no longer returns a string which also resets the chat the chat format, add this back ourselves. 2018-07-25 10:58:03 +02:00			`index 0fe8d1c3f1..ed02cd7a7a 100644`
Fix an AIOOBE in inventory handling Closes GH-404 2016-09-04 23:49:29 +02:00			`--- a/src/main/java/net/minecraft/server/PlayerConnection.java`
			`+++ b/src/main/java/net/minecraft/server/PlayerConnection.java`
Explictly reset chat format in vanilla scoreboard display (fixes #1263) Vanilla now uses chat components for scoreboards, thus no longer returns a string which also resets the chat the chat format, add this back ourselves. 2018-07-25 10:58:03 +02:00			`@@ -2086,7 +2086,7 @@ public class PlayerConnection implements PacketListenerPlayIn, ITickable {`
Fix an AIOOBE in inventory handling Closes GH-404 2016-09-04 23:49:29 +02:00			`case CLONE:`
NOT FINISHED! even more 1.13-pre patches! 2018-07-16 22:08:09 +02:00			`if (packetplayinwindowclick.d() == 2) {`
Fix an AIOOBE in inventory handling Closes GH-404 2016-09-04 23:49:29 +02:00			`click = ClickType.MIDDLE;`
NOT FINISHED! even more 1.13-pre patches! 2018-07-16 22:08:09 +02:00			`- if (packetplayinwindowclick.c() == -999) {`
			`+ if (packetplayinwindowclick.c() < 0) { // Paper - GH-404`
Fix an AIOOBE in inventory handling Closes GH-404 2016-09-04 23:49:29 +02:00			`action = InventoryAction.NOTHING;`
			`} else {`
NOT FINISHED! even more 1.13-pre patches! 2018-07-16 22:08:09 +02:00			`Slot slot = this.player.activeContainer.getSlot(packetplayinwindowclick.c());`
Fix an AIOOBE in inventory handling Closes GH-404 2016-09-04 23:49:29 +02:00			`--`
Current Chunk for Entity and Block Entities, counts by entity type This enables us a fast reference to the entities current chunk instead of having to look it up by hashmap lookups. We also store counts by type to further enable other performance optimizations in later patches. 2018-07-04 09:55:24 +02:00			`2.18.0`
Fix an AIOOBE in inventory handling Closes GH-404 2016-09-04 23:49:29 +02:00