8c5b837e05
Firstly, the old methods all routed to the CompletableFuture method. However, the CF method could not guarantee that if the caller was off-main that the future would be "completed" on-main. Since the callback methods used the CF one, this meant that the callback methods did not guarantee that the callbacks were to be called on the main thread. Now, all methods route to getChunkAtAsync(x, z, gen, urgent, cb) so that the methods with the callback are guaranteed to invoke the callback on the main thread. The CF behavior remains unchanged; it may still appear to complete on main if invoked off-main. Secondly, remove the scheduleOnMain invocation in the async chunk completion. This unnecessarily delays the callback by 1 tick. Thirdly, add getChunksAtAsync(minX, minZ, maxX, maxZ, ...) which will load chunks within an area. This method is provided as a helper as keeping all chunks loaded within an area can be complicated to implement for plugins (due to the lacking ticket API), and is already implemented internally anyways. Fourthly, remove the ticket addition that occured with getChunkAt and getChunkAtAsync. The ticket addition may delay the unloading of the chunk unnecessarily. It also fixes a very rare timing bug where the future/callback would be completed after the chunk unloads.
32 Zeilen
1.4 KiB
Diff
32 Zeilen
1.4 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: vicisacat <victor.branchu@gmail.com>
|
|
Date: Fri, 15 Mar 2024 17:35:40 +0100
|
|
Subject: [PATCH] Expanded Hopper API
|
|
|
|
== AT ==
|
|
public net.minecraft.world.level.block.entity.HopperBlockEntity setCooldown(I)V
|
|
public net.minecraft.world.level.block.entity.HopperBlockEntity cooldownTime
|
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/block/CraftHopper.java b/src/main/java/org/bukkit/craftbukkit/block/CraftHopper.java
|
|
index 2995b407415c77288a54c3f4eb8cb93e1a289283..f3c4d3835a18475e2cd2f519ac3dd9d9b59c454d 100644
|
|
--- a/src/main/java/org/bukkit/craftbukkit/block/CraftHopper.java
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/block/CraftHopper.java
|
|
@@ -40,4 +40,17 @@ public class CraftHopper extends CraftLootable<HopperBlockEntity> implements Hop
|
|
public CraftHopper copy(Location location) {
|
|
return new CraftHopper(this, location);
|
|
}
|
|
+
|
|
+ // Paper start - Expanded Hopper API
|
|
+ @Override
|
|
+ public void setTransferCooldown(final int cooldown) {
|
|
+ com.google.common.base.Preconditions.checkArgument(cooldown >= 0, "Hooper transfer cooldown cannot be negative (" + cooldown + ")");
|
|
+ getSnapshot().setCooldown(cooldown);
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public int getTransferCooldown() {
|
|
+ return getSnapshot().cooldownTime;
|
|
+ }
|
|
+ // Paper end - Expanded Hopper API
|
|
}
|