b8a672dd94
I mistakenly thought .complete() also checked for textures, which was not the case So the logic was not working as desired. Also some undesired logic paths lead to textures of the logging in player being dropped, forcing us to always load the textures immediately again on login, leading to rate limits. Everythings now good the .complete() api now will default specify to also complete textures, but you may pass false to it to skip loading textures.
352 Zeilen
12 KiB
Diff
352 Zeilen
12 KiB
Diff
From f925d0e5462649589e4dc8c9faf378d90f4b5df8 Mon Sep 17 00:00:00 2001
|
|
From: Aikar <aikar@aikar.co>
|
|
Date: Mon, 15 Jan 2018 22:11:48 -0500
|
|
Subject: [PATCH] Basic PlayerProfile API
|
|
|
|
|
|
diff --git a/src/main/java/com/destroystokyo/paper/profile/CraftPlayerProfile.java b/src/main/java/com/destroystokyo/paper/profile/CraftPlayerProfile.java
|
|
new file mode 100644
|
|
index 000000000..616a7b218
|
|
--- /dev/null
|
|
+++ b/src/main/java/com/destroystokyo/paper/profile/CraftPlayerProfile.java
|
|
@@ -0,0 +1,262 @@
|
|
+package com.destroystokyo.paper.profile;
|
|
+
|
|
+import com.destroystokyo.paper.PaperConfig;
|
|
+import com.google.common.base.Charsets;
|
|
+import com.mojang.authlib.GameProfile;
|
|
+import com.mojang.authlib.properties.Property;
|
|
+import com.mojang.authlib.properties.PropertyMap;
|
|
+import net.minecraft.server.MinecraftServer;
|
|
+import net.minecraft.server.UserCache;
|
|
+import org.bukkit.craftbukkit.entity.CraftPlayer;
|
|
+import org.spigotmc.SpigotConfig;
|
|
+
|
|
+import javax.annotation.Nonnull;
|
|
+import javax.annotation.Nullable;
|
|
+import java.util.AbstractSet;
|
|
+import java.util.Collection;
|
|
+import java.util.Iterator;
|
|
+import java.util.Set;
|
|
+import java.util.UUID;
|
|
+
|
|
+public class CraftPlayerProfile implements PlayerProfile {
|
|
+
|
|
+ private GameProfile profile;
|
|
+ private final PropertySet properties = new PropertySet();
|
|
+
|
|
+ public CraftPlayerProfile(CraftPlayer player) {
|
|
+ this.profile = player.getHandle().getProfile();
|
|
+ }
|
|
+
|
|
+ public CraftPlayerProfile(UUID id, String name) {
|
|
+ this.profile = createGameProfile(id, name);
|
|
+ }
|
|
+
|
|
+ public CraftPlayerProfile(GameProfile profile) {
|
|
+ this.profile = profile;
|
|
+ }
|
|
+
|
|
+ private static GameProfile createGameProfile(UUID id, String name) {
|
|
+ new GameProfile(id, name); // Validate that both are not null
|
|
+ MinecraftServer server = MinecraftServer.getServer();
|
|
+ UserCache userCache = server.getUserCache();
|
|
+ GameProfile profile;
|
|
+
|
|
+ if (id == null) {
|
|
+ profile = getProfileByName(name);
|
|
+ if (profile != null) {
|
|
+ id = profile.getId();
|
|
+ }
|
|
+ } else {
|
|
+ profile = userCache.getProfile(id);
|
|
+ if (profile != null) {
|
|
+ name = profile.getName();
|
|
+ }
|
|
+ }
|
|
+
|
|
+ GameProfile resultProfile = new GameProfile(id, name);
|
|
+ if (profile != null) {
|
|
+ copyProfileProperties(profile, resultProfile);
|
|
+ }
|
|
+ return resultProfile;
|
|
+ }
|
|
+
|
|
+ private static GameProfile getProfileByName(String name) {
|
|
+ final GameProfile profile;
|
|
+ final MinecraftServer server = MinecraftServer.getServer();
|
|
+ boolean isOnlineMode = server.getOnlineMode() || (SpigotConfig.bungee && PaperConfig.bungeeOnlineMode);
|
|
+ if (isOnlineMode) {
|
|
+ profile = server.getUserCache().getProfile(name);
|
|
+ } else {
|
|
+ // Make an OfflinePlayer using an offline mode UUID since the name has no profile
|
|
+ profile = new GameProfile(UUID.nameUUIDFromBytes(("OfflinePlayer:" + name).getBytes(Charsets.UTF_8)), name);
|
|
+ }
|
|
+ return profile;
|
|
+ }
|
|
+
|
|
+ private static void copyProfileProperties(GameProfile source, GameProfile target) {
|
|
+ PropertyMap properties = target.getProperties();
|
|
+ properties.clear();
|
|
+ for (Property property : source.getProperties().values()) {
|
|
+ properties.put(property.getName(), property);
|
|
+ }
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public boolean hasProperty(String property) {
|
|
+ return profile.getProperties().containsKey(property);
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public void setProperty(ProfileProperty property) {
|
|
+ String name = property.getName();
|
|
+ PropertyMap properties = profile.getProperties();
|
|
+ properties.removeAll(name);
|
|
+ properties.put(name, new Property(name, property.getValue(), property.getSignature()));
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public void setProperties(Collection<ProfileProperty> properties) {
|
|
+ properties.forEach(this::setProperty);
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public boolean removeProperty(String property) {
|
|
+ return !profile.getProperties().removeAll(property).isEmpty();
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public void clearProperties() {
|
|
+ profile.getProperties().clear();
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public boolean isComplete() {
|
|
+ return profile.isComplete();
|
|
+ }
|
|
+
|
|
+ public boolean complete(boolean textures) {
|
|
+ MinecraftServer server = MinecraftServer.getServer();
|
|
+ String name = profile.getName();
|
|
+ if (profile.getId() == null) {
|
|
+ profile = getProfileByName(name);
|
|
+ if (profile == null) {
|
|
+ throw new NullPointerException("Could not get UUID for Player " + name);
|
|
+ }
|
|
+ }
|
|
+ if (!profile.isComplete() || (textures && !hasTextures())) {
|
|
+ GameProfile result = server.getSessionService().fillProfileProperties(profile, true);
|
|
+ if (result != null) {
|
|
+ this.profile = result;
|
|
+ }
|
|
+ }
|
|
+ return profile.isComplete() && (!textures || hasTextures());
|
|
+ }
|
|
+
|
|
+ private static ProfileProperty toBukkit(Property property) {
|
|
+ return new ProfileProperty(property.getName(), property.getValue(), property.getSignature());
|
|
+ }
|
|
+
|
|
+ public static PlayerProfile asBukkitCopy(GameProfile gameProfile) {
|
|
+ CraftPlayerProfile profile = new CraftPlayerProfile(gameProfile.getId(), gameProfile.getName());
|
|
+ copyProfileProperties(gameProfile, profile.profile);
|
|
+ return profile;
|
|
+ }
|
|
+
|
|
+ public static PlayerProfile asBukkitMirror(GameProfile profile) {
|
|
+ return new CraftPlayerProfile(profile);
|
|
+ }
|
|
+
|
|
+ public static Property asAuthlib(ProfileProperty property) {
|
|
+ return new Property(property.getName(), property.getValue(), property.getSignature());
|
|
+ }
|
|
+ public static GameProfile asAuthlibCopy(PlayerProfile profile) {
|
|
+ CraftPlayerProfile craft = ((CraftPlayerProfile) profile);
|
|
+ return asAuthlib(craft.clone());
|
|
+ }
|
|
+
|
|
+ public static GameProfile asAuthlib(PlayerProfile profile) {
|
|
+ CraftPlayerProfile craft = ((CraftPlayerProfile) profile);
|
|
+ return craft.getGameProfile();
|
|
+ }
|
|
+
|
|
+
|
|
+ public GameProfile getGameProfile() {
|
|
+ return profile;
|
|
+ }
|
|
+
|
|
+ @Nullable
|
|
+ @Override
|
|
+ public UUID getId() {
|
|
+ return profile.getId();
|
|
+ }
|
|
+
|
|
+ @Nonnull
|
|
+ @Override
|
|
+ public Set<ProfileProperty> getProperties() {
|
|
+ return properties;
|
|
+ }
|
|
+
|
|
+ @Nullable
|
|
+ @Override
|
|
+ public String getName() {
|
|
+ return profile.getName();
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public boolean equals(Object o) {
|
|
+ return profile.equals(o);
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public int hashCode() {
|
|
+ return profile.hashCode();
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public String toString() {
|
|
+ return profile.toString();
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public CraftPlayerProfile clone() {
|
|
+ CraftPlayerProfile clone = new CraftPlayerProfile(this.getId(), this.getName());
|
|
+ clone.setProperties(getProperties());
|
|
+ return clone;
|
|
+ }
|
|
+
|
|
+
|
|
+ private class PropertySet extends AbstractSet<ProfileProperty> {
|
|
+
|
|
+ @Override
|
|
+ @Nonnull
|
|
+ public Iterator<ProfileProperty> iterator() {
|
|
+ return new ProfilePropertyIterator(profile.getProperties().values().iterator());
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public int size() {
|
|
+ return profile.getProperties().size();
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public boolean add(ProfileProperty property) {
|
|
+ setProperty(property);
|
|
+ return true;
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public boolean addAll(Collection<? extends ProfileProperty> c) {
|
|
+ //noinspection unchecked
|
|
+ setProperties((Collection<ProfileProperty>) c);
|
|
+ return true;
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public boolean contains(Object o) {
|
|
+ return o instanceof ProfileProperty && profile.getProperties().containsKey(((ProfileProperty) o).getName());
|
|
+ }
|
|
+
|
|
+ private class ProfilePropertyIterator implements Iterator<ProfileProperty> {
|
|
+ private final Iterator<Property> iterator;
|
|
+
|
|
+ ProfilePropertyIterator(Iterator<Property> iterator) {
|
|
+ this.iterator = iterator;
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public boolean hasNext() {
|
|
+ return iterator.hasNext();
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public ProfileProperty next() {
|
|
+ return toBukkit(iterator.next());
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public void remove() {
|
|
+ iterator.remove();
|
|
+ }
|
|
+ }
|
|
+ }
|
|
+}
|
|
diff --git a/src/main/java/net/minecraft/server/MCUtil.java b/src/main/java/net/minecraft/server/MCUtil.java
|
|
index 02940d697..4539b5601 100644
|
|
--- a/src/main/java/net/minecraft/server/MCUtil.java
|
|
+++ b/src/main/java/net/minecraft/server/MCUtil.java
|
|
@@ -1,6 +1,9 @@
|
|
package net.minecraft.server;
|
|
|
|
+import com.destroystokyo.paper.profile.CraftPlayerProfile;
|
|
+import com.destroystokyo.paper.profile.PlayerProfile;
|
|
import com.google.common.util.concurrent.ThreadFactoryBuilder;
|
|
+import com.mojang.authlib.GameProfile;
|
|
import org.apache.commons.lang.exception.ExceptionUtils;
|
|
import org.bukkit.Location;
|
|
import org.bukkit.craftbukkit.CraftWorld;
|
|
@@ -66,6 +69,10 @@ public final class MCUtil {
|
|
return run.get();
|
|
}
|
|
|
|
+ public static PlayerProfile toBukkit(GameProfile profile) {
|
|
+ return CraftPlayerProfile.asBukkitMirror(profile);
|
|
+ }
|
|
+
|
|
/**
|
|
* Calculates distance between 2 entities
|
|
* @param e1
|
|
diff --git a/src/main/java/net/minecraft/server/MinecraftServer.java b/src/main/java/net/minecraft/server/MinecraftServer.java
|
|
index e8bddc171..3b01ebd96 100644
|
|
--- a/src/main/java/net/minecraft/server/MinecraftServer.java
|
|
+++ b/src/main/java/net/minecraft/server/MinecraftServer.java
|
|
@@ -1538,6 +1538,7 @@ public abstract class MinecraftServer implements ICommandListener, Runnable, IAs
|
|
this.H = i;
|
|
}
|
|
|
|
+ public MinecraftSessionService getSessionService() { return az(); } // Paper - OBFHELPER
|
|
public MinecraftSessionService az() {
|
|
return this.W;
|
|
}
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/CraftServer.java b/src/main/java/org/bukkit/craftbukkit/CraftServer.java
|
|
index 77c16fe2c..2dd7ed96a 100644
|
|
--- a/src/main/java/org/bukkit/craftbukkit/CraftServer.java
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/CraftServer.java
|
|
@@ -135,6 +135,10 @@ import org.bukkit.craftbukkit.util.CraftNamespacedKey;
|
|
import org.bukkit.event.server.TabCompleteEvent;
|
|
import net.md_5.bungee.api.chat.BaseComponent;
|
|
|
|
+import javax.annotation.Nullable; // Paper
|
|
+import javax.annotation.Nonnull; // Paper
|
|
+
|
|
+
|
|
public final class CraftServer implements Server {
|
|
private final String serverName = "Paper";
|
|
private final String serverVersion;
|
|
@@ -1923,5 +1927,21 @@ public final class CraftServer implements Server {
|
|
public boolean suggestPlayerNamesWhenNullTabCompletions() {
|
|
return com.destroystokyo.paper.PaperConfig.suggestPlayersWhenNullTabCompletions;
|
|
}
|
|
+
|
|
+ public com.destroystokyo.paper.profile.PlayerProfile createProfile(@Nonnull UUID uuid) {
|
|
+ return createProfile(uuid, null);
|
|
+ }
|
|
+
|
|
+ public com.destroystokyo.paper.profile.PlayerProfile createProfile(@Nonnull String name) {
|
|
+ return createProfile(null, name);
|
|
+ }
|
|
+
|
|
+ public com.destroystokyo.paper.profile.PlayerProfile createProfile(@Nullable UUID uuid, @Nullable String name) {
|
|
+ Player player = uuid != null ? Bukkit.getPlayer(uuid) : (name != null ? Bukkit.getPlayerExact(name) : null);
|
|
+ if (player != null) {
|
|
+ return new com.destroystokyo.paper.profile.CraftPlayerProfile((CraftPlayer)player);
|
|
+ }
|
|
+ return new com.destroystokyo.paper.profile.CraftPlayerProfile(uuid, name);
|
|
+ }
|
|
// Paper end
|
|
}
|
|
--
|
|
2.16.2
|
|
|