c5a10665b8
Spigot still maintains some partial implementation of "tick skipping", a practice in which the MinecraftServer.currentTick field is updated not by an increment of one per actual tick, but instead set to System.currentTimeMillis() / 50. This behaviour means that the tracked tick may "skip" a tick value in case a previous tick took more than the expected 50ms. To compensate for this in important paths, spigot/craftbukkit implements "wall-time". Instead of incrementing/decrementing ticks on block entities/entities by one for each call to their tick() method, they instead increment/decrement important values, like an ItemEntity's age or pickupDelay, by the difference of `currentTick - lastTick`, where `lastTick` is the value of `currentTick` during the last tick() call. These "fixes" however do not play nicely with minecraft's simulation distance as entities/block entities implementing the above behaviour would "catch up" their values when moving from a non-ticking chunk to a ticking one as their `lastTick` value remains stuck on the last tick in a ticking chunk and hence lead to a large "catch up" once ticked again. Paper completely removes the "tick skipping" behaviour (See patch "Further-improve-server-tick-loop"), making the above precautions completely unnecessary, which also rids paper of the previous described incompatibility with non-ticking chunks.
25 Zeilen
1.2 KiB
Diff
25 Zeilen
1.2 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Shane Freeder <theboyetronic@gmail.com>
|
|
Date: Mon, 26 Apr 2021 01:27:08 +0100
|
|
Subject: [PATCH] Send empty commands if tab completion is disabled
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/commands/Commands.java b/src/main/java/net/minecraft/commands/Commands.java
|
|
index f52e9732524b62b0fecdc48e099163f31fe367b4..c5c9fb28fe858e2900e43f8aafccddf63f09676e 100644
|
|
--- a/src/main/java/net/minecraft/commands/Commands.java
|
|
+++ b/src/main/java/net/minecraft/commands/Commands.java
|
|
@@ -448,7 +448,12 @@ public class Commands {
|
|
}
|
|
|
|
public void sendCommands(ServerPlayer player) {
|
|
- if ( org.spigotmc.SpigotConfig.tabComplete < 0 ) return; // Spigot
|
|
+ // Paper start - Send empty commands if tab completion is disabled
|
|
+ if (org.spigotmc.SpigotConfig.tabComplete < 0) {
|
|
+ player.connection.send(new ClientboundCommandsPacket(new RootCommandNode<>()));
|
|
+ return;
|
|
+ }
|
|
+ // Paper end - Send empty commands if tab completion is disabled
|
|
// CraftBukkit start
|
|
// Register Vanilla commands into builtRoot as before
|
|
// Paper start - Perf: Async command map building
|