ea855e2b46
Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Developers!: You will need to clean up your work/Minecraft/1.13.2 folder for this Also, restore a patch that was dropped in the last upstream Bukkit Changes: 279eeab3 Fix command description not being set 96e2bb18 Remove debug print from SyntheticEventTest CraftBukkit Changes:d3ed1516Fix dangerously threaded beacons217a293dDon't relocate joptsimple to allow --help to work.1be05a21Prepare for imminent Java 12 releasea49270b2Mappings Update5259d80cSPIGOT-4669: Fix PlayerTeleportEvent coordinates for relative teleports Spigot Changes: e6eb36f2 Rebuild patches
51 Zeilen
2.6 KiB
Diff
51 Zeilen
2.6 KiB
Diff
From 5554a8ccf3d8199dea0a55f4104cd265c4d39b06 Mon Sep 17 00:00:00 2001
|
|
From: Zach Brown <zach@zachbr.io>
|
|
Date: Thu, 31 Jan 2019 16:33:36 -0500
|
|
Subject: [PATCH] Fire BlockPistonRetractEvent for all empty pistons
|
|
|
|
There is an explicit check in the handling code for empty pistons that
|
|
prevents sticky pistons from firing the event. However when we look back
|
|
at the history we see that this check was originally added so that ONLY
|
|
sticky pistons would fire the retract event. I'm not sure why.
|
|
https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/commits/1092acbddf07edfa4100bc6824504ac75088e913
|
|
|
|
Over the course of several updates, the meaning of that field appears to
|
|
have changed from "is NOT sticky" to "is sticky". So now its having the
|
|
opposite effect. Only normal pistons fire the retraction event. And like
|
|
all things in CB, it's just been carried around since.
|
|
|
|
If we are to believe the history, the correct fix for this issue is to
|
|
flip it so it only fires for sticky pistons, but that puts us in a
|
|
bind. It's already firing for non-sticky pistons, changing it now would
|
|
likely result in breakage. Furthermore, there is little documentation as
|
|
to WHY that was ever intended to be the case.
|
|
|
|
Instead we opt to remove the check entirely so that the event fires for
|
|
all piston types.
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/BlockPiston.java b/src/main/java/net/minecraft/server/BlockPiston.java
|
|
index dbe0ff33a..0109484e0 100644
|
|
--- a/src/main/java/net/minecraft/server/BlockPiston.java
|
|
+++ b/src/main/java/net/minecraft/server/BlockPiston.java
|
|
@@ -118,7 +118,7 @@ public class BlockPiston extends BlockDirectional {
|
|
}
|
|
|
|
// CraftBukkit start
|
|
- if (!this.sticky) {
|
|
+ //if (!this.sticky) { // Paper - Prevents empty sticky pistons from firing retract - history behind is odd
|
|
org.bukkit.block.Block block = world.getWorld().getBlockAt(blockposition.getX(), blockposition.getY(), blockposition.getZ());
|
|
BlockPistonRetractEvent event = new BlockPistonRetractEvent(block, ImmutableList.<org.bukkit.block.Block>of(), CraftBlock.notchToBlockFace(enumdirection));
|
|
world.getServer().getPluginManager().callEvent(event);
|
|
@@ -126,7 +126,7 @@ public class BlockPiston extends BlockDirectional {
|
|
if (event.isCancelled()) {
|
|
return;
|
|
}
|
|
- }
|
|
+ //} // Paper
|
|
// PAIL: checkME - what happened to setTypeAndData?
|
|
// CraftBukkit end
|
|
world.playBlockAction(blockposition, this, b0, enumdirection.a());
|
|
--
|
|
2.21.0
|
|
|