deb92c2129
* Add new patches * Change from an EMPTY static var to a static method since ItemStack is mutable * Properly set nullability of return value * Move annotation changes to different patch * Send the Kotlin code back to where it came from * rebased --------- Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com>
32 Zeilen
1.4 KiB
Diff
32 Zeilen
1.4 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Aeltumn <daniel@goossens.ch>
|
|
Date: Mon, 28 Aug 2023 13:44:09 +0200
|
|
Subject: [PATCH] Allow proper checking of empty item stacks
|
|
|
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/inventory/CraftItemStack.java b/src/main/java/org/bukkit/craftbukkit/inventory/CraftItemStack.java
|
|
index 0e5abd2a8694b24d4077a602a544e9c2b4c31822..6556d7ab09826bb5a99f11385eddc26b67e44d68 100644
|
|
--- a/src/main/java/org/bukkit/craftbukkit/inventory/CraftItemStack.java
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/inventory/CraftItemStack.java
|
|
@@ -33,12 +33,19 @@ public final class CraftItemStack extends ItemStack {
|
|
}
|
|
// Paper end - MC Utils
|
|
|
|
+ // Paper start - override isEmpty to use vanilla's impl
|
|
+ @Override
|
|
+ public boolean isEmpty() {
|
|
+ return handle == null || handle.isEmpty();
|
|
+ }
|
|
+ // Paper end
|
|
+
|
|
public static net.minecraft.world.item.ItemStack asNMSCopy(ItemStack original) {
|
|
if (original instanceof CraftItemStack) {
|
|
CraftItemStack stack = (CraftItemStack) original;
|
|
return stack.handle == null ? net.minecraft.world.item.ItemStack.EMPTY : stack.handle.copy();
|
|
}
|
|
- if (original == null || original.getType() == Material.AIR) {
|
|
+ if (original == null || original.isEmpty()) { // Paper - use isEmpty
|
|
return net.minecraft.world.item.ItemStack.EMPTY;
|
|
}
|
|
|