2873869bb1
Signs no longer have a specific isEdiable state, the entire API in this regard needs updating/deprecation. The boolean field is completely gone, replaced by a uuid (which will need a new setEditingPlayer(UUID) method on the Sign interface), and the current upstream implementation of setEdiable simply flips the is_waxed state. This patch is hence not needed as it neither allows editing (which will be redone in a later patch) nor is required to copy the is_waxed boolean flag as it lives in the signs compound tag and is covered by applyTo.
36 Zeilen
1.8 KiB
Diff
36 Zeilen
1.8 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: braindead <totsuka.sama@gmail.com>
|
|
Date: Sat, 5 Nov 2022 17:47:26 -0400
|
|
Subject: [PATCH] fix MC-252817 (green map markers do not disappear).
|
|
|
|
this bug is caused by the fact that the itemframe's item is set to empty before the green marker is requested to be removed. this is fixed by getting the mapid from this method's parameter, rather than the air block now stored by the item frame.
|
|
|
|
diff --git a/src/main/java/net/minecraft/world/entity/decoration/ItemFrame.java b/src/main/java/net/minecraft/world/entity/decoration/ItemFrame.java
|
|
index a86472cce8e8fcde16d761842fe443a619f6e305..955316687e2e29ad75a0052317a7b0f89034c82a 100644
|
|
--- a/src/main/java/net/minecraft/world/entity/decoration/ItemFrame.java
|
|
+++ b/src/main/java/net/minecraft/world/entity/decoration/ItemFrame.java
|
|
@@ -288,7 +288,9 @@ public class ItemFrame extends HangingEntity {
|
|
}
|
|
|
|
private void removeFramedMap(ItemStack itemstack) {
|
|
- this.getFramedMapId().ifPresent((i) -> {
|
|
+ // Paper start - fix MC-252817 (green map markers do not disappear)
|
|
+ this.getFramedMapIdFromItem(itemstack).ifPresent((i) -> {
|
|
+ // Paper end
|
|
MapItemSavedData worldmap = MapItem.getSavedData(i, this.level());
|
|
|
|
if (worldmap != null) {
|
|
@@ -306,7 +308,12 @@ public class ItemFrame extends HangingEntity {
|
|
|
|
public OptionalInt getFramedMapId() {
|
|
ItemStack itemstack = this.getItem();
|
|
+ // Paper start - fix MC-252817 (green map markers do not disappear)
|
|
+ return this.getFramedMapIdFromItem(itemstack);
|
|
+ }
|
|
|
|
+ public OptionalInt getFramedMapIdFromItem(ItemStack itemstack) {
|
|
+ // Paper end
|
|
if (itemstack.is(Items.FILLED_MAP)) {
|
|
Integer integer = MapItem.getMapId(itemstack);
|
|
|