f37381ea8a
Removes synchronization from sending packets
Makes normal packet sends no longer need to be wrapped and queued like it use to work.
Adds more packet queue immunities on top of keep alive to let the following scenarios go out
without delay:
- Keep Alive
- Chat
- Kick
- All of the packets during the Player Joined World event
Hoping that latter one helps join timeout issues more too for slow connections.
Removes processing packet queue off of main thread
- for the few cases where it is allowed, order is not necessary nor
should it even be happening concurrently in first place (handshaking/login/status)
Ensures packets sent asynchronously are dispatched on main thread
This helps ensure safety for ProtocolLib as packet listeners
are commonly accessing world state. This will allow you to schedule
a packet to be sent async, but itll be dispatched sync for packet
listeners to process.
This should solve some deadlock risks
This may provide a decent performance improvement because thread synchronization incurs a cache reset
so by avoiding ever entering a synchronized block, we get to avoid that, and packet sending is a really
hot activity.
27 Zeilen
1.1 KiB
Diff
27 Zeilen
1.1 KiB
Diff
From 1343b255a498178e51b1e1b27912225821add7a1 Mon Sep 17 00:00:00 2001
|
|
From: AvrooVulcan <avrovulcan.programming@gmail.com>
|
|
Date: Fri, 17 Apr 2020 00:15:23 +0100
|
|
Subject: [PATCH] Broadcast join message to console
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/PlayerList.java b/src/main/java/net/minecraft/server/PlayerList.java
|
|
index 62891d2dc6f..e79a4d9ff80 100644
|
|
--- a/src/main/java/net/minecraft/server/PlayerList.java
|
|
+++ b/src/main/java/net/minecraft/server/PlayerList.java
|
|
@@ -188,9 +188,9 @@ public abstract class PlayerList {
|
|
joinMessage = playerJoinEvent.getJoinMessage();
|
|
|
|
if (joinMessage != null && joinMessage.length() > 0) {
|
|
- for (IChatBaseComponent line : org.bukkit.craftbukkit.util.CraftChatMessage.fromString(joinMessage)) {
|
|
- server.getPlayerList().sendAll(new PacketPlayOutChat(line));
|
|
- }
|
|
+ // Paper start - Removed sendAll for loop and broadcasted to console also
|
|
+ server.getPlayerList().sendMessage(CraftChatMessage.fromString(joinMessage));
|
|
+ // Paper end
|
|
}
|
|
// CraftBukkit end
|
|
|
|
--
|
|
2.26.2
|
|
|