ac554ad46d
Updated Upstream (Bukkit/CraftBukkit) Upstream has released updates that appear to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Bukkit Changes: fa99e752 PR-1007: Add ItemMeta#getAsComponentString() 94a91782 Fix copy-pasted BlockType.Typed documentation 9b34ac8c Largely restore deprecated PotionData API 51a6449b PR-1008: Deprecate ITEMS_TOOLS, removed in 1.20.5 702d15fe Fix Javadoc reference 42f6cdf4 PR-919: Add internal ItemType and BlockType, delegate Material methods to them 237bb37b SPIGOT-1166, SPIGOT-7647: Expose Damager BlockState in EntityDamageByBlockEvent 035ea146 SPIGOT-6993: Allow #setVelocity to change the speed of a fireball and add a note to #setDirection about it 8c7880fb PR-1004: Improve field rename handling and centralize conversion between bukkit and string more 87c90e93 SPIGOT-7650: Add DamageSource for EntityDeathEvent and PlayerDeathEvent CraftBukkit Changes: 4af0f22e8 SPIGOT-7664: Item meta should prevail over block states c2ccc46ec SPIGOT-7666: Fix access to llama and horse special slot 124ac66d7 SPIGOT-7665: Fix ThrownPotion#getEffects() implementation only bringing custom effects 66f1f439a Restore null page behaviour of signed books even though not strictly allowed by API 6118e5398 Fix regression listening to minecraft:brand custom payloads c1a26b366 Fix unnecessary and potential not thread-safe chat visibility check 12360a7ec Remove unused imports 147b098b4 PR-1397: Add ItemMeta#getAsComponentString() 428aefe0e Largely restore deprecated PotionData API afe5b5ee9 PR-1275: Add internal ItemType and BlockType, delegate Material methods to them 8afeafa7d SPIGOT-1166, SPIGOT-7647: Expose Damager BlockState in EntityDamageByBlockEvent 4e7d749d4 SPIGOT-6993: Allow #setVelocity to change the speed of a fireball and add a note to #setDirection about it 441880757 Support both entity_data and bucket_entity_data on axolotl/fish buckets 0e22fdd1e Fix custom direct BlockState being not correctly set in DamageSource f2182ed47 SPIGOT-7659: TropicalFishBucketMeta should use BUCKET_ENTITY_DATA 2a6207fe1 PR-1393: Improve field rename handling and centralize conversion between bukkit and string more c024a5039 SPIGOT-7650: Add DamageSource for EntityDeathEvent and PlayerDeathEvent 741b84480 PR-1390: Improve internal handling of damage sources 0364df4e1 SPIGOT-7657: Error when loading angry entities
67 Zeilen
2.8 KiB
Diff
67 Zeilen
2.8 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Jake Potrebic <jake.m.potrebic@gmail.com>
|
|
Date: Sat, 27 Apr 2024 13:28:17 -0700
|
|
Subject: [PATCH] Fix ItemFlags
|
|
|
|
Adds new flag in HIDE_STORED_ENCHANTS which was split
|
|
from HIDE_ADDITIONAL_INFO. Adds a migration to account for
|
|
this, adding the new flag if the itemstack is old and had the
|
|
old flag.
|
|
|
|
diff --git a/src/main/java/org/bukkit/inventory/ItemFlag.java b/src/main/java/org/bukkit/inventory/ItemFlag.java
|
|
index a435f6c8947e4ac50b8c04f37b107055970937dd..92e30c281eab4801298b280bd388a0399212a0c1 100644
|
|
--- a/src/main/java/org/bukkit/inventory/ItemFlag.java
|
|
+++ b/src/main/java/org/bukkit/inventory/ItemFlag.java
|
|
@@ -2,6 +2,8 @@ package org.bukkit.inventory;
|
|
|
|
/**
|
|
* A ItemFlag can hide some Attributes from ItemStacks
|
|
+ * @apiNote Setting these without also setting the data they are hiding
|
|
+ * may not result in the item flag being persisted in the ItemMeta/ItemStack.
|
|
*/
|
|
public enum ItemFlag {
|
|
|
|
@@ -27,7 +29,8 @@ public enum ItemFlag {
|
|
HIDE_PLACED_ON,
|
|
/**
|
|
* Setting to show/hide potion effects, book and firework information, map
|
|
- * tooltips, patterns of banners, and enchantments of enchanted books.
|
|
+ * tooltips, patterns of banners.
|
|
+ * @see #HIDE_STORED_ENCHANTS HIDE_STORED_ENCHANTS for hiding stored enchants (like on enchanted books)
|
|
*/
|
|
HIDE_ADDITIONAL_TOOLTIP,
|
|
/**
|
|
@@ -37,7 +40,13 @@ public enum ItemFlag {
|
|
/**
|
|
* Setting to show/hide armor trim from armor.
|
|
*/
|
|
- HIDE_ARMOR_TRIM;
|
|
+ HIDE_ARMOR_TRIM,
|
|
+ /**
|
|
+ * Setting to show/hide stored enchants on an item, such as enchantments
|
|
+ * on an enchanted book.
|
|
+ */
|
|
+ HIDE_STORED_ENCHANTS,
|
|
+ ;
|
|
// Paper start
|
|
/**
|
|
* Setting to show/hide item-specific information, including, but not limited to:
|
|
diff --git a/src/main/java/org/bukkit/inventory/ItemStack.java b/src/main/java/org/bukkit/inventory/ItemStack.java
|
|
index 4818b4e6583414fa98194bb6f3c5dbd4bd95be3a..c64413a6740b604282984dea2a8430a6e7478d68 100644
|
|
--- a/src/main/java/org/bukkit/inventory/ItemStack.java
|
|
+++ b/src/main/java/org/bukkit/inventory/ItemStack.java
|
|
@@ -581,6 +581,13 @@ public class ItemStack implements Cloneable, ConfigurationSerializable, Translat
|
|
Object raw = args.get("meta");
|
|
if (raw instanceof ItemMeta) {
|
|
((ItemMeta) raw).setVersion(version);
|
|
+ // Paper start - for pre 1.20.5 itemstacks, add HIDE_STORED_ENCHANTS flag if HIDE_ADDITIONAL_TOOLTIP is set
|
|
+ if (version < 3837) { // 1.20.5
|
|
+ if (((ItemMeta) raw).hasItemFlag(ItemFlag.HIDE_ADDITIONAL_TOOLTIP)) {
|
|
+ ((ItemMeta) raw).addItemFlags(ItemFlag.HIDE_STORED_ENCHANTS);
|
|
+ }
|
|
+ }
|
|
+ // Paper end
|
|
result.setItemMeta((ItemMeta) raw);
|
|
}
|
|
}
|