Fix bug with hopper optimizations when amount > 3 - Closes #1011
Dieser Commit ist enthalten in:
Ursprung
094bb03a37
Commit
84b0287c54
@ -1,4 +1,4 @@
|
|||||||
From 699262240b7077607d2d221e980d4fd8e4c41f20 Mon Sep 17 00:00:00 2001
|
From 6844a109b190cc39435a670157ab245ad8960fc9 Mon Sep 17 00:00:00 2001
|
||||||
From: Aikar <aikar@aikar.co>
|
From: Aikar <aikar@aikar.co>
|
||||||
Date: Wed, 27 Apr 2016 22:09:52 -0400
|
Date: Wed, 27 Apr 2016 22:09:52 -0400
|
||||||
Subject: [PATCH] Optimize Hoppers
|
Subject: [PATCH] Optimize Hoppers
|
||||||
@ -60,10 +60,10 @@ index 8e2d55a73..fe2df18df 100644
|
|||||||
|
|
||||||
this.g = iblockdata.getBlock().toLegacyData(iblockdata);
|
this.g = iblockdata.getBlock().toLegacyData(iblockdata);
|
||||||
diff --git a/src/main/java/net/minecraft/server/TileEntityHopper.java b/src/main/java/net/minecraft/server/TileEntityHopper.java
|
diff --git a/src/main/java/net/minecraft/server/TileEntityHopper.java b/src/main/java/net/minecraft/server/TileEntityHopper.java
|
||||||
index e9315f2d5..6ec292714 100644
|
index e9315f2d5..5198a590a 100644
|
||||||
--- a/src/main/java/net/minecraft/server/TileEntityHopper.java
|
--- a/src/main/java/net/minecraft/server/TileEntityHopper.java
|
||||||
+++ b/src/main/java/net/minecraft/server/TileEntityHopper.java
|
+++ b/src/main/java/net/minecraft/server/TileEntityHopper.java
|
||||||
@@ -196,6 +196,153 @@ public class TileEntityHopper extends TileEntityLootable implements IHopper, ITi
|
@@ -196,6 +196,154 @@ public class TileEntityHopper extends TileEntityLootable implements IHopper, ITi
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -94,11 +94,11 @@ index e9315f2d5..6ec292714 100644
|
|||||||
+ return false;
|
+ return false;
|
||||||
+ }
|
+ }
|
||||||
+ }
|
+ }
|
||||||
+ final ItemStack itemstack1 = addItem(this, iinventory, itemstack, enumdirection);
|
+ final ItemStack itemstack2 = addItem(this, iinventory, itemstack, enumdirection);
|
||||||
+
|
+ final int remaining = itemstack2.getCount();
|
||||||
+ if (itemstack1.isEmpty()) {
|
+ if (remaining != moved) {
|
||||||
+ origItemStack = origItemStack.cloneItemStack();
|
+ origItemStack = origItemStack.cloneItemStack();
|
||||||
+ origItemStack.setCount(origCount - moved);
|
+ origItemStack.setCount(origCount - moved + remaining);
|
||||||
+ this.setItem(i, origItemStack);
|
+ this.setItem(i, origItemStack);
|
||||||
+ iinventory.update();
|
+ iinventory.update();
|
||||||
+ return true;
|
+ return true;
|
||||||
@ -132,9 +132,10 @@ index e9315f2d5..6ec292714 100644
|
|||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ final ItemStack itemstack2 = addItem(iinventory, ihopper, itemstack, null);
|
+ final ItemStack itemstack2 = addItem(iinventory, ihopper, itemstack, null);
|
||||||
+ if (itemstack2.isEmpty()) {
|
+ final int remaining = itemstack2.getCount();
|
||||||
|
+ if (remaining != moved) {
|
||||||
+ origItemStack = origItemStack.cloneItemStack();
|
+ origItemStack = origItemStack.cloneItemStack();
|
||||||
+ origItemStack.setCount(origCount - moved);
|
+ origItemStack.setCount(origCount - moved + remaining);
|
||||||
+ IGNORE_TILE_UPDATES = true;
|
+ IGNORE_TILE_UPDATES = true;
|
||||||
+ iinventory.setItem(i, origItemStack);
|
+ iinventory.setItem(i, origItemStack);
|
||||||
+ IGNORE_TILE_UPDATES = false;
|
+ IGNORE_TILE_UPDATES = false;
|
||||||
@ -217,7 +218,7 @@ index e9315f2d5..6ec292714 100644
|
|||||||
private boolean s() {
|
private boolean s() {
|
||||||
IInventory iinventory = this.I();
|
IInventory iinventory = this.I();
|
||||||
|
|
||||||
@@ -207,6 +354,7 @@ public class TileEntityHopper extends TileEntityLootable implements IHopper, ITi
|
@@ -207,6 +355,7 @@ public class TileEntityHopper extends TileEntityLootable implements IHopper, ITi
|
||||||
if (this.a(iinventory, enumdirection)) {
|
if (this.a(iinventory, enumdirection)) {
|
||||||
return false;
|
return false;
|
||||||
} else {
|
} else {
|
||||||
@ -225,7 +226,7 @@ index e9315f2d5..6ec292714 100644
|
|||||||
for (int i = 0; i < this.getSize(); ++i) {
|
for (int i = 0; i < this.getSize(); ++i) {
|
||||||
if (!this.getItem(i).isEmpty()) {
|
if (!this.getItem(i).isEmpty()) {
|
||||||
ItemStack itemstack = this.getItem(i).cloneItemStack();
|
ItemStack itemstack = this.getItem(i).cloneItemStack();
|
||||||
@@ -248,7 +396,7 @@ public class TileEntityHopper extends TileEntityLootable implements IHopper, ITi
|
@@ -248,7 +397,7 @@ public class TileEntityHopper extends TileEntityLootable implements IHopper, ITi
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -234,7 +235,7 @@ index e9315f2d5..6ec292714 100644
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -326,6 +474,7 @@ public class TileEntityHopper extends TileEntityLootable implements IHopper, ITi
|
@@ -326,6 +475,7 @@ public class TileEntityHopper extends TileEntityLootable implements IHopper, ITi
|
||||||
if (b(iinventory, enumdirection)) {
|
if (b(iinventory, enumdirection)) {
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
@ -242,7 +243,7 @@ index e9315f2d5..6ec292714 100644
|
|||||||
|
|
||||||
if (iinventory instanceof IWorldInventory) {
|
if (iinventory instanceof IWorldInventory) {
|
||||||
IWorldInventory iworldinventory = (IWorldInventory) iinventory;
|
IWorldInventory iworldinventory = (IWorldInventory) iinventory;
|
||||||
@@ -368,6 +517,7 @@ public class TileEntityHopper extends TileEntityLootable implements IHopper, ITi
|
@@ -368,6 +518,7 @@ public class TileEntityHopper extends TileEntityLootable implements IHopper, ITi
|
||||||
ItemStack itemstack = iinventory.getItem(i);
|
ItemStack itemstack = iinventory.getItem(i);
|
||||||
|
|
||||||
if (!itemstack.isEmpty() && b(iinventory, itemstack, i, enumdirection)) {
|
if (!itemstack.isEmpty() && b(iinventory, itemstack, i, enumdirection)) {
|
||||||
@ -250,7 +251,7 @@ index e9315f2d5..6ec292714 100644
|
|||||||
ItemStack itemstack1 = itemstack.cloneItemStack();
|
ItemStack itemstack1 = itemstack.cloneItemStack();
|
||||||
// ItemStack itemstack2 = addItem(iinventory, ihopper, iinventory.splitStack(i, 1), (EnumDirection) null);
|
// ItemStack itemstack2 = addItem(iinventory, ihopper, iinventory.splitStack(i, 1), (EnumDirection) null);
|
||||||
// CraftBukkit start - Call event on collection of items from inventories into the hopper
|
// CraftBukkit start - Call event on collection of items from inventories into the hopper
|
||||||
@@ -408,7 +558,7 @@ public class TileEntityHopper extends TileEntityLootable implements IHopper, ITi
|
@@ -408,7 +559,7 @@ public class TileEntityHopper extends TileEntityLootable implements IHopper, ITi
|
||||||
}
|
}
|
||||||
|
|
||||||
itemstack1.subtract(origCount - itemstack2.getCount()); // Spigot
|
itemstack1.subtract(origCount - itemstack2.getCount()); // Spigot
|
||||||
@ -259,7 +260,7 @@ index e9315f2d5..6ec292714 100644
|
|||||||
}
|
}
|
||||||
|
|
||||||
return false;
|
return false;
|
||||||
@@ -422,7 +572,7 @@ public class TileEntityHopper extends TileEntityLootable implements IHopper, ITi
|
@@ -422,7 +573,7 @@ public class TileEntityHopper extends TileEntityLootable implements IHopper, ITi
|
||||||
return false;
|
return false;
|
||||||
} else {
|
} else {
|
||||||
// CraftBukkit start
|
// CraftBukkit start
|
||||||
@ -268,7 +269,7 @@ index e9315f2d5..6ec292714 100644
|
|||||||
entityitem.world.getServer().getPluginManager().callEvent(event);
|
entityitem.world.getServer().getPluginManager().callEvent(event);
|
||||||
if (event.isCancelled()) {
|
if (event.isCancelled()) {
|
||||||
return false;
|
return false;
|
||||||
@@ -477,7 +627,9 @@ public class TileEntityHopper extends TileEntityLootable implements IHopper, ITi
|
@@ -477,7 +628,9 @@ public class TileEntityHopper extends TileEntityLootable implements IHopper, ITi
|
||||||
boolean flag1 = iinventory1.x_();
|
boolean flag1 = iinventory1.x_();
|
||||||
|
|
||||||
if (itemstack1.isEmpty()) {
|
if (itemstack1.isEmpty()) {
|
||||||
|
In neuem Issue referenzieren
Einen Benutzer sperren