Paper-Old/Spigot-Server-Patches/0388-MC-114618-Fix-EntityAreaEffectCloud-from-going-negat.patch

From 4eadaf6901010d0f29d2a1e8705c28a07d454e8b Mon Sep 17 00:00:00 2001
From: William Blake Galbreath <blake.galbreath@gmail.com>
Date: Mon, 27 May 2019 17:35:39 -0500
Subject: [PATCH] MC-114618 - Fix EntityAreaEffectCloud from going negative
 size


diff --git a/src/main/java/net/minecraft/server/EntityAreaEffectCloud.java b/src/main/java/net/minecraft/server/EntityAreaEffectCloud.java
index 3a8e105336..fe527aba52 100644
--- a/src/main/java/net/minecraft/server/EntityAreaEffectCloud.java
+++ b/src/main/java/net/minecraft/server/EntityAreaEffectCloud.java
@@ -175,6 +175,12 @@ public class EntityAreaEffectCloud extends Entity {
         super.tick();
         boolean flag = this.l();
         float f = this.getRadius();
+        // Paper start - fix MC-114618
+        if (f < 0.0F) {
+            this.die();
+            return;
+        }
+        // Paper end
 
         if (this.world.isClientSide) {
             ParticleParam particleparam = this.getParticle();
-- 
2.22.1
Async chunk api/io/loading (#2308) 2019-08-19 01:40:04 +02:00			`From 4eadaf6901010d0f29d2a1e8705c28a07d454e8b Mon Sep 17 00:00:00 2001`
MC-114618 - Fix EntityAreaEffectCloud from going negative size 2019-05-28 00:36:06 +02:00			`From: William Blake Galbreath <blake.galbreath@gmail.com>`
			`Date: Mon, 27 May 2019 17:35:39 -0500`
			`Subject: [PATCH] MC-114618 - Fix EntityAreaEffectCloud from going negative`
			`size`


			`diff --git a/src/main/java/net/minecraft/server/EntityAreaEffectCloud.java b/src/main/java/net/minecraft/server/EntityAreaEffectCloud.java`
Updated Upstream (Bukkit/CraftBukkit/Spigot) (#2415) * fixup patch and rebuild * Updated Upstream (Bukkit/CraftBukkit/Spigot) Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Bukkit Changes: bde198c9 SPIGOT-5246: PlayerQuitEvent.get/setQuitMessage() is incorrectly marked as NotNull 24ad5a79 SPIGOT-5240: Vector.angle not valid for angles very close to each other a143db9a SPIGOT-5231: ShotAtAngle API for Fireworks 10db5c3d SPIGOT-5226: Update Javadoc of PlayerDeathEvent CraftBukkit Changes: 1ec1b05e SPIGOT-5245: Unneeded cast to WorldNBTStorage in CraftWorld#getWorldFolder e5e8eec2 SPIGOT-5241: setAttributeModifiers does not work on untouched stack 803eaa31 SPIGOT-5231: ShotAtAngle API for Fireworks 7881d2ae SPIGOT-5237: Horses, pigs do not drop their inventory 06efc9ec Don't accept connections until all plugins have enabled da62a66a SPIGOT-5225: World handle isn't closed if world is unloaded without saving 104b3831 SPIGOT-5222: Cannot get Long values from Entity memory f0b3fe43 SPIGOT-5220: Server CPU usage reaches 100% when stdin is null Spigot Changes: e5b1b5db SPIGOT-5235: Destroy expired area effect clouds / fireworks that are inactive cbcc8e87 Make region files more reliable to write to 8887c5f4 Remove redundant late-bind option dac29063 Rebuild patches * Preserve old flush on save flag for reliable regionfiles Originally this patch was in paper * Fix some issues with the death event - Entities potentially entering a glitched state to the client where they appear to be falling over - Donkeys losing their chest if the event was cancelled (only an issue since the upstream merge) - Some wither death logic running for an entity killed by a wither 2019-08-05 18:35:40 +02:00			`index 3a8e105336..fe527aba52 100644`
MC-114618 - Fix EntityAreaEffectCloud from going negative size 2019-05-28 00:36:06 +02:00			`--- a/src/main/java/net/minecraft/server/EntityAreaEffectCloud.java`
			`+++ b/src/main/java/net/minecraft/server/EntityAreaEffectCloud.java`
Updated Upstream (Bukkit/CraftBukkit/Spigot) (#2415) * fixup patch and rebuild * Updated Upstream (Bukkit/CraftBukkit/Spigot) Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Bukkit Changes: bde198c9 SPIGOT-5246: PlayerQuitEvent.get/setQuitMessage() is incorrectly marked as NotNull 24ad5a79 SPIGOT-5240: Vector.angle not valid for angles very close to each other a143db9a SPIGOT-5231: ShotAtAngle API for Fireworks 10db5c3d SPIGOT-5226: Update Javadoc of PlayerDeathEvent CraftBukkit Changes: 1ec1b05e SPIGOT-5245: Unneeded cast to WorldNBTStorage in CraftWorld#getWorldFolder e5e8eec2 SPIGOT-5241: setAttributeModifiers does not work on untouched stack 803eaa31 SPIGOT-5231: ShotAtAngle API for Fireworks 7881d2ae SPIGOT-5237: Horses, pigs do not drop their inventory 06efc9ec Don't accept connections until all plugins have enabled da62a66a SPIGOT-5225: World handle isn't closed if world is unloaded without saving 104b3831 SPIGOT-5222: Cannot get Long values from Entity memory f0b3fe43 SPIGOT-5220: Server CPU usage reaches 100% when stdin is null Spigot Changes: e5b1b5db SPIGOT-5235: Destroy expired area effect clouds / fireworks that are inactive cbcc8e87 Make region files more reliable to write to 8887c5f4 Remove redundant late-bind option dac29063 Rebuild patches * Preserve old flush on save flag for reliable regionfiles Originally this patch was in paper * Fix some issues with the death event - Entities potentially entering a glitched state to the client where they appear to be falling over - Donkeys losing their chest if the event was cancelled (only an issue since the upstream merge) - Some wither death logic running for an entity killed by a wither 2019-08-05 18:35:40 +02:00			`@@ -175,6 +175,12 @@ public class EntityAreaEffectCloud extends Entity {`
MC-114618 - Fix EntityAreaEffectCloud from going negative size 2019-05-28 00:36:06 +02:00			`super.tick();`
			`boolean flag = this.l();`
			`float f = this.getRadius();`
			`+ // Paper start - fix MC-114618`
Rework fix for MC-114618 so not break map maker's workflow. Fixes #2221 2019-06-23 21:31:33 +02:00			`+ if (f < 0.0F) {`
MC-114618 - Fix EntityAreaEffectCloud from going negative size 2019-05-28 00:36:06 +02:00			`+ this.die();`
			`+ return;`
			`+ }`
			`+ // Paper end`

			`if (this.world.isClientSide) {`
			`ParticleParam particleparam = this.getParticle();`
			`--`
Async chunk api/io/loading (#2308) 2019-08-19 01:40:04 +02:00			`2.22.1`
MC-114618 - Fix EntityAreaEffectCloud from going negative size 2019-05-28 00:36:06 +02:00