2022-01-01 14:48:17 +01:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
From: Spottedleaf <Spottedleaf@users.noreply.github.com>
|
|
|
|
Date: Sat, 1 Jan 2022 05:19:37 -0800
|
|
|
|
Subject: [PATCH] Validate usernames
|
|
|
|
|
|
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/network/ServerLoginPacketListenerImpl.java b/src/main/java/net/minecraft/server/network/ServerLoginPacketListenerImpl.java
|
2022-06-09 10:51:45 +02:00
|
|
|
index dcabb783bed9160f7d602d551cf7e8d004abbca1..e581656c4450be708f1a91a42b5b1da9105df6f3 100644
|
2022-01-01 14:48:17 +01:00
|
|
|
--- a/src/main/java/net/minecraft/server/network/ServerLoginPacketListenerImpl.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/network/ServerLoginPacketListenerImpl.java
|
2022-06-09 10:51:45 +02:00
|
|
|
@@ -70,6 +70,7 @@ public class ServerLoginPacketListenerImpl implements ServerLoginPacketListener
|
2022-06-08 14:33:46 +02:00
|
|
|
private ProfilePublicKey playerProfilePublicKey;
|
2022-01-18 04:52:47 +01:00
|
|
|
public String hostname = ""; // CraftBukkit - add field
|
|
|
|
private int velocityLoginMessageId = -1; // Paper - Velocity support
|
|
|
|
+ public boolean iKnowThisMayNotBeTheBestIdeaButPleaseDisableUsernameValidation = false; // Paper - username validation overriding
|
|
|
|
|
|
|
|
public ServerLoginPacketListenerImpl(MinecraftServer server, Connection connection) {
|
|
|
|
this.state = ServerLoginPacketListenerImpl.State.HELLO;
|
2022-06-09 10:51:45 +02:00
|
|
|
@@ -262,10 +263,38 @@ public class ServerLoginPacketListenerImpl implements ServerLoginPacketListener
|
2022-06-08 14:33:46 +02:00
|
|
|
}
|
2022-01-01 14:48:17 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
+ // Paper start - validate usernames
|
|
|
|
+ public static boolean validateUsername(String in) {
|
|
|
|
+ if (in == null || in.isEmpty() || in.length() > 16) {
|
|
|
|
+ return false;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ for (int i = 0, len = in.length(); i < len; ++i) {
|
|
|
|
+ char c = in.charAt(i);
|
|
|
|
+
|
2022-01-01 20:50:44 +01:00
|
|
|
+ if ((c >= 'a' && c <= 'z') || (c >= 'A' && c <= 'Z') || (c >= '0' && c <= '9') || (c == '_' || c == '.')) {
|
2022-01-01 14:48:17 +01:00
|
|
|
+ continue;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ return false;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ return true;
|
|
|
|
+ }
|
|
|
|
+ // Paper end - validate usernames
|
|
|
|
+
|
|
|
|
@Override
|
|
|
|
public void handleHello(ServerboundHelloPacket packet) {
|
|
|
|
Validate.validState(this.state == ServerLoginPacketListenerImpl.State.HELLO, "Unexpected hello packet", new Object[0]);
|
2022-06-08 14:33:46 +02:00
|
|
|
Validate.validState(ServerLoginPacketListenerImpl.isValidUsername(packet.name()), "Invalid characters in username", new Object[0]);
|
2022-01-01 14:48:17 +01:00
|
|
|
+ // Paper start - validate usernames
|
2022-06-09 10:51:45 +02:00
|
|
|
+ if (io.papermc.paper.configuration.GlobalConfiguration.get().proxies.isProxyOnlineMode() && io.papermc.paper.configuration.GlobalConfiguration.get().unsupportedSettings.performUsernameValidation) {
|
2022-06-08 14:33:46 +02:00
|
|
|
+ if (!this.iKnowThisMayNotBeTheBestIdeaButPleaseDisableUsernameValidation && !validateUsername(packet.name())) {
|
2022-01-01 14:48:17 +01:00
|
|
|
+ ServerLoginPacketListenerImpl.this.disconnect("Failed to verify username!");
|
|
|
|
+ return;
|
|
|
|
+ }
|
|
|
|
+ }
|
|
|
|
+ // Paper end - validate usernames
|
2022-06-08 14:33:46 +02:00
|
|
|
|
|
|
|
try {
|
|
|
|
this.playerProfilePublicKey = ServerLoginPacketListenerImpl.validatePublicKey(packet, this.server.getServiceSignatureValidator(), this.server.enforceSecureProfile());
|
2022-01-01 14:48:17 +01:00
|
|
|
diff --git a/src/main/java/net/minecraft/server/players/PlayerList.java b/src/main/java/net/minecraft/server/players/PlayerList.java
|
2022-06-09 10:51:45 +02:00
|
|
|
index 6d013360d35c54d1493849b22c9d65b18147cc33..c0ed1103e649e619c58f59c7bedd6a18a58f71ea 100644
|
2022-01-01 14:48:17 +01:00
|
|
|
--- a/src/main/java/net/minecraft/server/players/PlayerList.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/players/PlayerList.java
|
2022-01-14 04:56:45 +01:00
|
|
|
@@ -707,7 +707,7 @@ public abstract class PlayerList {
|
2022-01-01 14:48:17 +01:00
|
|
|
|
|
|
|
for (int i = 0; i < this.players.size(); ++i) {
|
|
|
|
entityplayer = (ServerPlayer) this.players.get(i);
|
|
|
|
- if (entityplayer.getUUID().equals(uuid)) {
|
2022-06-09 10:51:45 +02:00
|
|
|
+ if (entityplayer.getUUID().equals(uuid) || (io.papermc.paper.configuration.GlobalConfiguration.get().proxies.isProxyOnlineMode() && entityplayer.getGameProfile().getName().equalsIgnoreCase(gameprofile.getName()))) { // Paper - validate usernames
|
2022-01-01 14:48:17 +01:00
|
|
|
list.add(entityplayer);
|
|
|
|
}
|
|
|
|
}
|