Paper-Old/Spigot-Server-Patches/0129-Optimize-World.isLoaded-BlockPosition-Z.patch

From 900048bc0a83882aa8c155c135a93c33851eba69 Mon Sep 17 00:00:00 2001
From: Aikar <aikar@aikar.co>
Date: Fri, 2 Dec 2016 00:11:43 -0500
Subject: [PATCH] Optimize World.isLoaded(BlockPosition)Z

Reduce method invocations for World.isLoaded(BlockPosition)Z

diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java
index 3305e110c..8ac081bef 100644
--- a/src/main/java/net/minecraft/server/World.java
+++ b/src/main/java/net/minecraft/server/World.java
@@ -209,6 +209,10 @@ public abstract class World implements IIBlockAccess, GeneratorAccess, AutoClose
         return i < 0 || i >= 256;
     }
 
+    public boolean isLoaded(BlockPosition blockposition) {
+        return getChunkIfLoaded(blockposition.getX() >> 4, blockposition.getZ() >> 4) != null; // Paper
+    }
+
     // Paper start
     public boolean isLoadedAndInBounds(BlockPosition blockposition) {
         return getWorldBorder().isInBounds(blockposition) && getChunkIfLoaded(blockposition.getX() >> 4, blockposition.getZ() >> 4) != null;
-- 
2.21.0
Fix patch "Faster redstone torch rapid clock removal" (#2014) Tux pointed out the patch still has O(n^2) time complexity since the sublist class in arraylist does not override clear() from AbstractList, which uses a forward moving iterator to clear the list. Resolved by using a peek and poll from ArrayDeque. This patch also removes the useless WeakHashMap which holds the list (it mapped world->list) and replaces it with a field on World. 2019-05-10 17:48:58 +02:00			`From 900048bc0a83882aa8c155c135a93c33851eba69 Mon Sep 17 00:00:00 2001`
NOT FINISHED! even more 1.13-pre patches! 2018-07-16 22:08:09 +02:00			`From: Aikar <aikar@aikar.co>`
			`Date: Fri, 2 Dec 2016 00:11:43 -0500`
			`Subject: [PATCH] Optimize World.isLoaded(BlockPosition)Z`

			`Reduce method invocations for World.isLoaded(BlockPosition)Z`

			`diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java`
Fix patch "Faster redstone torch rapid clock removal" (#2014) Tux pointed out the patch still has O(n^2) time complexity since the sublist class in arraylist does not override clear() from AbstractList, which uses a forward moving iterator to clear the list. Resolved by using a peek and poll from ArrayDeque. This patch also removes the useless WeakHashMap which holds the list (it mapped world->list) and replaces it with a field on World. 2019-05-10 17:48:58 +02:00			`index 3305e110c..8ac081bef 100644`
NOT FINISHED! even more 1.13-pre patches! 2018-07-16 22:08:09 +02:00			`--- a/src/main/java/net/minecraft/server/World.java`
			`+++ b/src/main/java/net/minecraft/server/World.java`
Fix patch "Faster redstone torch rapid clock removal" (#2014) Tux pointed out the patch still has O(n^2) time complexity since the sublist class in arraylist does not override clear() from AbstractList, which uses a forward moving iterator to clear the list. Resolved by using a peek and poll from ArrayDeque. This patch also removes the useless WeakHashMap which holds the list (it mapped world->list) and replaces it with a field on World. 2019-05-10 17:48:58 +02:00			`@@ -209,6 +209,10 @@ public abstract class World implements IIBlockAccess, GeneratorAccess, AutoClose`
More 1.14 work 2019-04-27 08:26:04 +02:00			`return i < 0 \|\| i >= 256;`
NOT FINISHED! even more 1.13-pre patches! 2018-07-16 22:08:09 +02:00			`}`

			`+ public boolean isLoaded(BlockPosition blockposition) {`
			`+ return getChunkIfLoaded(blockposition.getX() >> 4, blockposition.getZ() >> 4) != null; // Paper`
			`+ }`
			`+`
			`// Paper start`
Ensure mobs don't spawn out of world border this is originally what I thought #1333 was, but wasn't, but this is still valid fix 2018-09-18 03:50:02 +02:00			`public boolean isLoadedAndInBounds(BlockPosition blockposition) {`
			`return getWorldBorder().isInBounds(blockposition) && getChunkIfLoaded(blockposition.getX() >> 4, blockposition.getZ() >> 4) != null;`
NOT FINISHED! even more 1.13-pre patches! 2018-07-16 22:08:09 +02:00			`--`
Updated Upstream (Bukkit/CraftBukkit) Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Bukkit Changes: da08d022 SPIGOT-4700: Add PlayerFishEvent.State.REEL_IN 0cef14e4 Remove draft API from selectEntities CraftBukkit Changes: a46fdbc6 Remove outdated build delay. 3697519b SPIGOT-4708: Fix ExactChoice recipes neglecting material 9ead7009 SPIGOT-4677: Add minecraft.admin.command_feedback permission c3749a23 Remove the Damage tag from items when it is 0. f74c7b95 SPIGOT-4706: Can't interact with active item 494eef45 Mention requirement of JIRA ticket for bug fixes 51d62dec SPIGOT-4702: Exception when middle clicking certain slots be557e69 SPIGOT-4700: Add PlayerFishEvent.State.REEL_IN 2019-04-22 23:36:14 +02:00			`2.21.0`
NOT FINISHED! even more 1.13-pre patches! 2018-07-16 22:08:09 +02:00