Paper-Old/patches/unapplied/server/0475-Reduce-blockpos-allocation-from-pathfinding.patch

From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Spottedleaf <Spottedleaf@users.noreply.github.com>
Date: Sat, 25 Apr 2020 17:10:55 -0700
Subject: [PATCH] Reduce blockpos allocation from pathfinding


diff --git a/src/main/java/net/minecraft/world/level/pathfinder/WalkNodeEvaluator.java b/src/main/java/net/minecraft/world/level/pathfinder/WalkNodeEvaluator.java
index 10503d6d8b6daf645cf4360ee289d5e25144c976..3583fcf5284bc5883308876dbd9886664b391e28 100644
--- a/src/main/java/net/minecraft/world/level/pathfinder/WalkNodeEvaluator.java
+++ b/src/main/java/net/minecraft/world/level/pathfinder/WalkNodeEvaluator.java
@@ -473,7 +473,7 @@ public class WalkNodeEvaluator extends NodeEvaluator {
                             return BlockPathTypes.DANGER_FIRE;
                         }
 
-                        if (world.getFluidState(pos).is(FluidTags.WATER)) {
+                        if (blockState.getFluidState().is(FluidTags.WATER)) {
                             return BlockPathTypes.WATER_BORDER;
                         }
 
@@ -504,7 +504,7 @@ public class WalkNodeEvaluator extends NodeEvaluator {
                 } else if (blockState.is(Blocks.COCOA)) {
                     return BlockPathTypes.COCOA;
                 } else if (!blockState.is(Blocks.WITHER_ROSE) && !blockState.is(Blocks.POINTED_DRIPSTONE)) {
-                    FluidState fluidState = world.getFluidState(pos);
+                    FluidState fluidState = blockState.getFluidState(); // Paper - remove another getFluidState call
                     if (fluidState.is(FluidTags.LAVA)) {
                         return BlockPathTypes.LAVA;
                     } else if (isBurningBlock(blockState)) {
more patches 2021-06-14 18:58:00 +02:00			`From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001`
Rewrite chunk system (#8177) Patch documentation to come Issues with the old system that are fixed now: - World generation does not scale with cpu cores effectively. - Relies on the main thread for scheduling and maintaining chunk state, dropping chunk load/generate rates at lower tps. - Unreliable prioritisation of chunk gen/load calls that block the main thread. - Shutdown logic is utterly unreliable, as it has to wait for all chunks to unload - is it guaranteed that the chunk system is in a state on shutdown that it can reliably do this? Watchdog shutdown also typically failed due to thread checks, which is now resolved. - Saving of data is not unified (i.e can save chunk data without saving entity data, poses problems for desync if shutdown is really abnormal. - Entities are not loaded with chunks. This caused quite a bit of headache for Chunk#getEntities API, but now the new chunk system loads entities with chunks so that they are ready whenever the chunk loads in. Effectively brings the behavior back to 1.16 era, but still storing entities in their own separate regionfiles. The above list is not complete. The patch documentation will complete it. New chunk system hard relies on starlight and dataconverter, and most importantly the new concurrent utilities in ConcurrentUtil. Some of the old async chunk i/o interface (i.e the old file io thread reroutes _some_ calls to the new file io thread) is kept for plugin compat reasons. It will be removed in the next major version of minecraft. The old legacy chunk system patches have been moved to the removed folder in case we need them again. 2022-09-26 10:02:51 +02:00			`From: Spottedleaf <Spottedleaf@users.noreply.github.com>`
more patches 2021-06-14 18:58:00 +02:00			`Date: Sat, 25 Apr 2020 17:10:55 -0700`
			`Subject: [PATCH] Reduce blockpos allocation from pathfinding`


			`diff --git a/src/main/java/net/minecraft/world/level/pathfinder/WalkNodeEvaluator.java b/src/main/java/net/minecraft/world/level/pathfinder/WalkNodeEvaluator.java`
Rebuild patches 2023-09-22 19:59:56 +02:00			`index 10503d6d8b6daf645cf4360ee289d5e25144c976..3583fcf5284bc5883308876dbd9886664b391e28 100644`
more patches 2021-06-14 18:58:00 +02:00			`--- a/src/main/java/net/minecraft/world/level/pathfinder/WalkNodeEvaluator.java`
			`+++ b/src/main/java/net/minecraft/world/level/pathfinder/WalkNodeEvaluator.java`
finish some more patches 2023-06-08 01:44:11 +02:00			`@@ -473,7 +473,7 @@ public class WalkNodeEvaluator extends NodeEvaluator {`
more patches 2021-06-14 18:58:00 +02:00			`return BlockPathTypes.DANGER_FIRE;`
			`}`

			`- if (world.getFluidState(pos).is(FluidTags.WATER)) {`
			`+ if (blockState.getFluidState().is(FluidTags.WATER)) {`
			`return BlockPathTypes.WATER_BORDER;`
			`}`
finish some more patches 2023-06-08 01:44:11 +02:00
			`@@ -504,7 +504,7 @@ public class WalkNodeEvaluator extends NodeEvaluator {`
More more more more more more patches 2023-03-14 21:25:13 +01:00			`} else if (blockState.is(Blocks.COCOA)) {`
			`return BlockPathTypes.COCOA;`
finish some more patches 2023-06-08 01:44:11 +02:00			`} else if (!blockState.is(Blocks.WITHER_ROSE) && !blockState.is(Blocks.POINTED_DRIPSTONE)) {`
More more more more more more patches 2023-03-14 21:25:13 +01:00			`- FluidState fluidState = world.getFluidState(pos);`
finish some more patches 2023-06-08 01:44:11 +02:00			`+ FluidState fluidState = blockState.getFluidState(); // Paper - remove another getFluidState call`
More more more more more more patches 2023-03-14 21:25:13 +01:00			`if (fluidState.is(FluidTags.LAVA)) {`
			`return BlockPathTypes.LAVA;`
			`} else if (isBurningBlock(blockState)) {`