Paper-Old/Spigot-Server-Patches/0396-Use-ChunkStatus-cache-when-saving-protochunks.patch

From 03e8755740d9f2ccd80b90149c5b8a5a47ae4967 Mon Sep 17 00:00:00 2001
From: Spottedleaf <Spottedleaf@users.noreply.github.com>
Date: Sat, 22 Jun 2019 04:20:47 -0700
Subject: [PATCH] Use ChunkStatus cache when saving protochunks

The cache should contain the chunk status when saving. If not it
will load it.

diff --git a/src/main/java/net/minecraft/server/PlayerChunkMap.java b/src/main/java/net/minecraft/server/PlayerChunkMap.java
index bdadbd436..fbbd4d5dd 100644
--- a/src/main/java/net/minecraft/server/PlayerChunkMap.java
+++ b/src/main/java/net/minecraft/server/PlayerChunkMap.java
@@ -768,8 +768,10 @@ public class PlayerChunkMap extends IChunkLoader implements PlayerChunk.d {
                 NBTTagCompound nbttagcompound;
 
                 if (chunkstatus.getType() != ChunkStatus.Type.LEVELCHUNK) {
-                    nbttagcompound = this.readChunkData(chunkcoordintpair);
-                    if (nbttagcompound != null && ChunkRegionLoader.a(nbttagcompound) == ChunkStatus.Type.LEVELCHUNK) {
+                    // Paper start - Optimize save by using status cache
+                    ChunkStatus statusOnDisk = this.getChunkStatusOnDisk(chunkcoordintpair);
+                    if (statusOnDisk != null && statusOnDisk.getType() == ChunkStatus.Type.LEVELCHUNK) {
+                        // Paper end
                         return false;
                     }
 
-- 
2.23.0
[CI-SKIP] Rebuild patches 2019-09-29 22:02:04 +02:00			`From 03e8755740d9f2ccd80b90149c5b8a5a47ae4967 Mon Sep 17 00:00:00 2001`
Optimize protochunk saving (#2218) Use a chunk status cache to check if we could potentially overwrite a levelchunk. The check could be entirely elided at the risk of overwriting chunk data, however most protochunks should have their corresponding regionfile loaded with their chunk status. 2019-06-22 22:17:40 +02:00			`From: Spottedleaf <Spottedleaf@users.noreply.github.com>`
			`Date: Sat, 22 Jun 2019 04:20:47 -0700`
			`Subject: [PATCH] Use ChunkStatus cache when saving protochunks`

			`The cache should contain the chunk status when saving. If not it`
			`will load it.`

			`diff --git a/src/main/java/net/minecraft/server/PlayerChunkMap.java b/src/main/java/net/minecraft/server/PlayerChunkMap.java`
Implement optional per player mobspawning (#2171) 2019-08-21 03:02:51 +02:00			`index bdadbd436..fbbd4d5dd 100644`
Optimize protochunk saving (#2218) Use a chunk status cache to check if we could potentially overwrite a levelchunk. The check could be entirely elided at the risk of overwriting chunk data, however most protochunks should have their corresponding regionfile loaded with their chunk status. 2019-06-22 22:17:40 +02:00			`--- a/src/main/java/net/minecraft/server/PlayerChunkMap.java`
			`+++ b/src/main/java/net/minecraft/server/PlayerChunkMap.java`
Seperate out incremental saving This fixes multiple issues, mainly cleaning up the patch as well as making save-all actually save all. (Worth noting, that you should probably be using save-all flush if you're relying on this for backups) 2019-07-28 02:38:29 +02:00			`@@ -768,8 +768,10 @@ public class PlayerChunkMap extends IChunkLoader implements PlayerChunk.d {`
Optimize protochunk saving (#2218) Use a chunk status cache to check if we could potentially overwrite a levelchunk. The check could be entirely elided at the risk of overwriting chunk data, however most protochunks should have their corresponding regionfile loaded with their chunk status. 2019-06-22 22:17:40 +02:00			`NBTTagCompound nbttagcompound;`

			`if (chunkstatus.getType() != ChunkStatus.Type.LEVELCHUNK) {`
			`- nbttagcompound = this.readChunkData(chunkcoordintpair);`
			`- if (nbttagcompound != null && ChunkRegionLoader.a(nbttagcompound) == ChunkStatus.Type.LEVELCHUNK) {`
			`+ // Paper start - Optimize save by using status cache`
Fix loadChunk(x, z, false) I was not correctly checking if the status was even cached. Actually fix it this time Do not forget about the async chunk placeholder Actually fix it this time I hope No plugin tickets for getChunkAtGen(x, z, boolean) Change ChunkStatus ABI This is required for asynchronous IO. async io will require calls to getChunkStatusIfCached to return the chunk status for a chunk currently queued to save - this cannot be reasonably done with current ABI 2019-07-08 08:52:08 +02:00			`+ ChunkStatus statusOnDisk = this.getChunkStatusOnDisk(chunkcoordintpair);`
Optimize protochunk saving (#2218) Use a chunk status cache to check if we could potentially overwrite a levelchunk. The check could be entirely elided at the risk of overwriting chunk data, however most protochunks should have their corresponding regionfile loaded with their chunk status. 2019-06-22 22:17:40 +02:00			`+ if (statusOnDisk != null && statusOnDisk.getType() == ChunkStatus.Type.LEVELCHUNK) {`
			`+ // Paper end`
			`return false;`
			`}`

			`--`
Implement optional per player mobspawning (#2171) 2019-08-21 03:02:51 +02:00			`2.23.0`
Optimize protochunk saving (#2218) Use a chunk status cache to check if we could potentially overwrite a levelchunk. The check could be entirely elided at the risk of overwriting chunk data, however most protochunks should have their corresponding regionfile loaded with their chunk status. 2019-06-22 22:17:40 +02:00