Paper-Old/Spigot-Server-Patches/0132-Fix-AIOOBE-in-inventory-handling.patch

From 14b5c09d5c2ec1c709daba6dc1e5abf715b195ba Mon Sep 17 00:00:00 2001
From: Brokkonaut <hannos17@gmx.de>
Date: Sun, 4 Sep 2016 16:35:43 -0500
Subject: [PATCH] Fix AIOOBE in inventory handling


diff --git a/src/main/java/net/minecraft/server/PlayerConnection.java b/src/main/java/net/minecraft/server/PlayerConnection.java
index ca026155d8..e967066dcf 100644
--- a/src/main/java/net/minecraft/server/PlayerConnection.java
+++ b/src/main/java/net/minecraft/server/PlayerConnection.java
@@ -2082,7 +2082,7 @@ public class PlayerConnection implements PacketListenerPlayIn, ITickable {
                     case CLONE:
                         if (packetplayinwindowclick.d() == 2) {
                             click = ClickType.MIDDLE;
-                            if (packetplayinwindowclick.c() == -999) {
+                            if (packetplayinwindowclick.c() < 0) { // Paper - GH-404
                                 action = InventoryAction.NOTHING;
                             } else {
                                 Slot slot = this.player.activeContainer.getSlot(packetplayinwindowclick.c());
-- 
2.20.1
Updated Upstream (Bukkit/CraftBukkit) Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Bukkit Changes: 60268ac8 Recipe choice lists should be copied once handed over to Bukkit 7ab335f2 Consistent multiple choice APIs for RecipeChoice. 2b6f3d7f SPIGOT-4586: Change PotionEffectType#value to not include null CraftBukkit Changes: 2aba349f Need to update item in hand if fish bucket pickup cancelled b634e059 SPIGOT-4591: Must mark itemstacks as dirty in case the handle itself changed 1748af89 Consistent multiple choice APIs for RecipeChoice. 2019-01-28 23:14:04 +01:00			`From 14b5c09d5c2ec1c709daba6dc1e5abf715b195ba Mon Sep 17 00:00:00 2001`
Fix an AIOOBE in inventory handling Closes GH-404 2016-09-04 23:49:29 +02:00			`From: Brokkonaut <hannos17@gmx.de>`
			`Date: Sun, 4 Sep 2016 16:35:43 -0500`
			`Subject: [PATCH] Fix AIOOBE in inventory handling`


			`diff --git a/src/main/java/net/minecraft/server/PlayerConnection.java b/src/main/java/net/minecraft/server/PlayerConnection.java`
Updated Upstream (Bukkit/CraftBukkit) Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Bukkit Changes: 60268ac8 Recipe choice lists should be copied once handed over to Bukkit 7ab335f2 Consistent multiple choice APIs for RecipeChoice. 2b6f3d7f SPIGOT-4586: Change PotionEffectType#value to not include null CraftBukkit Changes: 2aba349f Need to update item in hand if fish bucket pickup cancelled b634e059 SPIGOT-4591: Must mark itemstacks as dirty in case the handle itself changed 1748af89 Consistent multiple choice APIs for RecipeChoice. 2019-01-28 23:14:04 +01:00			`index ca026155d8..e967066dcf 100644`
Fix an AIOOBE in inventory handling Closes GH-404 2016-09-04 23:49:29 +02:00			`--- a/src/main/java/net/minecraft/server/PlayerConnection.java`
			`+++ b/src/main/java/net/minecraft/server/PlayerConnection.java`
Updated Upstream (Bukkit/CraftBukkit) Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Bukkit Changes: 60268ac8 Recipe choice lists should be copied once handed over to Bukkit 7ab335f2 Consistent multiple choice APIs for RecipeChoice. 2b6f3d7f SPIGOT-4586: Change PotionEffectType#value to not include null CraftBukkit Changes: 2aba349f Need to update item in hand if fish bucket pickup cancelled b634e059 SPIGOT-4591: Must mark itemstacks as dirty in case the handle itself changed 1748af89 Consistent multiple choice APIs for RecipeChoice. 2019-01-28 23:14:04 +01:00			`@@ -2082,7 +2082,7 @@ public class PlayerConnection implements PacketListenerPlayIn, ITickable {`
Fix an AIOOBE in inventory handling Closes GH-404 2016-09-04 23:49:29 +02:00			`case CLONE:`
NOT FINISHED! even more 1.13-pre patches! 2018-07-16 22:08:09 +02:00			`if (packetplayinwindowclick.d() == 2) {`
Fix an AIOOBE in inventory handling Closes GH-404 2016-09-04 23:49:29 +02:00			`click = ClickType.MIDDLE;`
NOT FINISHED! even more 1.13-pre patches! 2018-07-16 22:08:09 +02:00			`- if (packetplayinwindowclick.c() == -999) {`
			`+ if (packetplayinwindowclick.c() < 0) { // Paper - GH-404`
Fix an AIOOBE in inventory handling Closes GH-404 2016-09-04 23:49:29 +02:00			`action = InventoryAction.NOTHING;`
			`} else {`
NOT FINISHED! even more 1.13-pre patches! 2018-07-16 22:08:09 +02:00			`Slot slot = this.player.activeContainer.getSlot(packetplayinwindowclick.c());`
Fix an AIOOBE in inventory handling Closes GH-404 2016-09-04 23:49:29 +02:00			`--`
Updated Upstream (Bukkit/CraftBukkit/Spigot) Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Warning: this commit contains more mapping changes from upstream, As always, ensure that you have working backups and test this build before deployment; Developers working on paper will, yet again, need to delete their work/Minecraft/1.13.2 folder Bukkit Changes: 7fca5fd4 SPIGOT-4558: Preserve user order in the face of copied defaults in configurations 15c9b1eb Ignore spurious slot IDs sent by client, e.g. in enchanting tables 5d2a10c5 SPIGOT-3747: Add API for force loaded chunks d6dd2bb3 SPIGOT-3538: Add getHitBlockFace for ProjectileHitEvent 771db4aa SPIGOT-794: Call EntityPlaceEvent for Minecart placement 55462509 Add InventoryView#getSlotType 2f3ce5b6 Remove EntityTransformEvent and CustomItemTagContainer from draft API f04ad7b6 Make ProjectileLaunchEvent extend EntitySpawnEvent ccb85808 Define EntitySpawnEvent b8cc3ebe Add PlayerItemDamageEvent 184a495d Ease ClassLoader Deadlocks Where Possible 11ac4728 Expand Boolean Prompt Values in Conversation API aae62d51 Added getAllSessionData() to the Conversation API. 9290ff91 Add InventoryView#getInventory API 995e530f Add API to get / set base arrow damage CraftBukkit Changes: c4a67eed SPIGOT-4556: Fix plugins closing inventory during drop events 5be2ddcb Replace version constants with methods to prevent compiler inlining a5b9c7b3 Use API method to create offset command completions 2bc7d1df SPIGOT-3747: Add API for force loaded chunks a408f375 SPIGOT-3538: Add getHitBlockFace for ProjectileHitEvent b54b9409 SPIGOT-2864: Make Arrow / Item setTicksLived behave like FallingBlock 79ded7a8 SPIGOT-1811: Death message not shown on respawn screen b4a4f15d SPIGOT-943: InventoryCloseEvent called on death regardless of open inventory 0afed592 SPIGOT-794: Call EntityPlaceEvent for Minecart placement 2b2d084a Add InventoryView#getSlotType 01a9959a Do not use deprecated ItemSpawnEvent constructor 9642498d SPIGOT-4547: Call EntitySpawnEvent as general spawn fallback event 963f4a5f Add PlayerItemDamageEvent 63db0445 Add API to get / set base arrow damage 531c25d7 Add CraftMagicNumbers.MAPPINGS_VERSION for use by NMS plugins d05c8b14 Mappings Update bd36e200 SPIGOT-4551: Ignore invalid attribute modifier slots Spigot Changes: 518206a1 Remove redundant trove depend 1959ad21 MC-11211,SPIGOT-4552: Fix placing double slabs at y = 255 29ab5e43 SPIGOT-3661: Allow arguments in restart-script 7cc46316 SPIGOT-852: Growth modifiers for beetroots, potatoes, carrots 82e117e1 Squelch "fatal: Resolve operation not in progress" message 0a1a68e7 Mappings Update & Patch Rebuild 2019-01-01 04:15:55 +01:00			`2.20.1`
Fix an AIOOBE in inventory handling Closes GH-404 2016-09-04 23:49:29 +02:00