Paper-Old/patches/server/0080-Sanitise-RegionFileCache-and-make-configurable.patch

From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Antony Riley <antony@cyberiantiger.org>
Date: Tue, 29 Mar 2016 08:22:55 +0300
Subject: [PATCH] Sanitise RegionFileCache and make configurable.

RegionFileCache prior to this patch would close every single open region
file upon reaching a size of 256.
This patch modifies that behaviour so it closes the the least recently
used RegionFile.
The implementation uses a LinkedHashMap as an LRU cache (modified from HashMap).
The maximum size of the RegionFileCache is also made configurable.

diff --git a/src/main/java/net/minecraft/world/level/chunk/storage/RegionFileStorage.java b/src/main/java/net/minecraft/world/level/chunk/storage/RegionFileStorage.java
index ece0fd4b51d124be232e24d08f115b9267cb21cb..9a4f9251d655b86af5a410cfab8df285098e01cc 100644
--- a/src/main/java/net/minecraft/world/level/chunk/storage/RegionFileStorage.java
+++ b/src/main/java/net/minecraft/world/level/chunk/storage/RegionFileStorage.java
@@ -57,7 +57,7 @@ public class RegionFileStorage implements AutoCloseable {
             // Paper end
             return regionfile;
         } else {
-            if (this.regionCache.size() >= 256) {
+            if (this.regionCache.size() >= io.papermc.paper.configuration.GlobalConfiguration.get().misc.regionFileCacheSize) { // Paper - configurable
                 ((RegionFile) this.regionCache.removeLast()).close();
             }
Move patches around 2021-06-11 14:02:28 +02:00			`From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001`
			`From: Antony Riley <antony@cyberiantiger.org>`
			`Date: Tue, 29 Mar 2016 08:22:55 +0300`
			`Subject: [PATCH] Sanitise RegionFileCache and make configurable.`

			`RegionFileCache prior to this patch would close every single open region`
			`file upon reaching a size of 256.`
			`This patch modifies that behaviour so it closes the the least recently`
			`used RegionFile.`
			`The implementation uses a LinkedHashMap as an LRU cache (modified from HashMap).`
			`The maximum size of the RegionFileCache is also made configurable.`

			`diff --git a/src/main/java/net/minecraft/world/level/chunk/storage/RegionFileStorage.java b/src/main/java/net/minecraft/world/level/chunk/storage/RegionFileStorage.java`
Rewrite chunk system (#8177) Patch documentation to come Issues with the old system that are fixed now: - World generation does not scale with cpu cores effectively. - Relies on the main thread for scheduling and maintaining chunk state, dropping chunk load/generate rates at lower tps. - Unreliable prioritisation of chunk gen/load calls that block the main thread. - Shutdown logic is utterly unreliable, as it has to wait for all chunks to unload - is it guaranteed that the chunk system is in a state on shutdown that it can reliably do this? Watchdog shutdown also typically failed due to thread checks, which is now resolved. - Saving of data is not unified (i.e can save chunk data without saving entity data, poses problems for desync if shutdown is really abnormal. - Entities are not loaded with chunks. This caused quite a bit of headache for Chunk#getEntities API, but now the new chunk system loads entities with chunks so that they are ready whenever the chunk loads in. Effectively brings the behavior back to 1.16 era, but still storing entities in their own separate regionfiles. The above list is not complete. The patch documentation will complete it. New chunk system hard relies on starlight and dataconverter, and most importantly the new concurrent utilities in ConcurrentUtil. Some of the old async chunk i/o interface (i.e the old file io thread reroutes _some_ calls to the new file io thread) is kept for plugin compat reasons. It will be removed in the next major version of minecraft. The old legacy chunk system patches have been moved to the removed folder in case we need them again. 2022-09-26 10:02:51 +02:00			`index ece0fd4b51d124be232e24d08f115b9267cb21cb..9a4f9251d655b86af5a410cfab8df285098e01cc 100644`
Move patches around 2021-06-11 14:02:28 +02:00			`--- a/src/main/java/net/minecraft/world/level/chunk/storage/RegionFileStorage.java`
			`+++ b/src/main/java/net/minecraft/world/level/chunk/storage/RegionFileStorage.java`
Re-arrange most chunk system patches to front (#8338) * Re-arrange most chunk system patches to front Co-authored-by: Spottedleaf <Spottedleaf@users.noreply.github.com> 2022-09-01 18:51:59 +02:00			`@@ -57,7 +57,7 @@ public class RegionFileStorage implements AutoCloseable {`
			`// Paper end`
Move patches around 2021-06-11 14:02:28 +02:00			`return regionfile;`
			`} else {`
			`- if (this.regionCache.size() >= 256) {`
Move to configurate for paper.yml (#7609) 2022-06-09 10:51:45 +02:00			`+ if (this.regionCache.size() >= io.papermc.paper.configuration.GlobalConfiguration.get().misc.regionFileCacheSize) { // Paper - configurable`
Move patches around 2021-06-11 14:02:28 +02:00			`((RegionFile) this.regionCache.removeLast()).close();`
			`}`