Paper-Old/patches/server/0067-Remove-Metadata-on-reload.patch

From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Aikar <aikar@aikar.co>
Date: Fri, 18 Mar 2016 13:50:14 -0400
Subject: [PATCH] Remove Metadata on reload

Metadata is not meant to persist reload as things break badly with non primitive types
This will remove metadata on reload so it does not crash everything if a plugin uses it.

diff --git a/src/main/java/org/bukkit/craftbukkit/CraftServer.java b/src/main/java/org/bukkit/craftbukkit/CraftServer.java
index 25373b05ab63e71294382c4b2a5b2658f98710a0..943971ce16c0c39085f029ab5b57685dda1c6b0f 100644
--- a/src/main/java/org/bukkit/craftbukkit/CraftServer.java
+++ b/src/main/java/org/bukkit/craftbukkit/CraftServer.java
@@ -950,8 +950,16 @@ public final class CraftServer implements Server {
             world.spigotConfig.init(); // Spigot
         }
 
+        Plugin[] pluginClone = pluginManager.getPlugins().clone(); // Paper
         this.pluginManager.clearPlugins();
         this.commandMap.clearCommands();
+        // Paper start
+        for (Plugin plugin : pluginClone) {
+            entityMetadata.removeAll(plugin);
+            worldMetadata.removeAll(plugin);
+            playerMetadata.removeAll(plugin);
+        }
+        // Paper end
         this.reloadData();
         org.spigotmc.SpigotConfig.registerCommands(); // Spigot
         io.papermc.paper.command.PaperCommands.registerCommands(this.console); // Paper
Move patches around 2021-06-11 14:02:28 +02:00			`From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001`
			`From: Aikar <aikar@aikar.co>`
			`Date: Fri, 18 Mar 2016 13:50:14 -0400`
			`Subject: [PATCH] Remove Metadata on reload`

			`Metadata is not meant to persist reload as things break badly with non primitive types`
			`This will remove metadata on reload so it does not crash everything if a plugin uses it.`

			`diff --git a/src/main/java/org/bukkit/craftbukkit/CraftServer.java b/src/main/java/org/bukkit/craftbukkit/CraftServer.java`
Rewrite chunk system (#8177) Patch documentation to come Issues with the old system that are fixed now: - World generation does not scale with cpu cores effectively. - Relies on the main thread for scheduling and maintaining chunk state, dropping chunk load/generate rates at lower tps. - Unreliable prioritisation of chunk gen/load calls that block the main thread. - Shutdown logic is utterly unreliable, as it has to wait for all chunks to unload - is it guaranteed that the chunk system is in a state on shutdown that it can reliably do this? Watchdog shutdown also typically failed due to thread checks, which is now resolved. - Saving of data is not unified (i.e can save chunk data without saving entity data, poses problems for desync if shutdown is really abnormal. - Entities are not loaded with chunks. This caused quite a bit of headache for Chunk#getEntities API, but now the new chunk system loads entities with chunks so that they are ready whenever the chunk loads in. Effectively brings the behavior back to 1.16 era, but still storing entities in their own separate regionfiles. The above list is not complete. The patch documentation will complete it. New chunk system hard relies on starlight and dataconverter, and most importantly the new concurrent utilities in ConcurrentUtil. Some of the old async chunk i/o interface (i.e the old file io thread reroutes _some_ calls to the new file io thread) is kept for plugin compat reasons. It will be removed in the next major version of minecraft. The old legacy chunk system patches have been moved to the removed folder in case we need them again. 2022-09-26 10:02:51 +02:00			`index 25373b05ab63e71294382c4b2a5b2658f98710a0..943971ce16c0c39085f029ab5b57685dda1c6b0f 100644`
Move patches around 2021-06-11 14:02:28 +02:00			`--- a/src/main/java/org/bukkit/craftbukkit/CraftServer.java`
			`+++ b/src/main/java/org/bukkit/craftbukkit/CraftServer.java`
Updated Upstream (Bukkit/CraftBukkit) (#8270) Upstream has released updates that appear to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Bukkit Changes: d43a1e72 SPIGOT-2450: Improve scoreboard criteria API, add missing DisplaySlots 9d6e4847 SPIGOT-7122: New Allay Methods from 1.19.1 CraftBukkit Changes: c379a6b4e SPIGOT-2450: Improve scoreboard criteria API, add missing DisplaySlots 051fcced1 SPIGOT-7122: New Allay Methods from 1.19.1 2022-08-09 09:18:08 +02:00			`@@ -950,8 +950,16 @@ public final class CraftServer implements Server {`
Move to configurate for paper.yml (#7609) 2022-06-09 10:51:45 +02:00			`world.spigotConfig.init(); // Spigot`
Move patches around 2021-06-11 14:02:28 +02:00			`}`

			`+ Plugin[] pluginClone = pluginManager.getPlugins().clone(); // Paper`
more patches 2021-06-12 02:57:04 +02:00			`this.pluginManager.clearPlugins();`
			`this.commandMap.clearCommands();`
Move patches around 2021-06-11 14:02:28 +02:00			`+ // Paper start`
			`+ for (Plugin plugin : pluginClone) {`
			`+ entityMetadata.removeAll(plugin);`
			`+ worldMetadata.removeAll(plugin);`
			`+ playerMetadata.removeAll(plugin);`
			`+ }`
			`+ // Paper end`
more patches 2021-06-12 02:57:04 +02:00			`this.reloadData();`
Move patches around 2021-06-11 14:02:28 +02:00			`org.spigotmc.SpigotConfig.registerCommands(); // Spigot`
fix compile issue 2022-06-09 23:50:05 +02:00			`io.papermc.paper.command.PaperCommands.registerCommands(this.console); // Paper`