From f30ea9626864bc7ad9f228b4932c5060b5d9e465 Mon Sep 17 00:00:00 2001
From: dordsor21 <dordsor21@gmail.com>
Date: Thu, 30 Dec 2021 16:04:38 +0000
Subject: [PATCH] Refactor: add javadoc to Clipboard#create and improve
 variables when delegating to another paste method

---
 .../worldedit/extent/clipboard/Clipboard.java   | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/worldedit-core/src/main/java/com/sk89q/worldedit/extent/clipboard/Clipboard.java b/worldedit-core/src/main/java/com/sk89q/worldedit/extent/clipboard/Clipboard.java
index e65f9d634..c4d940d7a 100644
--- a/worldedit-core/src/main/java/com/sk89q/worldedit/extent/clipboard/Clipboard.java
+++ b/worldedit-core/src/main/java/com/sk89q/worldedit/extent/clipboard/Clipboard.java
@@ -70,6 +70,10 @@ public interface Clipboard extends Extent, Iterable<BlockVector3>, Closeable, Fl
     //FAWE end
 
     //FAWE start
+
+    /**
+     * Creates a new {@link ReadOnlyClipboard}.
+     */
     static Clipboard create(Region region) {
         checkNotNull(region);
         checkNotNull(
@@ -85,6 +89,13 @@ public interface Clipboard extends Extent, Iterable<BlockVector3>, Closeable, Fl
         return ReadOnlyClipboard.of(session, region);
     }
 
+    /**
+     * Create a new {@link com.fastasyncworldedit.core.extent.clipboard.SimpleClipboard} instance.
+     * Will be one of the following, depending on settings:
+     *  - {@link DiskOptimizedClipboard}
+     *  - {@link CPUOptimizedClipboard}
+     *  - {@link MemoryOptimizedClipboard}
+     */
     static Clipboard create(Region region, UUID uuid) {
         if (Settings.settings().CLIPBOARD.USE_DISK) {
             return new DiskOptimizedClipboard(region, uuid);
@@ -249,7 +260,7 @@ public interface Clipboard extends Extent, Iterable<BlockVector3>, Closeable, Fl
      */
     default EditSession paste(
             World world, BlockVector3 to, boolean allowUndo, boolean pasteAir,
-            boolean copyEntities, @Nullable Transform transform
+            boolean pasteEntities, @Nullable Transform transform
     ) {
         checkNotNull(world);
         checkNotNull(to);
@@ -275,7 +286,7 @@ public interface Clipboard extends Extent, Iterable<BlockVector3>, Closeable, Fl
         if (transform != null && !transform.isIdentity()) {
             extent = new BlockTransformExtent(this, transform);
         } else if (sourceMask == null) {
-            paste(editSession, to, pasteAir);
+            paste(editSession, to, pasteAir, pasteEntities, hasBiomes());
             editSession.flushQueue();
             return editSession;
         }
@@ -285,7 +296,7 @@ public interface Clipboard extends Extent, Iterable<BlockVector3>, Closeable, Fl
         if (transform != null && !transform.isIdentity()) {
             copy.setTransform(transform);
         }
-        copy.setCopyingEntities(copyEntities);
+        copy.setCopyingEntities(pasteEntities);
         if (sourceMask != null) {
             new MaskTraverser(sourceMask).reset(extent);
             copy.setSourceMask(sourceMask);