From 9992dfaf181b77526472616d6e7124bd3960509d Mon Sep 17 00:00:00 2001
From: yoyosource <yoyosource@nidido.de>
Date: Sat, 21 Jan 2023 17:06:56 +0100
Subject: [PATCH 1/2] Add better caching key normalization

---
 src/de/steamwar/command/AbstractTypeMapper.java   | 9 +++++++++
 src/de/steamwar/command/CommandPart.java          | 2 +-
 src/de/steamwar/command/TabCompletionCache.java   | 7 +++++--
 testsrc/de/steamwar/command/CacheCommand.java     | 6 +++++-
 testsrc/de/steamwar/command/CacheCommandTest.java | 8 ++++++++
 5 files changed, 28 insertions(+), 4 deletions(-)

diff --git a/src/de/steamwar/command/AbstractTypeMapper.java b/src/de/steamwar/command/AbstractTypeMapper.java
index 0363cd0..ab9d116 100644
--- a/src/de/steamwar/command/AbstractTypeMapper.java
+++ b/src/de/steamwar/command/AbstractTypeMapper.java
@@ -50,4 +50,13 @@ public interface AbstractTypeMapper<K, T> extends AbstractValidator<K, T> {
     default Collection<String> tabCompletes(K sender, PreviousArguments previousArguments, String s) {
         return tabCompletes(sender, previousArguments.userArgs, s);
     }
+
+    /**
+     * Normalize the cache key by sender and user provided argument. <br>
+     * Note: The CommandSender can be null! <br>
+     * Returning null and the empty string are equivalent.
+     */
+    default String normalize(K sender, String s) {
+        return s;
+    }
 }
diff --git a/src/de/steamwar/command/CommandPart.java b/src/de/steamwar/command/CommandPart.java
index 5a056d2..926ad2a 100644
--- a/src/de/steamwar/command/CommandPart.java
+++ b/src/de/steamwar/command/CommandPart.java
@@ -165,7 +165,7 @@ class CommandPart<T> {
     }
 
     private Collection<String> tabCompletes(T sender, String[] args, List<Object> mappedArgs, int startIndex) {
-        return TabCompletionCache.tabComplete(sender, typeMapper, command, () -> {
+        return TabCompletionCache.tabComplete(sender, args[startIndex], (AbstractTypeMapper<Object, ?>) typeMapper, command, () -> {
             try {
                 return typeMapper.tabCompletes(sender, new PreviousArguments(Arrays.copyOf(args, startIndex), mappedArgs.toArray()), args[startIndex]);
             } catch (Throwable e) {
diff --git a/src/de/steamwar/command/TabCompletionCache.java b/src/de/steamwar/command/TabCompletionCache.java
index 6f2d0ff..4e50a18 100644
--- a/src/de/steamwar/command/TabCompletionCache.java
+++ b/src/de/steamwar/command/TabCompletionCache.java
@@ -51,6 +51,7 @@ public class TabCompletionCache {
     @AllArgsConstructor
     private static class Key {
         private Object sender;
+        private String arg;
         private AbstractTypeMapper<?, ?> typeMapper;
     }
 
@@ -61,9 +62,11 @@ public class TabCompletionCache {
         private Collection<String> tabCompletions;
     }
 
-    Collection<String> tabComplete(Object sender, AbstractTypeMapper<?, ?> typeMapper, AbstractSWCommand<?> command, Supplier<Collection<String>> tabCompleteSupplier) {
+    Collection<String> tabComplete(Object sender, String arg, AbstractTypeMapper<Object, ?> typeMapper, AbstractSWCommand<?> command, Supplier<Collection<String>> tabCompleteSupplier) {
         if (!cached.contains(typeMapper)) return tabCompleteSupplier.get();
-        Key key = global.contains(typeMapper) ? new Key(null, typeMapper) : new Key(sender, typeMapper);
+        String normalizedArg = typeMapper.normalize(sender, arg);
+        if (normalizedArg == null) normalizedArg = "";
+        Key key = global.contains(typeMapper) ? new Key(null, normalizedArg, typeMapper) : new Key(sender, normalizedArg, typeMapper);
         TabCompletions tabCompletions = tabCompletionCache.computeIfAbsent(key, ignore -> {
             return new TabCompletions(command, System.currentTimeMillis(), tabCompleteSupplier.get());
         });
diff --git a/testsrc/de/steamwar/command/CacheCommand.java b/testsrc/de/steamwar/command/CacheCommand.java
index 5057ffd..ee7a4cc 100644
--- a/testsrc/de/steamwar/command/CacheCommand.java
+++ b/testsrc/de/steamwar/command/CacheCommand.java
@@ -41,7 +41,6 @@ public class CacheCommand extends TestSWCommand {
     @Cached
     @Mapper(value = "int", local = true)
     public AbstractTypeMapper<String, Integer> typeMapper() {
-        System.out.println("TypeMapper register");
         return new TestTypeMapper<Integer>() {
             @Override
             public Integer map(String sender, PreviousArguments previousArguments, String s) {
@@ -52,6 +51,11 @@ public class CacheCommand extends TestSWCommand {
             public Collection<String> tabCompletes(String sender, PreviousArguments previousArguments, String s) {
                 return Arrays.asList(count.getAndIncrement() + "");
             }
+
+            @Override
+            public String normalize(String sender, String s) {
+                return "";
+            }
         };
     }
 }
diff --git a/testsrc/de/steamwar/command/CacheCommandTest.java b/testsrc/de/steamwar/command/CacheCommandTest.java
index 122528f..4a6e183 100644
--- a/testsrc/de/steamwar/command/CacheCommandTest.java
+++ b/testsrc/de/steamwar/command/CacheCommandTest.java
@@ -36,6 +36,14 @@ public class CacheCommandTest {
         assertThat(tabCompletions1, is(equalTo(tabCompletions2)));
     }
 
+    @Test
+    public void testCachingWithDifferentMessages() {
+        CacheCommand cmd = new CacheCommand();
+        List<String> tabCompletions1 = cmd.tabComplete("test", "", new String[]{""});
+        List<String> tabCompletions2 = cmd.tabComplete("test", "", new String[]{"0"});
+        assertThat(tabCompletions1, is(equalTo(tabCompletions2)));
+    }
+
     @Test
     public void testCachingWithDifferentSenders() {
         CacheCommand cmd = new CacheCommand();

From 8100f9c044c8d067380f3d51479032974c00f565 Mon Sep 17 00:00:00 2001
From: yoyosource <yoyosource@nidido.de>
Date: Sat, 21 Jan 2023 17:07:48 +0100
Subject: [PATCH 2/2] Retain current behaviour

---
 src/de/steamwar/command/AbstractTypeMapper.java | 2 +-
 testsrc/de/steamwar/command/CacheCommand.java   | 5 -----
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/src/de/steamwar/command/AbstractTypeMapper.java b/src/de/steamwar/command/AbstractTypeMapper.java
index ab9d116..040f303 100644
--- a/src/de/steamwar/command/AbstractTypeMapper.java
+++ b/src/de/steamwar/command/AbstractTypeMapper.java
@@ -57,6 +57,6 @@ public interface AbstractTypeMapper<K, T> extends AbstractValidator<K, T> {
      * Returning null and the empty string are equivalent.
      */
     default String normalize(K sender, String s) {
-        return s;
+        return null;
     }
 }
diff --git a/testsrc/de/steamwar/command/CacheCommand.java b/testsrc/de/steamwar/command/CacheCommand.java
index ee7a4cc..7cfdb72 100644
--- a/testsrc/de/steamwar/command/CacheCommand.java
+++ b/testsrc/de/steamwar/command/CacheCommand.java
@@ -51,11 +51,6 @@ public class CacheCommand extends TestSWCommand {
             public Collection<String> tabCompletes(String sender, PreviousArguments previousArguments, String s) {
                 return Arrays.asList(count.getAndIncrement() + "");
             }
-
-            @Override
-            public String normalize(String sender, String s) {
-                return "";
-            }
         };
     }
 }