From cf5f5ed4bb30d5a66f3a9f03a1699602b3007d11 Mon Sep 17 00:00:00 2001
From: Nassim Jahnke <nassim@njahnke.dev>
Date: Sat, 9 Dec 2023 15:19:05 +0100
Subject: [PATCH] Fix conversion of mixed json arrays

---
 .../Protocol1_20_3To1_20_2.java                   | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_20_3to1_20_2/Protocol1_20_3To1_20_2.java b/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_20_3to1_20_2/Protocol1_20_3To1_20_2.java
index 634f7db7d..ee3fe30f6 100644
--- a/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_20_3to1_20_2/Protocol1_20_3To1_20_2.java
+++ b/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_20_3to1_20_2/Protocol1_20_3To1_20_2.java
@@ -361,7 +361,7 @@ public final class Protocol1_20_3To1_20_2 extends AbstractProtocol<ClientboundPa
             // Use the hash to write a pack uuid
             final String url = wrapper.read(Type.STRING);
             final String hash = wrapper.read(Type.STRING);
-            wrapper.write(Type.UUID, UUID.nameUUIDFromBytes(hash.getBytes(StandardCharsets.UTF_8)));
+            wrapper.write(Type.UUID, UUID.nameUUIDFromBytes(url.getBytes(StandardCharsets.UTF_8)));
             wrapper.write(Type.STRING, url);
             wrapper.write(Type.STRING, hash);
             wrapper.passthrough(Type.BOOLEAN); // Required
@@ -485,15 +485,20 @@ public final class Protocol1_20_3To1_20_2 extends AbstractProtocol<ClientboundPa
         for (final JsonElement entry : element.getAsJsonArray()) {
             final Tag convertedTag = convertToTag(entry);
             if (convertedTag instanceof CompoundTag) {
-                processedListTag.add(listTag);
+                processedListTag.add(convertedTag);
                 continue;
             }
 
-            // Wrap all entries in compound tags as lists can only consist of one type of tag
+            // Wrap all entries in compound tags, as lists can only consist of one type of tag
             final CompoundTag compoundTag = new CompoundTag();
             compoundTag.put("type", new StringTag("text"));
-            compoundTag.put("text", new StringTag());
-            compoundTag.put("extra", convertedTag);
+            if (convertedTag instanceof ListTag) {
+                compoundTag.put("text", new StringTag());
+                compoundTag.put("extra", convertedTag);
+            } else {
+                compoundTag.put("text", new StringTag(convertedTag.toString()));
+            }
+            processedListTag.add(compoundTag);
         }
         return processedListTag;
     }