From 232ee9b63bcf9677236221cdc7eb699de3a882c1 Mon Sep 17 00:00:00 2001 From: Andrew Steinborn Date: Fri, 17 May 2019 18:01:58 -0400 Subject: [PATCH] Don't try to send register messages without channels Bukkit interprets this as attempting to register the channel "" (the empty string), which fails on Minecraft 1.13 and above. --- .../protocol1_13to1_12_2/packets/InventoryPackets.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/common/src/main/java/us/myles/ViaVersion/protocols/protocol1_13to1_12_2/packets/InventoryPackets.java b/common/src/main/java/us/myles/ViaVersion/protocols/protocol1_13to1_12_2/packets/InventoryPackets.java index 2d8ad2522..52c41be67 100644 --- a/common/src/main/java/us/myles/ViaVersion/protocols/protocol1_13to1_12_2/packets/InventoryPackets.java +++ b/common/src/main/java/us/myles/ViaVersion/protocols/protocol1_13to1_12_2/packets/InventoryPackets.java @@ -178,7 +178,12 @@ public class InventoryPackets { Via.getPlatform().getLogger().warning("Ignoring plugin channel in outgoing REGISTER: " + channels[i]); } } - wrapper.write(Type.REMAINING_BYTES, Joiner.on('\0').join(rewrittenChannels).getBytes(StandardCharsets.UTF_8)); + if (!rewrittenChannels.isEmpty()) { + wrapper.write(Type.REMAINING_BYTES, Joiner.on('\0').join(rewrittenChannels).getBytes(StandardCharsets.UTF_8)); + } else { + wrapper.cancel(); + return; + } } } wrapper.set(Type.STRING, 0, channel);