From 9387b86e4a4eee77c717240a88596cb5647c2b29 Mon Sep 17 00:00:00 2001
From: Nassim Jahnke <nassim@njahnke.dev>
Date: Fri, 8 Dec 2023 21:23:57 +0100
Subject: [PATCH] Clone tags instead of abusing double conversion

---
 .../packets/InventoryPackets.java             | 22 +++++++++----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_13to1_12_2/packets/InventoryPackets.java b/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_13to1_12_2/packets/InventoryPackets.java
index 2f6cc3198..956111ea5 100644
--- a/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_13to1_12_2/packets/InventoryPackets.java
+++ b/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_13to1_12_2/packets/InventoryPackets.java
@@ -17,8 +17,13 @@
  */
 package com.viaversion.viaversion.protocols.protocol1_13to1_12_2.packets;
 
-import com.github.steveice10.opennbt.conversion.ConverterRegistry;
-import com.github.steveice10.opennbt.tag.builtin.*;
+import com.github.steveice10.opennbt.tag.builtin.CompoundTag;
+import com.github.steveice10.opennbt.tag.builtin.IntTag;
+import com.github.steveice10.opennbt.tag.builtin.ListTag;
+import com.github.steveice10.opennbt.tag.builtin.NumberTag;
+import com.github.steveice10.opennbt.tag.builtin.ShortTag;
+import com.github.steveice10.opennbt.tag.builtin.StringTag;
+import com.github.steveice10.opennbt.tag.builtin.Tag;
 import com.google.common.base.Joiner;
 import com.google.common.primitives.Ints;
 import com.viaversion.viaversion.api.Via;
@@ -36,7 +41,6 @@ import com.viaversion.viaversion.protocols.protocol1_13to1_12_2.data.SoundSource
 import com.viaversion.viaversion.protocols.protocol1_13to1_12_2.data.SpawnEggRewriter;
 import com.viaversion.viaversion.rewriter.ItemRewriter;
 import com.viaversion.viaversion.util.Key;
-
 import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.List;
@@ -357,7 +361,7 @@ public class InventoryPackets extends ItemRewriter<ClientboundPackets1_12_1, Ser
             if (tag.get("CanPlaceOn") instanceof ListTag) {
                 ListTag old = tag.get("CanPlaceOn");
                 ListTag newCanPlaceOn = new ListTag(StringTag.class);
-                tag.put(NBT_TAG_NAME + "|CanPlaceOn", ConverterRegistry.convertToTag(ConverterRegistry.convertToValue(old))); // There will be data losing
+                tag.put(NBT_TAG_NAME + "|CanPlaceOn", old.clone());
                 for (Tag oldTag : old) {
                     Object value = oldTag.getValue();
                     String oldId = Key.stripMinecraftNamespace(value.toString());
@@ -379,7 +383,7 @@ public class InventoryPackets extends ItemRewriter<ClientboundPackets1_12_1, Ser
             if (tag.get("CanDestroy") instanceof ListTag) {
                 ListTag old = tag.get("CanDestroy");
                 ListTag newCanDestroy = new ListTag(StringTag.class);
-                tag.put(NBT_TAG_NAME + "|CanDestroy", ConverterRegistry.convertToTag(ConverterRegistry.convertToValue(old))); // There will be data losing
+                tag.put(NBT_TAG_NAME + "|CanDestroy", old.clone());
                 for (Tag oldTag : old) {
                     Object value = oldTag.getValue();
                     String oldId = Key.stripMinecraftNamespace(value.toString());
@@ -617,8 +621,7 @@ public class InventoryPackets extends ItemRewriter<ClientboundPackets1_12_1, Ser
                 tag.put("StoredEnchantments", newStoredEnch);
             }
             if (tag.get(NBT_TAG_NAME + "|CanPlaceOn") instanceof ListTag) {
-                tag.put("CanPlaceOn", ConverterRegistry.convertToTag(ConverterRegistry.convertToValue(tag.get(NBT_TAG_NAME + "|CanPlaceOn"))));
-                tag.remove(NBT_TAG_NAME + "|CanPlaceOn");
+                tag.put("CanPlaceOn", tag.remove(NBT_TAG_NAME + "|CanPlaceOn"));
             } else if (tag.get("CanPlaceOn") instanceof ListTag) {
                 ListTag old = tag.get("CanPlaceOn");
                 ListTag newCanPlaceOn = new ListTag(StringTag.class);
@@ -638,10 +641,7 @@ public class InventoryPackets extends ItemRewriter<ClientboundPackets1_12_1, Ser
                 tag.put("CanPlaceOn", newCanPlaceOn);
             }
             if (tag.get(NBT_TAG_NAME + "|CanDestroy") instanceof ListTag) {
-                tag.put("CanDestroy", ConverterRegistry.convertToTag(
-                        ConverterRegistry.convertToValue(tag.get(NBT_TAG_NAME + "|CanDestroy"))
-                ));
-                tag.remove(NBT_TAG_NAME + "|CanDestroy");
+                tag.put("CanDestroy", tag.remove(NBT_TAG_NAME + "|CanDestroy"));
             } else if (tag.get("CanDestroy") instanceof ListTag) {
                 ListTag old = tag.get("CanDestroy");
                 ListTag newCanDestroy = new ListTag(StringTag.class);