Merge pull request #890 from creeper123123321/master

Remove redundant tags

common/src/main/java/us/myles/ViaVersion/protocols/protocol1_13to1_12_2/data/SpawnEggRewriter.java

@@ -64,7 +64,8 @@ public class SpawnEggRewriter {
     public static int getSpawnEggId(String entityIdentifier) {
         // Fallback to bat
         if (!spawnEggs.containsKey(entityIdentifier))
-            return 25100288;
+            //return 25100288;
+            return -1;
         return (383 << 16 | (spawnEggs.get(entityIdentifier) & 0xFFFF));
     }
 

common/src/main/java/us/myles/ViaVersion/protocols/protocol1_13to1_12_2/packets/InventoryPackets.java

@@ -265,6 +265,8 @@ public class InventoryPackets {
         // Save original id
         int originalId = (item.getId() << 16 | item.getData() & 0xFFFF);
 
+        int rawId = (item.getId() << 4 | item.getData() & 0xF);
+
         // NBT Additions
         if (isDamageable(item.getId())) {
             if (tag == null) item.setTag(tag = new CompoundTag("tag"));
@@ -343,24 +345,31 @@ public class InventoryPackets {
                 tag.remove("StoredEnchantments");
                 tag.put(newStoredEnch);
             }
-        }
-
-        int rawId = (item.getId() << 4 | item.getData() & 0xF);
-
-        // Handle SpawnEggs
-        if (item.getId() == 383) {
-            if (tag != null && tag.get("EntityTag") instanceof CompoundTag) {
-                CompoundTag entityTag = tag.get("EntityTag");
-                if (entityTag.get("id") instanceof StringTag) {
-                    StringTag identifier = entityTag.get("id");
-                    rawId = SpawnEggRewriter.getSpawnEggId(identifier.getValue());
+            // Handle SpawnEggs
+            if (item.getId() == 383) {
+                if (tag.get("EntityTag") instanceof CompoundTag) {
+                    CompoundTag entityTag = tag.get("EntityTag");
+                    if (entityTag.get("id") instanceof StringTag) {
+                        StringTag identifier = entityTag.get("id");
+                        rawId = SpawnEggRewriter.getSpawnEggId(identifier.getValue());
+                        if (rawId == -1) {
+                            rawId = 25100288; // Bat fallback
+                        } else {
+                            entityTag.remove("id");
+                            if (entityTag.isEmpty())
+                                tag.remove("EntityTag");
+                        }
+                    } else {
+                        // Fallback to bat
+                        rawId = 25100288;
+                    }
                 } else {
                     // Fallback to bat
                     rawId = 25100288;
                 }
-            } else {
-                // Fallback to bat
-                rawId = 25100288;
+            }
+            if (tag.isEmpty()) {
+                item.setTag(tag = null);
             }
         }
 

common/src/main/java/us/myles/ViaVersion/protocols/protocol1_13to1_12_2/packets/WorldPackets.java

@@ -171,6 +171,14 @@ public class WorldPackets {
                             }
                         }
 
+                        // Rewrite biome id 255 to plains
+                        if (chunk.isBiomeData()) {
+                            for (int i = 0; i < 256; i++) {
+                                if (chunk.getBiomeData()[i] == -1)
+                                    chunk.getBiomeData()[i] = 1;
+                            }
+                        }
+
                         // Rewrite BlockEntities to normal blocks
                         BlockEntityProvider provider = Via.getManager().getProviders().get(BlockEntityProvider.class);
                         for (CompoundTag tag : chunk.getBlockEntities()) {

common/src/main/java/us/myles/ViaVersion/protocols/protocol1_13to1_12_2/types/Chunk1_13Type.java

@@ -101,7 +101,7 @@ public class Chunk1_13Type extends PartialType<Chunk, ClientWorld> {
         // Write biome data
         if (chunk.isBiomeData()) {
             for (byte value : chunk.getBiomeData()) {
-                output.writeInt(0); // This is a temporary workaround, we'll look into fixing this soon :)
+                output.writeInt(value & 0xFF); // This is a temporary workaround, we'll look into fixing this soon :)
             }
         }