diff --git a/api/src/main/java/com/viaversion/viaversion/api/protocol/AbstractProtocol.java b/api/src/main/java/com/viaversion/viaversion/api/protocol/AbstractProtocol.java index e62090149..bc939f55f 100644 --- a/api/src/main/java/com/viaversion/viaversion/api/protocol/AbstractProtocol.java +++ b/api/src/main/java/com/viaversion/viaversion/api/protocol/AbstractProtocol.java @@ -38,6 +38,7 @@ import com.viaversion.viaversion.api.protocol.packet.provider.PacketTypeMap; import com.viaversion.viaversion.api.protocol.packet.provider.PacketTypesProvider; import com.viaversion.viaversion.api.protocol.packet.provider.SimplePacketTypesProvider; import com.viaversion.viaversion.api.protocol.remapper.PacketHandler; +import com.viaversion.viaversion.api.rewriter.Rewriter; import com.viaversion.viaversion.exception.CancelException; import com.viaversion.viaversion.exception.InformativeException; import java.util.Collections; @@ -148,6 +149,8 @@ public abstract class AbstractProtocol rewriter) { + if (rewriter != null) { + rewriter.register(); + } + } + + private void callOnMappingDataLoaded(@Nullable Rewriter rewriter) { + if (rewriter != null) { + rewriter.onMappingDataLoaded(); + } } protected void addEntityTracker(UserConnection connection, EntityTracker tracker) { diff --git a/api/src/main/java/com/viaversion/viaversion/api/rewriter/Rewriter.java b/api/src/main/java/com/viaversion/viaversion/api/rewriter/Rewriter.java index bc6cf38f7..77793c96a 100644 --- a/api/src/main/java/com/viaversion/viaversion/api/rewriter/Rewriter.java +++ b/api/src/main/java/com/viaversion/viaversion/api/rewriter/Rewriter.java @@ -37,4 +37,7 @@ public interface Rewriter { * @return protocol of the rewriter */ T protocol(); + + default void onMappingDataLoaded() { + } } diff --git a/api/src/main/java/com/viaversion/viaversion/api/rewriter/RewriterBase.java b/api/src/main/java/com/viaversion/viaversion/api/rewriter/RewriterBase.java index 637c28be3..1c8794037 100644 --- a/api/src/main/java/com/viaversion/viaversion/api/rewriter/RewriterBase.java +++ b/api/src/main/java/com/viaversion/viaversion/api/rewriter/RewriterBase.java @@ -49,9 +49,6 @@ public abstract class RewriterBase implements Rewriter { protected void registerRewrites() { } - public void onMappingDataLoaded() { - } - @Override public T protocol() { return protocol; diff --git a/bungee/src/main/java/com/viaversion/viaversion/BungeePlugin.java b/bungee/src/main/java/com/viaversion/viaversion/BungeePlugin.java index f1cc96bf7..6c1005891 100644 --- a/bungee/src/main/java/com/viaversion/viaversion/BungeePlugin.java +++ b/bungee/src/main/java/com/viaversion/viaversion/BungeePlugin.java @@ -59,7 +59,7 @@ public class BungeePlugin extends Plugin implements ViaServerProxyPlatform subPlatforms = new HashSet<>(); private List enableListeners = new ArrayList<>(); - private PlatformTask mappingLoadingTask; - private boolean debug; + private PlatformTask mappingLoadingTask; public ViaManagerImpl(ViaPlatform platform, ViaInjector injector, ViaCommandHandler commandHandler, ViaPlatformLoader loader) { this.platform = platform; @@ -124,7 +123,7 @@ public class ViaManagerImpl implements ViaManager { if (platform.isProxy()) { platform.getLogger().info("ViaVersion detected lowest supported version by the proxy: " + ProtocolVersion.getProtocol(protocolVersion.lowestSupportedVersion())); platform.getLogger().info("Highest supported version by the proxy: " + ProtocolVersion.getProtocol(protocolVersion.highestSupportedVersion())); - if (debug) { + if (debugHandler.enabled()) { platform.getLogger().info("Supported version range: " + Arrays.toString(protocolVersion.supportedVersions().toArray(new int[0]))); } } else { diff --git a/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_10to1_9_3/Protocol1_10To1_9_3_4.java b/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_10to1_9_3/Protocol1_10To1_9_3_4.java index 831ee1a65..77933c326 100644 --- a/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_10to1_9_3/Protocol1_10To1_9_3_4.java +++ b/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_10to1_9_3/Protocol1_10To1_9_3_4.java @@ -27,7 +27,6 @@ import com.viaversion.viaversion.api.protocol.AbstractProtocol; import com.viaversion.viaversion.api.protocol.packet.PacketWrapper; import com.viaversion.viaversion.api.protocol.remapper.PacketHandlers; import com.viaversion.viaversion.api.protocol.remapper.ValueTransformer; -import com.viaversion.viaversion.api.rewriter.ItemRewriter; import com.viaversion.viaversion.api.type.Type; import com.viaversion.viaversion.api.type.types.version.Types1_9; import com.viaversion.viaversion.protocols.protocol1_10to1_9_3.packets.InventoryPackets; @@ -58,7 +57,7 @@ public class Protocol1_10To1_9_3_4 extends AbstractProtocol { - private final EntityRewriter metadataRewriter = new MetadataRewriter1_14_1To1_14(this); + private final MetadataRewriter1_14_1To1_14 metadataRewriter = new MetadataRewriter1_14_1To1_14(this); public Protocol1_14_1To1_14() { super(ClientboundPackets1_14.class, ClientboundPackets1_14.class, ServerboundPackets1_14.class, ServerboundPackets1_14.class); @@ -48,7 +47,7 @@ public class Protocol1_14_1To1_14 extends AbstractProtocol soundRewriter = new SoundRewriter<>(this); soundRewriter.registerSound(ClientboundPackets1_19_3.ENTITY_SOUND); @@ -84,6 +83,7 @@ public final class Protocol1_19_4To1_19_3 extends AbstractProtocol