From 6e5992c16896742a5bd12251700b5c161b54266f Mon Sep 17 00:00:00 2001
From: Nassim Jahnke <jahnke.nassim@gmail.com>
Date: Fri, 1 Oct 2021 16:33:18 +0200
Subject: [PATCH] Add docs to abstract LegacyViaInjector methods

---
 .../viaversion/platform/LegacyViaInjector.java | 18 ++++++++++++++++++
 .../util/SynchronizedListWrapper.java          |  4 +---
 2 files changed, 19 insertions(+), 3 deletions(-)

diff --git a/common/src/main/java/com/viaversion/viaversion/platform/LegacyViaInjector.java b/common/src/main/java/com/viaversion/viaversion/platform/LegacyViaInjector.java
index 791ee09c1..b6704e339 100644
--- a/common/src/main/java/com/viaversion/viaversion/platform/LegacyViaInjector.java
+++ b/common/src/main/java/com/viaversion/viaversion/platform/LegacyViaInjector.java
@@ -238,9 +238,27 @@ public abstract class LegacyViaInjector implements ViaInjector {
         return "decoder";
     }
 
+    /**
+     * Returns the Vanilla server connection object the channels to be injected should be searched in.
+     *
+     * @return server connection object, or null if failed
+     */
     protected abstract @Nullable Object getServerConnection() throws ReflectiveOperationException;
 
+    /**
+     * Returns a new Via channel initializer wrapping the original one.
+     *
+     * @param oldInitializer original channel initializer
+     * @return wrapped Via channel initializer
+     */
     protected abstract WrappedChannelInitializer createChannelInitializer(ChannelInitializer<Channel> oldInitializer);
 
+    /**
+     * Should throw a {@link RuntimeException} with information on what/who might have caused an issue.
+     * Called when injection fails.
+     *
+     * @param bootstrapAcceptor head channel handler to be used when blaming
+     * @throws ReflectiveOperationException during reflective operation
+     */
     protected abstract void blame(ChannelHandler bootstrapAcceptor) throws ReflectiveOperationException;
 }
\ No newline at end of file
diff --git a/common/src/main/java/com/viaversion/viaversion/util/SynchronizedListWrapper.java b/common/src/main/java/com/viaversion/viaversion/util/SynchronizedListWrapper.java
index 035af05cf..ac7d2a474 100644
--- a/common/src/main/java/com/viaversion/viaversion/util/SynchronizedListWrapper.java
+++ b/common/src/main/java/com/viaversion/viaversion/util/SynchronizedListWrapper.java
@@ -46,9 +46,7 @@ public final class SynchronizedListWrapper<E> implements List<E> {
     }
 
     private void handleAdd(E o) {
-        synchronized (this) {
-            addHandler.accept(o);
-        }
+        addHandler.accept(o);
     }
 
     @Override